Received: by 2002:a5b:505:0:0:0:0:0 with SMTP id o5csp270898ybp; Tue, 8 Oct 2019 17:51:49 -0700 (PDT) X-Google-Smtp-Source: APXvYqxQkksG6+ehsvo0rp6VQebIOKDtZw8pGI1JF/fhxDLuNNAbxdZCkLuUYDlk1Ii8YWppkoeC X-Received: by 2002:a17:907:2095:: with SMTP id pv21mr447120ejb.324.1570582309420; Tue, 08 Oct 2019 17:51:49 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1570582309; cv=none; d=google.com; s=arc-20160816; b=RsUXLXAXha4DnIpoCDS9sT4sc3AvlwXnvBJgL5hzo6NClglS0fPsRHniW9W9SIsUZF qGEueCF/gxAbq9DxbmRG3FsDrf5+pqZ0rwFhn8VQcgIdZgeDXcs3KZ28VxQsuMIm9TRz gQx+CASsjY2hKZLzTR6rKmoMjXu81FBI9mgBNxm8Wm36fLZpse9iZKcYJCo8iMkDFtYN ZVUukW6sShzSmw1vdfjtdy32fPXlPV3vc+X237FMNdyKNuLVuNwJgU4FATDRUZYK+PWy hku30Q+wZ8CV5lGoGDIRhmfvm5P+FBGRhlT+dgan0O+EtF8rePJq5C3VkwW6duR9PDFI wkoQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding :content-language:in-reply-to:mime-version:user-agent:date :message-id:from:references:cc:to:subject:dmarc-filter :dkim-signature:dkim-signature; bh=YtYMEFf8gcxbW0lIlnCjhqonXo5p3XdB/E7WTWeIDQY=; b=yh+sTvEUqoS/FeuJnD1UhMMW5lzdRf35ZRozc2ul69zRFWr3oZtKJMo06hJoMV/NGx AAPTfbHNrhUiCAXZ4Qj3dHqfdpQX2/tkb4I9WHq4+W3aabc3kINXLtloaZK8awtBgKlh gqUrlEFYlKMwPhW9FdIb9BmPYzDdD04YetfaYMNt7Csmn99YJpLKMa5p6G3mg5N6acwH +X2WQu+2fLSEUUGixnaX4ToKiLfoaW5to8TujFrJG+5NLAyQf4Kiv5DshmtKIdRLbI8F vKC+YFsWRvAsg2+NGCUspoyphlJKzHSkNLJe1ORK2TY5Es0DyfYg18jDxnfWnVPnJO9r tvZg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@codeaurora.org header.s=default header.b=WsBkMIBO; dkim=pass header.i=@codeaurora.org header.s=default header.b=ZVWG6qZ7; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id p14si457898eda.411.2019.10.08.17.51.26; Tue, 08 Oct 2019 17:51:49 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@codeaurora.org header.s=default header.b=WsBkMIBO; dkim=pass header.i=@codeaurora.org header.s=default header.b=ZVWG6qZ7; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730050AbfJIAvH (ORCPT + 99 others); Tue, 8 Oct 2019 20:51:07 -0400 Received: from smtp.codeaurora.org ([198.145.29.96]:48840 "EHLO smtp.codeaurora.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729601AbfJIAvH (ORCPT ); Tue, 8 Oct 2019 20:51:07 -0400 Received: by smtp.codeaurora.org (Postfix, from userid 1000) id 5626160ACE; Wed, 9 Oct 2019 00:51:06 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=codeaurora.org; s=default; t=1570582266; bh=wMnZ8fLHDZFet4l9bJ3Rw5WAlIMaGnOLPYeJsWDcHCA=; h=Subject:To:Cc:References:From:Date:In-Reply-To:From; b=WsBkMIBO98XA9963iQk4siAlnZOgCQipbkIGYu091tX862q5oSnnWqlU5Ad2b5CR9 M+aqdoMNn99wixGIQamzMa3QwZkJENkpVp6BbBuYuj7r+5zciZ1V/mT1TsPDaK9O7S yvMsMx4wmEznowFEyE7yXcl/I98H5pfmRMfr5WCk= X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on pdx-caf-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.7 required=2.0 tests=ALL_TRUSTED,BAYES_00, DKIM_INVALID,DKIM_SIGNED,SPF_NONE autolearn=no autolearn_force=no version=3.4.0 Received: from [192.168.142.6] (i-global254.qualcomm.com [199.106.103.254]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) (Authenticated sender: clew@smtp.codeaurora.org) by smtp.codeaurora.org (Postfix) with ESMTPSA id 7AD3C6070D; Wed, 9 Oct 2019 00:51:05 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=codeaurora.org; s=default; t=1570582265; bh=wMnZ8fLHDZFet4l9bJ3Rw5WAlIMaGnOLPYeJsWDcHCA=; h=Subject:To:Cc:References:From:Date:In-Reply-To:From; b=ZVWG6qZ7u/O7PKUH9Fa/WFgf7mNVpxGuN3RqU3n4TmbHxTgQcUbcN6ry70ncnMNgm KRPNgKYHJWidgUgckaSSfPAg8flJYMT4CxvYmlELJ2M5GB1onVI6klWI03cMgjRWiw WTI4TDt30vegGTNGurFlxaSfYFtDdafusguo82ys= DMARC-Filter: OpenDMARC Filter v1.3.2 smtp.codeaurora.org 7AD3C6070D Authentication-Results: pdx-caf-mail.web.codeaurora.org; dmarc=none (p=none dis=none) header.from=codeaurora.org Authentication-Results: pdx-caf-mail.web.codeaurora.org; spf=none smtp.mailfrom=clew@codeaurora.org Subject: Re: [PATCH v2 2/6] rpmsg: glink: Fix use after free in open_ack TIMEOUT case To: Bjorn Andersson , Ohad Ben-Cohen Cc: linux-arm-msm@vger.kernel.org, linux-remoteproc@vger.kernel.org, linux-kernel@vger.kernel.org, stable@vger.kernel.org References: <20191004222702.8632-1-bjorn.andersson@linaro.org> <20191004222702.8632-3-bjorn.andersson@linaro.org> From: Chris Lew Message-ID: <3db040ee-6b0f-be45-0e23-ab65f16329b6@codeaurora.org> Date: Tue, 8 Oct 2019 17:51:05 -0700 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:60.0) Gecko/20100101 Thunderbird/60.9.0 MIME-Version: 1.0 In-Reply-To: <20191004222702.8632-3-bjorn.andersson@linaro.org> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 10/4/2019 3:26 PM, Bjorn Andersson wrote: > From: Arun Kumar Neelakantam > > Extra channel reference put when remote sending OPEN_ACK after timeout > causes use-after-free while handling next remote CLOSE command. > > Remove extra reference put in timeout case to avoid use-after-free. > > Fixes: b4f8e52b89f6 ("rpmsg: Introduce Qualcomm RPM glink driver") > Cc: stable@vger.kernel.org > Tested-by: Srinivas Kandagatla > Signed-off-by: Arun Kumar Neelakantam > Signed-off-by: Bjorn Andersson > --- Acked-By: Chris Lew -- Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, a Linux Foundation Collaborative Project