Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Content-Type: text/plain; charset="utf-8"
MIME-Version: 1.0
Content-Transfer-Encoding: quoted-printable
In-Reply-To: <20191007014509.25180-6-masneyb@onstation.org>
References: <20191007014509.25180-1-masneyb@onstation.org> <20191007014509.25180-6-masneyb@onstation.org>
From:   Stephen Boyd <sboyd@kernel.org>
To:     Brian Masney <masneyb@onstation.org>, robdclark@gmail.com,
        sean@poorly.run
Cc:     bjorn.andersson@linaro.org, a.hajda@samsung.com,
        Laurent.pinchart@ideasonboard.com, airlied@linux.ie,
        daniel@ffwll.ch, dri-devel@lists.freedesktop.org,
        linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org,
        freedreno@lists.freedesktop.org, jonathan@marek.ca,
        Linus Walleij <linus.walleij@linaro.org>
Subject: Re: [PATCH RFC v2 5/5] ARM: dts: qcom: msm8974-hammerhead: add support for external display
User-Agent: alot/0.8.1
Date:   Tue, 08 Oct 2019 19:25:33 -0700
Message-Id: <20191009022534.BD6C62070B@mail.kernel.org>
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

Quoting Brian Masney (2019-10-06 18:45:09)
> diff --git a/arch/arm/boot/dts/qcom-msm8974-lge-nexus5-hammerhead.dts b/a=
rch/arm/boot/dts/qcom-msm8974-lge-nexus5-hammerhead.dts
> index b607c9ff9e12..380a805cd1f0 100644
> --- a/arch/arm/boot/dts/qcom-msm8974-lge-nexus5-hammerhead.dts
> +++ b/arch/arm/boot/dts/qcom-msm8974-lge-nexus5-hammerhead.dts
> @@ -371,6 +401,40 @@
>                                 function =3D "gpio";
>                         };
>                 };
> +
> +               hdmi_pin: hdmi {
> +                       cec {
> +                               pins =3D "gpio31";
> +                               function =3D "hdmi_cec";
> +                       };
> +
> +                       ddc {
> +                               pins =3D "gpio32", "gpio33";
> +                               function =3D "hdmi_ddc";
> +                       };
> +
> +                       hpd {
> +                               pins =3D "gpio34";
> +                               function =3D "hdmi_hpd";
> +                       };
> +               };
> +
> +               anx_msm_pin: anx {
> +                       irq {
> +                               pins =3D "gpio28";
> +                               function =3D "gpio";

Is function =3D "gpio" necessary anymore? I thought we would turn gpios
into gpio function when it's requested as a gpio by some consumer.

> +                               drive-strength =3D <8>;
> +                               bias-pull-up;
> +                               input-enable;
> +                       };
> +
> +                       reset {
> +                               pins =3D "gpio68";
> +                               function =3D "gpio";
> +                               drive-strength =3D <8>;
> +                               bias-pull-up;
> +                       };
> +               };
>         };
> =20
>         vibrator@fd8c3450 {