Received: by 2002:a5b:505:0:0:0:0:0 with SMTP id o5csp366804ybp; Tue, 8 Oct 2019 19:54:11 -0700 (PDT) X-Google-Smtp-Source: APXvYqzy+ZDJdsZEWxLPyJnrnyTXpcAJaRsr+I/+xn6f5T+Z3uRy4SxG74FhazxE/9Og3XmnTI9y X-Received: by 2002:a17:906:5bcf:: with SMTP id w15mr784497ejs.84.1570589651417; Tue, 08 Oct 2019 19:54:11 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1570589651; cv=none; d=google.com; s=arc-20160816; b=Lpj5KV/cJLLv276JpBoEFyIVD8qAIb+q4tVGo62bl4VIC/2yfP4+qOuBHkqUy4zHyL M2NIj+GnrUj8f38vh9LyR9scl8sZAaP0vtAad9QL/YdKd18eWn7MGxp0P0KrqsDNuk2H 1o8JlylKmra27UPGdbti7vlMFRMRvFvG04VPx4NCjzPzig+cpC+NRNwtshyE3x57x3Nd B+usdKnBcfH8j5Qa8LSFUpCWU8MzvZzfvQj934NWVKnpsJQkEDY7U+JFk2OP3xcmvXpg MuQMXcIXfD+BmipYRko8ApDyPL7iXquM5f4WPZGF+1hCUICMte4G8GIZDyOyZJGNvTIz pq+w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :organization:references:in-reply-to:message-id:subject:cc:to:from :date:dkim-signature; bh=xRim+mhOCJGTKowYRKV3NyzpsEfdlIUKsJKh+AqHYlY=; b=X9/ZcsocQ6l+oRxgF6zBzcfV/Doto3Ishh6H5WLo0RsKpqnj/k+WDs7M7EiUEk/LVv LljC3APSBpabMTc2b9Grtpc1OMXggOsvz7BsV5FOiekgSR/u0/1TAPTkI35n4PXVrCz2 zKFuOkQKl5kSN/932JaB2kbYV7JtTytrFBdraUo14RLExcCGUAnchXlOES77yaK27Uog Q6ocWLOZp2CjJLL4jMoRIVc70oBKuAksxmJ2FsdbIW1OnB5PjFA76kKtgl4AJgNDmBMg Qb4ohq/MdIDEXubCzNKeqhLtgvTwwTxiSg8crpIlR9bSmBH4BQgvnqxiXG3FFAgcvbRW 4ing== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@netronome-com.20150623.gappssmtp.com header.s=20150623 header.b=o6YUX3IX; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id o2si398058ejm.367.2019.10.08.19.53.48; Tue, 08 Oct 2019 19:54:11 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@netronome-com.20150623.gappssmtp.com header.s=20150623 header.b=o6YUX3IX; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726109AbfJICxg (ORCPT + 99 others); Tue, 8 Oct 2019 22:53:36 -0400 Received: from mail-pg1-f193.google.com ([209.85.215.193]:38461 "EHLO mail-pg1-f193.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726490AbfJICxf (ORCPT ); Tue, 8 Oct 2019 22:53:35 -0400 Received: by mail-pg1-f193.google.com with SMTP id x10so435637pgi.5 for ; Tue, 08 Oct 2019 19:53:35 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=netronome-com.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:in-reply-to:references :organization:mime-version:content-transfer-encoding; bh=xRim+mhOCJGTKowYRKV3NyzpsEfdlIUKsJKh+AqHYlY=; b=o6YUX3IXKgDqRkUUB4jAxrLKnMv9u195epNuQDHWd79lRXpQirVzbkaFATUmcZpM6K qoOjmkCRW6UzwmI75V4bOke728nN3TleOlK3XILJxb/QVApSfoQMb0a/1/Wi1HTr/BHJ 4WnO3FeJrmNvL94QuM2HGLvvVbx1/be8SvV1kZvt3SMN7K5atHeLqetDo9P3b8FltOTm viiU5dbJaAxgEIbjxz65RyTApcQ06iTAJH7XXk6Eir97XkFJanXGPakVZ2KAF5PRipaj mHJs1KZtfy5pzdy52G/kwXpfv2FOQ1swcnZIfhtp6aWErREG76rbIYVOyFVRLn9sdq1n Ifdw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to :references:organization:mime-version:content-transfer-encoding; bh=xRim+mhOCJGTKowYRKV3NyzpsEfdlIUKsJKh+AqHYlY=; b=GPeq3rADcFNuCKLHIXgfpgiXFuEE6LH7Onu2GVUf7AJHO0zsd6orw+5WTB5sQpP9wS iw4eozY/c+nRr9sCG+j7mC9eMOANDIYS3870hG+3DOfgFwSLaKTmSvHzRwaOm/ZwyJtm D/GtYwQI0BqvFmwJHiMCMAKt0gKanBpfTjYvoTR4FSPwJNZqYeNteeb4A+2FVieQOgwG CAg3ey/8Ncjn6VMtgXJ5oHvdx/uhy8s6xbB5fkjl0S1ucHx+7M6JSzWpyM2PB6D3zzT+ 2XkzRNg0h5lF1MuyN6wmK7A5vRtE8MixHKxZMzL5rJWk7j7jAicQG7T9DiOM/MtQI+HH J+TQ== X-Gm-Message-State: APjAAAWltt3sIuoxqKFTytCvcKEZIt9V3yZUSzw6zdfj9a8n/tvogfOB EJ9CCdpzygxmBsrxj9koxSxizQ== X-Received: by 2002:a17:90a:ba83:: with SMTP id t3mr68082pjr.139.1570589614966; Tue, 08 Oct 2019 19:53:34 -0700 (PDT) Received: from cakuba.netronome.com (c-73-202-202-92.hsd1.ca.comcast.net. [73.202.202.92]) by smtp.gmail.com with ESMTPSA id 196sm529853pfz.99.2019.10.08.19.53.34 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 08 Oct 2019 19:53:34 -0700 (PDT) Date: Tue, 8 Oct 2019 19:53:22 -0700 From: Jakub Kicinski To: Haishuang Yan Cc: "David S. Miller" , William Tu , netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] ip6erspan: remove the incorrect mtu limit for ip6erspan Message-ID: <20191008195322.5787f7c6@cakuba.netronome.com> In-Reply-To: <1570528563-8062-1-git-send-email-yanhaishuang@cmss.chinamobile.com> References: <1570528563-8062-1-git-send-email-yanhaishuang@cmss.chinamobile.com> Organization: Netronome Systems, Ltd. MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 8 Oct 2019 17:56:03 +0800, Haishuang Yan wrote: > ip6erspan driver calls ether_setup(), after commit 61e84623ace3 > ("net: centralize net_device min/max MTU checking"), the range > of mtu is [min_mtu, max_mtu], which is [68, 1500] by default. > > It causes the dev mtu of the erspan device to not be greater > than 1500, this limit value is not correct for ip6erspan tap > device. > > Signed-off-by: Haishuang Yan Applied, but next time please make sure you add a Fixes tag, and put [PATCH net] in the subject for bug fixes. Thanks!