Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
From:   Pawel Laszczak <pawell@cadence.com>
To:     Felipe Balbi <felipe.balbi@linux.intel.com>,
        Peter Chen <peter.chen@nxp.com>
CC:     "gregkh@linuxfoundation.org" <gregkh@linuxfoundation.org>,
        "linux-usb@vger.kernel.org" <linux-usb@vger.kernel.org>,
        "rogerq@ti.com" <rogerq@ti.com>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "jbergsagel@ti.com" <jbergsagel@ti.com>,
        "nsekhar@ti.com" <nsekhar@ti.com>, "nm@ti.com" <nm@ti.com>,
        Suresh Punnoose <sureshp@cadence.com>,
        Rahul Kumar <kurahul@cadence.com>
Subject: RE: [PATCH] usb:cdns3: Fix for CV CH9 running with g_zero driver.
Thread-Topic: [PATCH] usb:cdns3: Fix for CV CH9 running with g_zero driver.
Thread-Index: AQHVfNoFXw2jDHNhgEqi0IjSc2aZBadQUViAgABlPoCAAPccUA==
Date:   Wed, 9 Oct 2019 03:58:17 +0000
Message-ID: <BYAPR07MB4709490136F8F65A008C219EDD950@BYAPR07MB4709.namprd07.prod.outlook.com>
References: <1570430355-26118-1-git-send-email-pawell@cadence.com>
 <20191008065619.GE5670@b29397-desktop> <87a7abv1f2.fsf@gmail.com>
In-Reply-To: <87a7abv1f2.fsf@gmail.com>
Accept-Language: en-US
Content-Language: en-US
received-spf: None (protection.outlook.com: cadence.com does not designate
 permitted sender hosts)
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-Network-Message-Id: 365c6a27-64d5-44d6-3543-08d74c6ceb29
X-MS-Exchange-CrossTenant-originalarrivaltime: 09 Oct 2019 03:58:18.0070
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: d36035c5-6ce6-4662-a3dc-e762e61ae4c9
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: M2YrVSaU9hb3NFKVZ9liBrwb8mmJNY68A01Q6kuWRhfgTLstTk7UZy9gi1n3kQUFX9E5vdEfyNUVmOz1xES7aSTNgQS10N/hW90XGramoGU=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BYAPR07MB4712
X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.95,1.0.8
 definitions=2019-10-09_02:2019-10-08,2019-10-09 signatures=0
X-Proofpoint-Spam-Details: rule=outbound_check_notspam policy=outbound_check score=0 malwarescore=0
 mlxlogscore=795 phishscore=0 spamscore=0 clxscore=1015 lowpriorityscore=0
 suspectscore=0 priorityscore=1501 adultscore=0 bulkscore=0 impostorscore=0
 mlxscore=0 classifier=spam adjust=0 reason=mlx scancount=1
 engine=8.12.0-1908290000 definitions=main-1910090033
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Hi,

>
>Hi,
>
>Peter Chen <peter.chen@nxp.com> writes:
>> On 19-10-07 07:39:11, Pawel Laszczak wrote:
>>> Patch fixes issue with Halt Endnpoint Test observed
>>
>> %s/Endnpoint/Endpoint
>>
>>>
>>> during using g_zero
>>> driver as DUT. Bug occurred only on some testing board.
>>
>> g_zero is legacy, please use configfs function source_sink or loopback
>> instead.
>
>We still want fixes for those ;-)

So, if my understanding is correct in new production systems
using legacy gadget drivers is not recommended and we are not going to fix
any more bugs there.=20

The legacy gadget drivers remains in the kernel only to support the old=20
products.=20

So because we introduce new driver we should not worry  about legacy=20
gadget drivers.

Is my understanding correct ?

pawell
=20
>
>>> Endpoint can defer transition to Halted state if endpoint has pending
>>> requests.
>>
>> The implementation of halt handling is a little complicated, you may
>> consider return -EAGAIN for functional stall through usb_ep_set_halt
>> from function driver if the requests are pending, it doesn't need to
>> defer such kinds of functional stall.
>
>-EAGAIN, IIRC is only supposed to be used for IN endpoint stalls.
>
>--
>balbi