Received: by 2002:a5b:505:0:0:0:0:0 with SMTP id o5csp589402ybp;
        Wed, 9 Oct 2019 00:42:07 -0700 (PDT)
X-Google-Smtp-Source: APXvYqyUcgL7LjMcqn/Y98TjBga2OtM90wSBd815PKJg4D3eUtk5CzeDuZEYbgtk21nmICilOyqo
X-Received: by 2002:a50:d556:: with SMTP id f22mr1690966edj.248.1570606927606;
        Wed, 09 Oct 2019 00:42:07 -0700 (PDT)
ARC-Seal: i=1; a=rsa-sha256; t=1570606927; cv=none;
        d=google.com; s=arc-20160816;
        b=qCTa5e3vpFuL9MNfKJS4iTLZLGzqOG+N1WPsGZrA4SkM6kcB2FIUnxGqGGDr54AuIO
         CoZXIPHFbY8I9gYF/uqp/Bsy4ACYmyg65PgEjnaZgz07p/ylEpKM1dk9K45wVVcc4CfB
         5bor8ih2T5j8Fv05EREFTKnTe+rJ92FSFHYjAz5Ba3DI5w6VZHzgEpvGwVJX9HfmKDXB
         Glb6MSf4R9dvz/6x5KYXlGl8z+Fnfmdy7BeMQAZEJgXNoSAAshhaNUAk+/PPU79sBOdX
         LxdDCAstqBZidvAY1LLEilGLSciAtOekapkHT9KpkEfQFVUF4iDmyg8WyfJ+v2BddMhw
         keAg==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816;
        h=list-id:precedence:sender:user-agent:in-reply-to
         :content-disposition:mime-version:references:message-id:subject:cc
         :to:from:date:dkim-signature;
        bh=baiVv4a2Uea2yTZJrebYsEwZaUn70mxXYupOEm3dQbc=;
        b=zCEhaKVPBGelNg5d80yQ48IhA/a0jKNuQMwLxeRG0PleUiYktxU1JouNCiV/sTu5gR
         LLPnzoS7hBFKQeDG2o0u4ZMd5KYZPz1Tlm2hjTYZQLpOgkas2ja6VaI77NW0VqVdT1Yn
         B/JGUjsi4NP5akEcAVzQhOFAsCD6y3ziQJ7JLi9IFHFggivqQAUt6bUe4oFjX0K3aJrx
         ExZI96PsQSivrijbqsuJ0hYEsEoQLV9x/kwO9RssLSlpN4FUNT86inMyFy2PBGcdKDH+
         C5hjmO5/MUqyhw2ZJKe4d56V47oMNsdPPo47is23UybRhQcJZdMLfBzfl3k95p7Nnevr
         dclg==
ARC-Authentication-Results: i=1; mx.google.com;
       dkim=fail header.i=@infradead.org header.s=bombadil.20170209 header.b=qRZLYML8;
       spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67])
        by mx.google.com with ESMTP id j14si862811eda.181.2019.10.09.00.41.44;
        Wed, 09 Oct 2019 00:42:07 -0700 (PDT)
Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Authentication-Results: mx.google.com;
       dkim=fail header.i=@infradead.org header.s=bombadil.20170209 header.b=qRZLYML8;
       spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1729595AbfJIHj2 (ORCPT <rfc822;1990.zhangzhen@gmail.com>
        + 99 others); Wed, 9 Oct 2019 03:39:28 -0400
Received: from bombadil.infradead.org ([198.137.202.133]:48254 "EHLO
        bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1725776AbfJIHj1 (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Wed, 9 Oct 2019 03:39:27 -0400
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
        d=infradead.org; s=bombadil.20170209; h=In-Reply-To:Content-Type:MIME-Version
        :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To:
        Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date:
        Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id:
        List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive;
         bh=baiVv4a2Uea2yTZJrebYsEwZaUn70mxXYupOEm3dQbc=; b=qRZLYML8fZIGPOUFVit/FLmvx
        qgVXvUHJYoCdC+71GLaypG+EIWHXjTQXPpbTF2mxm9WrpMRbP6OJRVJWjFgaiaW/llFXBOJAR78Vs
        9Q+px+8LlW9mqzCJImURq9QaryTQdwKGtD4cnbhbuoFslmYUkQs3Extmb7giDPFCEMrtrUyQAPIWT
        sU9OIgrOfYqTm+AVwzxif+67dDyGiyPrTbb8IxwoQhmR1hy8v0P9oxWmwhhPGm4qq+NDnM38pGTbc
        9xdXEex2JMqcg6uVZDb36+pDd/1yMHL7h5UhJzoV1OSxImjVtAOzjkWdN4KrKTazYF5G4uilXa9hW
        0Qgz+JOTA==;
Received: from hch by bombadil.infradead.org with local (Exim 4.92.2 #3 (Red Hat Linux))
        id 1iI6ZC-0006WF-Mu; Wed, 09 Oct 2019 07:39:26 +0000
Date:   Wed, 9 Oct 2019 00:39:26 -0700
From:   Christoph Hellwig <hch@infradead.org>
To:     Madalin Bucur <madalin.bucur@nxp.com>
Cc:     davem@davemloft.net, netdev@vger.kernel.org, roy.pledge@nxp.com,
        laurentiu.tudor@nxp.com, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 19/20] dpaa_eth: add dpaa_dma_to_virt()
Message-ID: <20191009073926.GA6916@infradead.org>
References: <1570536641-25104-1-git-send-email-madalin.bucur@nxp.com>
 <1570536641-25104-20-git-send-email-madalin.bucur@nxp.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1570536641-25104-20-git-send-email-madalin.bucur@nxp.com>
User-Agent: Mutt/1.12.1 (2019-06-15)
X-SRS-Rewrite: SMTP reverse-path rewritten from <hch@infradead.org> by bombadil.infradead.org. See http://www.infradead.org/rpr.html
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Tue, Oct 08, 2019 at 03:10:40PM +0300, Madalin Bucur wrote:
> Centralize the phys_to_virt() calls.

You don't need to centralize those, you need to fix them.  Calling
phys_to_virt on a dma_addr is completely bogus.