Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
From:   Biju Das <biju.das@bp.renesas.com>
To:     Mao Wenan <maowenan@huawei.com>,
        "heikki.krogerus@linux.intel.com" <heikki.krogerus@linux.intel.com>,
        "gregkh@linuxfoundation.org" <gregkh@linuxfoundation.org>
CC:     "linux-usb@vger.kernel.org" <linux-usb@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "kernel-janitors@vger.kernel.org" <kernel-janitors@vger.kernel.org>,
        Hulk Robot <hulkci@huawei.com>
Subject: RE: [PATCH -next] usb: typec: add dependency for TYPEC_HD3SS3220
Thread-Topic: [PATCH -next] usb: typec: add dependency for TYPEC_HD3SS3220
Thread-Index: AQHVfkOKloVrfMGidkOyU5GyOdNjm6dR8ZyQ
Date:   Wed, 9 Oct 2019 08:00:22 +0000
Message-ID: <OSBPR01MB21038DCAFE45CE0FFC06EE91B8950@OSBPR01MB2103.jpnprd01.prod.outlook.com>
References: <20191009014707.38716-1-maowenan@huawei.com>
In-Reply-To: <20191009014707.38716-1-maowenan@huawei.com>
Accept-Language: en-GB, en-US
Content-Language: en-US
received-spf: None (protection.outlook.com: bp.renesas.com does not designate
 permitted sender hosts)
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-Network-Message-Id: 72e3dddf-8098-4bfa-eedb-08d74c8ebcb6
X-MS-Exchange-CrossTenant-originalarrivaltime: 09 Oct 2019 08:00:22.9128
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 53d82571-da19-47e4-9cb4-625a166a4a2a
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: Z4rN1M1F55uKUOjNOBEmLBWcpNjxgyXZ6MO5lUYaYxCU1WbBiQH5Xm64R8I+RsgxS6TOTR9/xg+sPENtNJqftw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: OSBPR01MB1638
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Hello Mao Wenan,

Thanks for the patch.

> Subject: [PATCH -next] usb: typec: add dependency for TYPEC_HD3SS3220
>=20
> If CONFIG_TYPEC_HD3SS3220=3Dy, CONFIG_USB_ROLE_SWITCH=3Dm, below
> errors can be found:
> drivers/usb/typec/hd3ss3220.o: In function `hd3ss3220_remove':
> hd3ss3220.c:(.text+0x64): undefined reference to `usb_role_switch_put'
> drivers/usb/typec/hd3ss3220.o: In function `hd3ss3220_dr_set':
> hd3ss3220.c:(.text+0x154): undefined reference to
> `usb_role_switch_set_role'
> drivers/usb/typec/hd3ss3220.o: In function `hd3ss3220_set_role':
> hd3ss3220.c:(.text+0x294): undefined reference to
> `usb_role_switch_set_role'
> hd3ss3220.c:(.text+0x2f4): undefined reference to
> `usb_role_switch_set_role'
> hd3ss3220.c:(.text+0x348): undefined reference to
> `usb_role_switch_set_role'
> hd3ss3220.c:(.text+0x390): undefined reference to
> `usb_role_switch_set_role'
> drivers/usb/typec/hd3ss3220.o: In function `hd3ss3220_probe':
> hd3ss3220.c:(.text+0x5e8): undefined reference to
> `fwnode_usb_role_switch_get'
> hd3ss3220.c:(.text+0x8a4): undefined reference to `usb_role_switch_put'
> make: *** [vmlinux] Error 1
>=20
> This patch add dependency USB_ROLE_SWITCH for TYPEC_HD3SS3220.
>=20
> Fixes: 1c48c759ef4b ("usb: typec: driver for TI HD3SS3220 USB Type-C DRP
> port controller")
> Reported-by: Hulk Robot <hulkci@huawei.com>
> Signed-off-by: Mao Wenan <maowenan@huawei.com>

Reviewed-by: Biju Das <biju.das@bp.renesas.com>

Regards,
Biju
> ---
>  drivers/usb/typec/Kconfig | 1 +
>  1 file changed, 1 insertion(+)
>=20
> diff --git a/drivers/usb/typec/Kconfig b/drivers/usb/typec/Kconfig index
> aceb2af..b4f2aac 100644
> --- a/drivers/usb/typec/Kconfig
> +++ b/drivers/usb/typec/Kconfig
> @@ -53,6 +53,7 @@ source "drivers/usb/typec/ucsi/Kconfig"
>  config TYPEC_HD3SS3220
>  	tristate "TI HD3SS3220 Type-C DRP Port controller driver"
>  	depends on I2C
> +	depends on USB_ROLE_SWITCH
>  	help
>  	  Say Y or M here if your system has TI HD3SS3220 Type-C DRP Port
>  	  controller driver.
> --
> 2.7.4