Received: by 2002:a5b:505:0:0:0:0:0 with SMTP id o5csp665368ybp; Wed, 9 Oct 2019 02:13:32 -0700 (PDT) X-Google-Smtp-Source: APXvYqz4axJ9Ru4Rl7jl+hp5c0c7WLWYdJsqClJTruMuv+fHZBy1+UGk83p1dNDFNdGpnzmWp9dv X-Received: by 2002:a17:906:19cf:: with SMTP id h15mr1847523ejd.184.1570612411945; Wed, 09 Oct 2019 02:13:31 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1570612411; cv=none; d=google.com; s=arc-20160816; b=WDqncisURyFfXS+ThZ6mNyRcwluAY722z7O12Sa8PfV6/iFUQfg565LUe3f6AuxMHN u7MY5LkhLiGhOdj3vf2Y+8ewpMBmM9A0mpwBpDDkbZwv/RF0+wlbxuDNXsM4rgP+9LwM 1KRf7XuIbKAf+BcpwQ0ZwhOEZ5zs997yZ+WA0HKf4yOPqNuGym1cuF+ii0zuYGun6YNl KAre8Su0HrK/srL0ucbzrYepNFEuU5f+EkmKGiPFdjSbCL0U0sVtuod5bG40hzZxU1kD byUuIzM88xJYz2qwf4iEYv9tgqu+8fJRopb/2mAozh3kSWuExvoirwxQZnzf1Jbd51WD SnJQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:dkim-signature; bh=DnaMjWPHRTxP2HwHozaEda4iUBnS+Mgb8NeafSlvJXU=; b=jhof1CdXKBaBZvcPoDbvO2aRlXhf9x9EOhF9gNHQA3i9h4Nh0wsP/irVb5MsxJcodB 5oJ1gvgnqxi1tTM0yABkLKdyRW3N8vQUyNtuoLucyio3ok9XueHyGrLK+sGQ7AmG3bBq g5W2ElFD2m6dnW966tVpZtKYw3hXJvXegcy1X4NFOXoV9PfCgJfzEgclQLgz5+e9qtE/ /eh14yyN5ZpK8yhLOHmSb556v9O6XIOx1cNo3YuQ5QXDoVOJzOy7ceT6t0FWvDB5P2eb 4hiGq+8IJrgcGPcHcnEpSN2KsI7PXDONlskLKhxB3NXYRi5qRKNkP/kNaqVPYvvLX04Q KFLA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=yKNY9SGc; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id f45si979353eda.345.2019.10.09.02.13.08; Wed, 09 Oct 2019 02:13:31 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=yKNY9SGc; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730121AbfJIJMx (ORCPT + 99 others); Wed, 9 Oct 2019 05:12:53 -0400 Received: from mail-vs1-f67.google.com ([209.85.217.67]:44241 "EHLO mail-vs1-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725942AbfJIJMx (ORCPT ); Wed, 9 Oct 2019 05:12:53 -0400 Received: by mail-vs1-f67.google.com with SMTP id w195so1010687vsw.11 for ; Wed, 09 Oct 2019 02:12:52 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=DnaMjWPHRTxP2HwHozaEda4iUBnS+Mgb8NeafSlvJXU=; b=yKNY9SGcN2UsFvhR61yYb/jrlCVKgel12IYbR40rpV44lcbYSBZBivKCyQa3goz2oi wVn3L9kPGJF9gxBuLeJ34zX2+mGkfp28ZbQrzgrGx653cBpNaahPfaGFn/7zIN1RLXzR N9d9Glovn5NceLF76IOJ8fuPAyYZHS4PO6Hp6PUO1I/Y5PtLaqHiOpDeqVejYagbTlau AOiiySye8tVrQ7tMtrxJ4JTu0nNgQRdmTllW/3qJsQa/aV2UQw8hG9CBM6b6JwfIbyaQ MqKF6DODn7ifaUKjsfyiAna4yN7hfctndvK63mGetiRedO0K8Ct7Ym3KXmbe/EroZtSU zejQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=DnaMjWPHRTxP2HwHozaEda4iUBnS+Mgb8NeafSlvJXU=; b=W8XYxWbCpyQDBRJUzNTnxjJ/iwQtYtzICuS49tn5c5j33thyyPhQWwfxYNynP0JU+o WNhuuHd+ufudxuL0vZKjZgVecWPZ/KKs6dEUyey2JYwsRVQqc5EyHIIOAmikt9fULbKY HZKNI54TjJAH8ycy0ipqks9xFZJNlC0lGIw0e/ojvp7siN6PmJdswgDBLc2azU32U46M FwwoBadLsCkkXONBO2Z8fz8H3RF8oIFZwH579N5hNBIsFm9Q7PY0vY3Ju+X8PUjjC6kj qgtLmJeEzv9sKHeR+ZyPEiw3LhhvfjPmPliPEdd+e3xIB06NcEwcbHJ011BOeNO034Yy kXkQ== X-Gm-Message-State: APjAAAUxctY1kG/V3mH2H2hfIatpReWRwNFe12IYxedbEWNdfbULTjk8 G+M3Brn/qGur7Z0zwgMuEwZn1yxydA0CpUWEaKTYXQ== X-Received: by 2002:a05:6102:5e1:: with SMTP id w1mr1211701vsf.191.1570612371638; Wed, 09 Oct 2019 02:12:51 -0700 (PDT) MIME-Version: 1.0 References: <20191008095604.20675-1-ludovic.Barre@st.com> In-Reply-To: <20191008095604.20675-1-ludovic.Barre@st.com> From: Ulf Hansson Date: Wed, 9 Oct 2019 11:12:14 +0200 Message-ID: Subject: Re: [PATCH V7 0/3] mmc: mmci: add busy detect for stm32 sdmmc variant To: Ludovic Barre Cc: Rob Herring , Srinivas Kandagatla , Maxime Coquelin , Alexandre Torgue , Linux ARM , Linux Kernel Mailing List , DTML , "linux-mmc@vger.kernel.org" , linux-stm32@st-md-mailman.stormreply.com Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 8 Oct 2019 at 11:56, Ludovic Barre wrote: > > From: Ludovic Barre > > This patch series adds busy detect for stm32 sdmmc variant. > Some adaptations are required: > -On sdmmc the data timer is started on data transfert > and busy state, so we must add hardware busy timeout support. > -Add busy_complete callback at mmci_host_ops to allow to define > a specific busy completion by variant. > -Add sdmmc busy_complete callback. > > V7: > -Patch 1/3: rephrasing like proposed (thx ulf) > -If busy timeout is undefined => increase to 10s > -Keep busy_detect. > -Patch 3/3: rephrasing comment header > -Avoid twice read of status register > -Avoid writing in MMCIMASK0 & MMCICLEAR if not modified > Applied for next, thanks! [...] Kind regards Uffe