Received: by 2002:a5b:505:0:0:0:0:0 with SMTP id o5csp697272ybp; Wed, 9 Oct 2019 02:50:00 -0700 (PDT) X-Google-Smtp-Source: APXvYqwwjGF7onZ+apb7ftxaQyZpM7b4j77eauHBStT6TZ9LfOEthcz7RJ/4H69ueO5cnvdIqh2g X-Received: by 2002:a05:6402:514:: with SMTP id m20mr2093028edv.187.1570614600207; Wed, 09 Oct 2019 02:50:00 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1570614600; cv=none; d=google.com; s=arc-20160816; b=hfg5uWwI3QpmUo1UKeISJzN4WQvajBwL0z8VedDCbNgE2RHqpfa6Yhd3uuE14LF3Rf W5Xrf33L4ARde8LO1L+xChkvthA2L7omKGWjEmZDikLxoNncaDsw9CvuIBrSLOjgukQh yCKqXVS96HxlUGvlSpyfdEIwpmtg84kgeBwPKcj7G0XNhuKLxDfQceRH00FQ25gF529W zM8yCzYh2/88vhLiReQQ93DJn2QtrUUd98kenkbQaripQbjap0a33J0OzfIGWxoyAEq0 6GWUBv+N1nvAVMjHLEYcGUs6UyFNcJEIe2YM3qgSzegnvzF0Pt+GpBAH+K66IQfP7YOR 72HQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:date:subject:user-agent:message-id :references:cc:in-reply-to:from:to:content-transfer-encoding :mime-version; bh=KeZIo5Ano8BhorSYhUSdysYB1hWJR/q2SqRkB3ca4NU=; b=fA6YTgnDhdsfiWyq9QF98s3IwhnwjN+GaHVOWTwQ83TKM469OkpSvTXih8u+DZb0nq J1pKni5Y85FK/PpffWrWIghscoONk188BNdMGpAuQUATV/6s0dL190CXQq1CkOgLPWxs Lid4l7vmeTtR0Skg0Gnh4fwGgkTPAXv/PDIz0msWEtKfDMlgGNTQqxltCSlUWySRCQXG PyhvWxtBDdpNcgpxrFxTZXqIrq0GtMPtA5IwMYnMeuLctjgiDAE96W7HoqNcGYfmPx1v ZS7K8gg+9iUYFsBywjEIzZJFTtzCvfe0CulyscdnDrtuSoKYIDn/rl4zlzmrELCE4SHP P7jQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id k6si974485edb.235.2019.10.09.02.49.37; Wed, 09 Oct 2019 02:50:00 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730704AbfJIJtT convert rfc822-to-8bit (ORCPT + 99 others); Wed, 9 Oct 2019 05:49:19 -0400 Received: from mail.fireflyinternet.com ([109.228.58.192]:51645 "EHLO fireflyinternet.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1725935AbfJIJtS (ORCPT ); Wed, 9 Oct 2019 05:49:18 -0400 X-Default-Received-SPF: pass (skip=forwardok (res=PASS)) x-ip-name=78.156.65.138; Received: from localhost (unverified [78.156.65.138]) by fireflyinternet.com (Firefly Internet (M1)) with ESMTP (TLS) id 18774966-1500050 for multiple; Wed, 09 Oct 2019 10:49:12 +0100 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8BIT To: Colin King , Daniel Vetter , David Airlie , Jani Nikula , Joonas Lahtinen , Rodrigo Vivi , dri-devel@lists.freedesktop.org, intel-gfx@lists.freedesktop.org From: Chris Wilson In-Reply-To: <20191009093935.17895-1-colin.king@canonical.com> Cc: kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org References: <20191009093935.17895-1-colin.king@canonical.com> Message-ID: <157061455107.18808.11664822517679571894@skylake-alporthouse-com> User-Agent: alot/0.6 Subject: Re: [PATCH][next] drm/i915: remove redundant variable err Date: Wed, 09 Oct 2019 10:49:11 +0100 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Quoting Colin King (2019-10-09 10:39:35) > From: Colin Ian King > > An earlier commit removed any error assignments to err and we > are now left with a zero assignment to err and a check that is > always false. Clean this up by removing the redundant variable > err and the error check. Oh, we add one again shortly. Might as well wait. -Chris