Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Subject: Re: [PATCH] KVM: x86: fix bugon.cocci warnings
To:     Julia Lawall <julia.lawall@lip6.fr>,
        Sean Christopherson <sean.j.christopherson@intel.com>
Cc:     kbuild-all@01.org, linux-kernel@vger.kernel.org,
        =?UTF-8?B?UmFkaW0gS3LEjW3DocWZ?= <rkrcmar@redhat.com>,
        Vitaly Kuznetsov <vkuznets@redhat.com>,
        Wanpeng Li <wanpengli@tencent.com>,
        Jim Mattson <jmattson@google.com>,
        Joerg Roedel <joro@8bytes.org>,
        Thomas Gleixner <tglx@linutronix.de>,
        Ingo Molnar <mingo@redhat.com>, Borislav Petkov <bp@alien8.de>
References: <alpine.DEB.2.21.1909291841260.3346@hadrien>
From:   Paolo Bonzini <pbonzini@redhat.com>
Openpgp: preference=signencrypt
Message-ID: <0d6e152d-97f4-ddcc-15ad-18b7da60c3ca@redhat.com>
Date:   Wed, 9 Oct 2019 13:07:15 +0200
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101
 Thunderbird/60.8.0
MIME-Version: 1.0
In-Reply-To: <alpine.DEB.2.21.1909291841260.3346@hadrien>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On 29/09/19 18:43, Julia Lawall wrote:
> From: kbuild test robot <lkp@intel.com>
> 
> Use BUG_ON instead of a if condition followed by BUG.
> 
> Generated by: scripts/coccinelle/misc/bugon.cocci
> 
> Fixes: 4b526de50e39 ("KVM: x86: Check kvm_rebooting in kvm_spurious_fault()")
> CC: Sean Christopherson <sean.j.christopherson@intel.com>
> Signed-off-by: kbuild test robot <lkp@intel.com>
> Signed-off-by: Julia Lawall <julia.lawall@lip6.fr>
> ---
> 
> tree:   https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
> head:   02dc96ef6c25f990452c114c59d75c368a1f4c8f
> commit: 4b526de50e39b38cd828396267379183c7c21354 KVM: x86: Check kvm_rebooting in kvm_spurious_fault()
> :::::: branch date: 9 hours ago
> :::::: commit date: 4 days ago
> 
> Please take the patch only if it's a positive warning. Thanks!
> 
>  x86.c |    3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
> 
> --- a/arch/x86/kvm/x86.c
> +++ b/arch/x86/kvm/x86.c
> @@ -360,8 +360,7 @@ EXPORT_SYMBOL_GPL(kvm_set_apic_base);
>  asmlinkage __visible void kvm_spurious_fault(void)
>  {
>  	/* Fault while not rebooting.  We want the trace. */
> -	if (!kvm_rebooting)
> -		BUG();
> +	BUG_ON(!kvm_rebooting);
>  }
>  EXPORT_SYMBOL_GPL(kvm_spurious_fault);
> 

Queued, thanks!

Paolo