Received: by 2002:a5b:505:0:0:0:0:0 with SMTP id o5csp901647ybp; Wed, 9 Oct 2019 06:04:59 -0700 (PDT) X-Google-Smtp-Source: APXvYqzyW/e1D58T+5YhbiMYu7KkS/GkzwSyXAZ/X0oO1njXPv4RMqC9pmgDnDl8bOXy2Zou7Juc X-Received: by 2002:aa7:cd06:: with SMTP id b6mr2990626edw.58.1570626299322; Wed, 09 Oct 2019 06:04:59 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1570626299; cv=none; d=google.com; s=arc-20160816; b=PeEw8bNHqUUto2Nk3aPKYn8VczYhO7XZRAXP4G6La6qVY4dPvxfmlFKhCX4L6z4S/a igeD07rhJ+onTthUmzBycI69btMm1hkwIvCfqFAwgvjVDY7NQeeCBKn+/I6RbjDrGpgF RiQGEaZBdCPW+3uNZlNa1OIsAKsUZvynf8/NOCKfUAEcWB6gldZHCUGYppL73ctfhrQn FswyVtckOKqyOdHYvUH/wm0vKYbgOJH2S4kgvK03wa9gPB2b/VYjR8r/dwwvxxGu9Ofl N8byeB6wSrqkzX+jESAmeBUCvVFX+PwFKQvTCED2Y9tRX0q1AMY50EvTdqEBFc/snjCp XO0w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding :content-language:in-reply-to:mime-version:user-agent:date :message-id:from:references:cc:to:subject; bh=JZUDl+6GDb+wyDB1ucXpSoY62g15rJJ0FlxwTiKmFyk=; b=tsT/P3GURBWIUfH+n+i8SZKNJiY93riroR5ZwfCwovQwFXGwtntWKQepHoU/lwawRB 76tQssPfuBCov6+Sv9NLdLBwDVxLnsnWtyxfe1/4s7rzZ8ViJ2XpEDcHG3heKylDZzmj UyVgnhqKwPr48fDcu+ZaLY7uVzurptbx950cfRqcfZ4fs0IxmnJI4bmVsEHoEtD7pQIG A821Ek35Cfq1Y+Pr9S2wxBzRWgD2FL/+7mkVddTMJHQ1GGGeUUc1PhggFdExXQVCX9Qe n+Pcd3HBidT/PQxasGFd1YSBQWdUYz3R8vc7h19eTz7RZYTp+VwGi69zTgDHIjkE07LY ZYvA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id u3si1100140ejj.47.2019.10.09.06.04.31; Wed, 09 Oct 2019 06:04:59 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731212AbfJINCP (ORCPT + 99 others); Wed, 9 Oct 2019 09:02:15 -0400 Received: from lb3-smtp-cloud7.xs4all.net ([194.109.24.31]:53031 "EHLO lb3-smtp-cloud7.xs4all.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730901AbfJINCP (ORCPT ); Wed, 9 Oct 2019 09:02:15 -0400 Received: from [IPv6:2001:983:e9a7:1:2801:e038:f2c3:e060] ([IPv6:2001:983:e9a7:1:2801:e038:f2c3:e060]) by smtp-cloud7.xs4all.net with ESMTPA id IBbYigmgKjZ8vIBbZiI1pc; Wed, 09 Oct 2019 15:02:13 +0200 Subject: Re: [PATCH] staging: media: Fix alignment to match open parenthesis To: Amol Grover , Steve Longerbeam Cc: Philipp Zabel , Mauro Carvalho Chehab , Shawn Guo , Sascha Hauer , linux-media@vger.kernel.org, devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org References: <20190911165655.GA22041@Debian.gxnx00eri1wudnlrc5f3ppaydc.bx.internal.cloudapp.net> From: Hans Verkuil Message-ID: <27da1d8b-09fc-8d23-5213-f0c352ee615d@xs4all.nl> Date: Wed, 9 Oct 2019 15:02:12 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.9.0 MIME-Version: 1.0 In-Reply-To: <20190911165655.GA22041@Debian.gxnx00eri1wudnlrc5f3ppaydc.bx.internal.cloudapp.net> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-CMAE-Envelope: MS4wfD9xGs8YOYZuV2WnHUMHNDzu/rb3+CIh2AtNp5uss+ux5BI/fVCKdjPT2bWBacECXDWhk3Hf31un/fG+RhxxTg16tusrwCrpOJ0ZB00szu2mhkTClY/7 4f/V7rNk74jiJaH6t5+c8ix9wYWAf6YeUbzUkHV2JnW+cTZPHuPJ3lVFR3i/jv61sKvcaLlKjl/tzm5D9yporFfLKj2nBVr2IrmBak8yeIsFkuhAj9xiCM91 Z+cRkBjrpP8E2WbB4vAqd75vw430EJLKXor3vg9m3ojfPtWHJ/v2eMboHFtgpWQr0tAGn8xY9Q5cFFsmQqiPkqptDi2B3Y/+PRKEJ0p2ZD/8ycjSPdIyfaQe htaGq53QKeHef36+PMxMMCqaowIiuqtRuscWoIXQrw6JYJrNfbXFu6w57kVcLWUJDZG8uPDX8NUJhncy+TLQwnp5XfxTV3uKA1y+PKQb8x9P0yUzbdFnkE9F qUEN4JH7dJojP8BJmCY4Fnfu4lhGPkhATd2J2d9LbzXXqW3iQAA7kw2N2wt7BhA6uavtrk6fXcPkokAZ Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Amol, For future reference: always include the driver name in the subject. I've added "imx: " to the subject for you, so no need to resend, but the driver name is important information. Regards, Hans On 9/11/19 6:56 PM, Amol Grover wrote: > CHECK: Alignment should match open parenthesis > > Signed-off-by: Amol Grover > --- > drivers/staging/media/imx/imx-media-csi.c | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/drivers/staging/media/imx/imx-media-csi.c b/drivers/staging/media/imx/imx-media-csi.c > index 367e39f5b382..773b3d6964cf 100644 > --- a/drivers/staging/media/imx/imx-media-csi.c > +++ b/drivers/staging/media/imx/imx-media-csi.c > @@ -627,8 +627,8 @@ static int csi_idmac_start(struct csi_priv *priv) > } > > priv->nfb4eof_irq = ipu_idmac_channel_irq(priv->ipu, > - priv->idmac_ch, > - IPU_IRQ_NFB4EOF); > + priv->idmac_ch, > + IPU_IRQ_NFB4EOF); > ret = devm_request_irq(priv->dev, priv->nfb4eof_irq, > csi_idmac_nfb4eof_interrupt, 0, > "imx-smfc-nfb4eof", priv); > @@ -1472,7 +1472,7 @@ static void csi_try_fmt(struct csi_priv *priv, > imx_media_enum_mbus_format(&code, 0, > CS_SEL_ANY, false); > *cc = imx_media_find_mbus_format(code, > - CS_SEL_ANY, false); > + CS_SEL_ANY, false); > sdformat->format.code = (*cc)->codes[0]; > } > >