Received: by 2002:a5b:505:0:0:0:0:0 with SMTP id o5csp986972ybp; Wed, 9 Oct 2019 07:17:21 -0700 (PDT) X-Google-Smtp-Source: APXvYqx77hC76aX6nv9jtbbZcd+aNUxui9fwWDHskme0s4s5qlPmO7AbaAMyUKRAUpmmxaDCNFZI X-Received: by 2002:a05:6402:2025:: with SMTP id ay5mr3206664edb.93.1570630641753; Wed, 09 Oct 2019 07:17:21 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1570630641; cv=none; d=google.com; s=arc-20160816; b=YRz6mOzamFEvrZLaWRePZiyg83Tn01wPuqqb7xfng9npDe399n+kIDFXRK5C/48k9t 8TPoJi8P+OSeLbNQ7LnaEIhDzU07Qa6fV8XZJagIRALpsYYWcNrhUqOQGcvBb4Ytnhhc 2ktBi3NaTrRf6+GrMNgdorYKFfhxq9Py7pYo2JA4iUy5M1CsWWSXU57kiBfyQCElc0nL aobJwzD/q0F5yq5/L362hgNG9Rmh2lckdCd+eSIbW1Oqx8BtRlkf+vCY4cAI3hKarrUF ym+eHSZZ9+xFKO8LEXOQ6wHrt07VPWUm7f/bQSuPdimIXtVmHiMclBv+yV/spt2Ua7zq 86nQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:dkim-signature; bh=Qi4PLv81q66n38J6ejNqiEYIPuUUxSxzgGAgibO/MIA=; b=YvzCt1V9Nnt7/DZKLTXVw6UppQtZVeowNiHmDgbadXAQedum76MBfBetpG1pZpbubX p6dW2spEkFrdI7ScAVVRz/6dzBqUIaqiuVpu5xWdUYu4xV6HrNKj19SA1yqOPcqzTdFg PkmwZRaj8+4h1jVCjDMuF1A07bjVNMa12/q2m3W/mduCkV3D9fvIu0tu1GYbfIkKqF9D q6xX4JJxIHQuZsjpxeUZwvy+vB+LDxdB8lntXZbTxLkUIZ/D0piuqIy+tuaWKXa/WHe2 vy3eUHQa2kh6qRm/1/eCr52Nlnjrmu91cw3IjkPt06HPwep5cswsLRoGgzVqoAxfFk8F +V4g== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@sirena.org.uk header.s=20170815-heliosphere header.b=XlsWNpaC; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id b44si1433957ede.451.2019.10.09.07.16.56; Wed, 09 Oct 2019 07:17:21 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=fail header.i=@sirena.org.uk header.s=20170815-heliosphere header.b=XlsWNpaC; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731133AbfJION7 (ORCPT + 99 others); Wed, 9 Oct 2019 10:13:59 -0400 Received: from heliosphere.sirena.org.uk ([172.104.155.198]:38506 "EHLO heliosphere.sirena.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727769AbfJION7 (ORCPT ); Wed, 9 Oct 2019 10:13:59 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sirena.org.uk; s=20170815-heliosphere; h=In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=Qi4PLv81q66n38J6ejNqiEYIPuUUxSxzgGAgibO/MIA=; b=XlsWNpaCBgOAMCQ6aVbxTyaZu NUC3bWBiTBT/J9H5Dmb7d8CXd2lKca+wVhWFcpX8x5VMRty4/pU668SQOq8yY9yKJE/8JJHu1eFT7 eHJXP+euu8K6eDVnbpEsBW7+JgrB5fY3kT69pZ8SIl0Si9vZs/3c1LNawCgDq7W5b9VS4=; Received: from cpc102320-sgyl38-2-0-cust46.18-2.cable.virginm.net ([82.37.168.47] helo=ypsilon.sirena.org.uk) by heliosphere.sirena.org.uk with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1iICiv-0004we-G1; Wed, 09 Oct 2019 14:13:53 +0000 Received: by ypsilon.sirena.org.uk (Postfix, from userid 1000) id B00332741DF9; Wed, 9 Oct 2019 15:13:52 +0100 (BST) Date: Wed, 9 Oct 2019 15:13:52 +0100 From: Mark Brown To: Marek Szyprowski Cc: Dmitry Osipenko , Bartlomiej Zolnierkiewicz , linux-kernel@vger.kernel.org, Liam Girdwood , Lucas Stach , Krzysztof Kozlowski , linux-samsung-soc@vger.kernel.org, Viresh Kumar , Kamil Konieczny Subject: Re: [PATCH] regulator: core: Skip balancing of the enabled regulators in regulator_enable() Message-ID: <20191009141352.GC3929@sirena.co.uk> References: <20191008124736.GJ4382@sirena.co.uk> <86b9b4b5-cca5-9052-7c87-c5679dfffff4@samsung.com> <20191008161535.GN4382@sirena.co.uk> <4ad890b7-705e-94f9-2e61-1f3a60984c91@gmail.com> <20191008171747.GS4382@sirena.co.uk> <439154a4-1502-40af-7086-d4e3eb24025f@gmail.com> <20191008180750.GT4382@sirena.co.uk> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="JgQwtEuHJzHdouWu" Content-Disposition: inline In-Reply-To: X-Cookie: Every path has its puddle. User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --JgQwtEuHJzHdouWu Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Wed, Oct 09, 2019 at 12:29:00PM +0200, Marek Szyprowski wrote: > Okay, then what is the conclusion, as I got lost a bit? How do you want= =20 > this issue to be fixed? We should revert the enable call, it shouldn't be required, and ideally the default balancer could be updated to only make configuration changes if they're actually required which would help avoid triggering any such things in future if we don't absolutely have to. --JgQwtEuHJzHdouWu Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAABCgAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAl2d6wkACgkQJNaLcl1U h9BlRAf/YGiMG169n7MCXyjkc8bcLmLH7+9S3stdFllmTYuhOP/M1y/JQJmzzQwg XDnAA2bX++oSN2E5ywHFEFnnEMStg5lUCHik0tZbf1SJNwS4O1XsuQaLS3tJajgQ ForbctxszdR9Yb+PpwMsjeH1ke5L851Cxd6XjwIVhy8DMqY4vWhrriiojk6ZqniV BLMMwT7B1fMwVqVqeLjOlwc7eZopT7cFim47sO1NfXizcuJ0eX9VthVh0HRnM294 92eCpqwgT1HTNmrkZgmnme9gWgbdB710n/G9w6Ez0/iC8fPp9S5OMyNA92ajbuMs JpMjsKKdeYiEQe2ugez8CeAphm/pFg== =ljBl -----END PGP SIGNATURE----- --JgQwtEuHJzHdouWu--