Received: by 2002:a5b:505:0:0:0:0:0 with SMTP id o5csp1506686ybp; Wed, 9 Oct 2019 15:27:54 -0700 (PDT) X-Google-Smtp-Source: APXvYqwpWZ5iNNAPkQ6N6rtvw/wS7/+1KWIBh+m2Fa8dzcbDihqsrnH7fm1Z8Y1jDcTO65jdxT2H X-Received: by 2002:aa7:dd0f:: with SMTP id i15mr5389693edv.0.1570660074756; Wed, 09 Oct 2019 15:27:54 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1570660074; cv=none; d=google.com; s=arc-20160816; b=mS2yY/ROXSCIH8JxSYcEebEeilIdLTcVox9gWhvCvIjskfK9ccHSOCmDN+cH/zJnyM rDbgKj/ahPHtFFWgXQtmGNW4Tr6o1KTYC3Ldia52hz5GgvzhT6zlV9Z+iGmWIKTUBrGp AL1X2PzAUbPKBoVvyk8MgUY1PE7VBDxA99D4idnxbF9Mrnve9UjvjyxrHYsCzRhSI6LD rzml4axxxwyp4iHHim0TpkmqzO8+2q2pioiif6a3/vxlYzEhvDYrI1pzVCk9hg2i5FQu OZw5qFZGFEO9aBBaL6DrasaHtGCvk4TorEuPDutr9ctis4R5nUtwaNc5H6t9n76ZOd0B oSdw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=AVlA58oBGvamEPKLz6IO6lwmVXYcOBgZNjwHhgkoanY=; b=YqY2WI/ofgI06DzMW2ZQyFkHrqCkQ+I4lFqY8kWD8fSml4wlv+6LEHDKhkOHa3ysO1 ECZtNwXTBDxpkrVh2OUsxgxC5mtyOc1+z8tNPvVD12GpcMgE84aBnkvmqm1BRLVMf+GG H2xa4reW6VZVYPc+nDs+YEMUOD56JMPj3doRMozB94adSxFnt0zHjhtt6nvKmEwjTLG4 ZVrSjtHQQ37ShM5DgPYWhDV0pm/3tsHBd7q/fx5xlMMy3wjS2jHfIfg3+W/s+8Z5jF6P nnz66L2GUltv6xMuQhUm27lC/QycCW2riROTy4QOx07dW+PogddPoL0aYBUMOGCBivl6 MzMA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@synopsys.com header.s=mail header.b=GgP6kaNk; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=synopsys.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id u18si2020010ejk.105.2019.10.09.15.27.31; Wed, 09 Oct 2019 15:27:54 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@synopsys.com header.s=mail header.b=GgP6kaNk; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=synopsys.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1732256AbfJIW1J (ORCPT + 99 others); Wed, 9 Oct 2019 18:27:09 -0400 Received: from smtprelay-out1.synopsys.com ([198.182.61.142]:55048 "EHLO smtprelay-out1.synopsys.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1731916AbfJIW1I (ORCPT ); Wed, 9 Oct 2019 18:27:08 -0400 Received: from mailhost.synopsys.com (dc8-mailhost1.synopsys.com [10.13.135.209]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) (No client certificate requested) by smtprelay-out1.synopsys.com (Postfix) with ESMTPS id 32D33C03EA; Wed, 9 Oct 2019 22:27:06 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=synopsys.com; s=mail; t=1570660027; bh=VhQHSn2scrt/qLb1cp8mUcqKwCHy/B+Kzh4ZumuFBfE=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=GgP6kaNk3OUsXe+9Z6UeDQpLd4pr7C/0F+HHRYYvvgbB5T0xlOdbnFyJCbSVRQBH6 tY0qa8Or/HpDF2v0Vyt0djRcdRkjPKoWYRcV8Yq58z9jgIJjeBmcmHYSQR56aaOmuV 0yDM4ohgjmBXm86vMIVuQ3M8OPao9yPvvOyefPnWg8PsqdsAH1Ncav3x3a5mPfLwVU M7LbqxQq7WTtjw/BAbf58djskxwaJDMalSv2pXnY7/WTrvAPYXNygzhZRaB3UoC5YN Zcpp0Gw23/hIBUudH7a5CSvjNOxJoezUSr1ZS/9iVXtIT/T3yyBS4LwG6NB+OoA6lH LjGChWQGNroPQ== Received: from vineetg-Latitude-E7450.internal.synopsys.com (vineetg-latitude-e7450.internal.synopsys.com [10.10.161.61]) by mailhost.synopsys.com (Postfix) with ESMTP id AA9C8A0072; Wed, 9 Oct 2019 22:27:06 +0000 (UTC) From: Vineet Gupta To: linux-mm@kvack.org Cc: linux-snps-arc@lists.infradead.org, linux-kernel@vger.kernel.org, linux-arch@vger.kernel.org, Arnd Bergmann , Will Deacon , "Aneesh Kumar K . V" , Andrew Morton , Nick Piggin , Peter Zijlstra , "Kirill A . Shutemov" , Vineet Gupta Subject: [PATCH 3/3] asm-generic/mm: stub out p{4,d}d_clear_bad() if __PAGETABLE_P{4,u}D_FOLDED Date: Wed, 9 Oct 2019 15:26:58 -0700 Message-Id: <20191009222658.961-4-vgupta@synopsys.com> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20191009222658.961-1-vgupta@synopsys.com> References: <20191009222658.961-1-vgupta@synopsys.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org This removes the code for 2 level paging as seen on ARC | bloat-o-meter2 vmlinux-D-elide-p4d_free_tlb vmlinux-E-elide-p?d_clear_bad | add/remove: 0/2 grow/shrink: 0/0 up/down: 0/-22 (-22) | function old new delta | pud_clear_bad 20 - -20 | p4d_clear_bad 20 - -20 | Total: Before=4137104, After=4137082, chg -1.000000% Signed-off-by: Vineet Gupta --- include/asm-generic/pgtable.h | 11 +++++++++++ mm/pgtable-generic.c | 4 ++++ 2 files changed, 15 insertions(+) diff --git a/include/asm-generic/pgtable.h b/include/asm-generic/pgtable.h index 818691846c90..9cdcbc7c0b7b 100644 --- a/include/asm-generic/pgtable.h +++ b/include/asm-generic/pgtable.h @@ -558,8 +558,19 @@ static inline pgprot_t pgprot_modify(pgprot_t oldprot, pgprot_t newprot) * Do the tests inline, but report and clear the bad entry in mm/memory.c. */ void pgd_clear_bad(pgd_t *); + +#ifndef __PAGETABLE_P4D_FOLDED void p4d_clear_bad(p4d_t *); +#else +#define p4d_clear_bad(p4d) do { } while (0) +#endif + +#ifndef __PAGETABLE_PUD_FOLDED void pud_clear_bad(pud_t *); +#else +#define pud_clear_bad(p4d) do { } while (0) +#endif + void pmd_clear_bad(pmd_t *); static inline int pgd_none_or_clear_bad(pgd_t *pgd) diff --git a/mm/pgtable-generic.c b/mm/pgtable-generic.c index 532c29276fce..856dc3bb77e6 100644 --- a/mm/pgtable-generic.c +++ b/mm/pgtable-generic.c @@ -24,17 +24,21 @@ void pgd_clear_bad(pgd_t *pgd) pgd_clear(pgd); } +#ifndef __PAGETABLE_P4D_FOLDED void p4d_clear_bad(p4d_t *p4d) { p4d_ERROR(*p4d); p4d_clear(p4d); } +#endif +#ifndef __PAGETABLE_PUD_FOLDED void pud_clear_bad(pud_t *pud) { pud_ERROR(*pud); pud_clear(pud); } +#endif void pmd_clear_bad(pmd_t *pmd) { -- 2.20.1