Received: by 2002:a5b:505:0:0:0:0:0 with SMTP id o5csp1628969ybp; Wed, 9 Oct 2019 17:48:20 -0700 (PDT) X-Google-Smtp-Source: APXvYqwd10vroY13XALYuaz9+1/Sz8wUG0I/T75gYSGysWONuB0Qc3wv79c7J1nKzT9U8BA3YKxx X-Received: by 2002:a17:906:360c:: with SMTP id q12mr5465150ejb.168.1570668500605; Wed, 09 Oct 2019 17:48:20 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1570668500; cv=none; d=google.com; s=arc-20160816; b=S/8/uflFbWpfHRgqN1d8PUcoOEWkS8SbBsGOJu71i0mVCHm8eVksyDgIBS9qKMV5J6 p3WOaWsmi3d+ESDHU46BSepK9Aaqw9I+JT6A74RNLpuGk5M2KkkFl6WQ3VJJ54HfbpCW /XVBoQkMZqEag4Q3/83u5H2BWtr5YSq96crHbbA/n/1FshUWDjipES09kHg6qKpo9gMb wjnMkW4VYzk3CBRxmMPoZQthol6QIZwhNo1g9M8lm4Eq3/6+FGUt+CxHSDeZVTYRR92N 40Xup5BBmGCWaSHOHkb650oqzT3LXMOwEOse6X43wn/+GzD9d962Ubz4rOqaci9Kzj41 QlxA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding :content-language:in-reply-to:mime-version:user-agent:date :message-id:from:references:cc:to:subject:dkim-signature; bh=wUw24dYwtRzDhdQ0o8HSROqGQRo01O5bW3h5i/yV0YA=; b=nAppQ8mkBHaJpGNTI0ZSrOBv8+mE0NcObwfYh3VRTetggwndH5TkDt8FNZcnjnvLX3 bKs2iDnoNrOJk4teRjqPOo+fb2PSM3J1OTP5ZlVR4w19M9S5annl/CsVLXyE2TRt0Eh5 nm0qgEN1rPKPY6DYbQItUGCqnrFiV5V62RV3PYubom1tZoxgD8GdywN0BDiujJxOgt0h jBbmDnMmjd5xEw/yBXEI8c/NZRCUHrDe6jq56ere/hHi0jUVLZ/e/0aWqZ70hmS+Qy8Q yysAMx9x7q5COIfR7CAllo7WZEbOe9NCaOVrHfLLqygOhEw3+/4Lwok+yRMn8RgGgYQY 9kCA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@oracle.com header.s=corp-2019-08-05 header.b=Pcv2RYJi; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=oracle.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id l9si2059790ejx.438.2019.10.09.17.47.57; Wed, 09 Oct 2019 17:48:20 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@oracle.com header.s=corp-2019-08-05 header.b=Pcv2RYJi; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=oracle.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1732516AbfJJArm (ORCPT + 99 others); Wed, 9 Oct 2019 20:47:42 -0400 Received: from aserp2120.oracle.com ([141.146.126.78]:55452 "EHLO aserp2120.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1731166AbfJJArl (ORCPT ); Wed, 9 Oct 2019 20:47:41 -0400 Received: from pps.filterd (aserp2120.oracle.com [127.0.0.1]) by aserp2120.oracle.com (8.16.0.27/8.16.0.27) with SMTP id x9A0iLlM171680; Thu, 10 Oct 2019 00:46:07 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=subject : to : cc : references : from : message-id : date : mime-version : in-reply-to : content-type : content-transfer-encoding; s=corp-2019-08-05; bh=wUw24dYwtRzDhdQ0o8HSROqGQRo01O5bW3h5i/yV0YA=; b=Pcv2RYJi0amWYNl6TCUmkcbjGAM5sjbz7jTIlFs2/MKodKTj2PV631IsY4xMYJFZZnqy k8lk7AzWgZmd8xOf+cemErBCvwQV38bmGlnVeCDdDi7Dp6C+SALF42S7u7ldrgD/CphO 5l6JouFMsSSpBzvrrLwLnmBaEgXQ45o4iuTXXp1FRjvn0AQPdnocmDQ+HnfmTia4qHlk 7hRowDQb9yvSffzX6g3y/PtlVzWEqk7gyupPwz0dj4Z1C5f0j72BxKbmnbdaAWy3SCbC DPSZ7TnSJN9TresoCGKzDXPqtDTEUFd8PSgPWyZa6ABrbI1LEKTCmls87Hlnlvhk4Bbf eA== Received: from aserp3020.oracle.com (aserp3020.oracle.com [141.146.126.70]) by aserp2120.oracle.com with ESMTP id 2vek4qqx6a-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Thu, 10 Oct 2019 00:46:07 +0000 Received: from pps.filterd (aserp3020.oracle.com [127.0.0.1]) by aserp3020.oracle.com (8.16.0.27/8.16.0.27) with SMTP id x9A0cujo051434; Thu, 10 Oct 2019 00:46:07 GMT Received: from userv0121.oracle.com (userv0121.oracle.com [156.151.31.72]) by aserp3020.oracle.com with ESMTP id 2vhhsnm5ee-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Thu, 10 Oct 2019 00:46:07 +0000 Received: from abhmp0007.oracle.com (abhmp0007.oracle.com [141.146.116.13]) by userv0121.oracle.com (8.14.4/8.13.8) with ESMTP id x9A0jxYL026366; Thu, 10 Oct 2019 00:45:59 GMT Received: from [192.168.1.222] (/71.63.128.209) by default (Oracle Beehive Gateway v4.0) with ESMTP ; Wed, 09 Oct 2019 17:45:59 -0700 Subject: Re: [PATCH -next] userfaultfd: remove set but not used variable 'h' To: YueHaibing , Andrea Arcangeli , "Joel Fernandes (Google)" , Andrew Morton , Stephen Rothwell , Wei Yang , Hugh Dickins Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org References: <20191009122740.70517-1-yuehaibing@huawei.com> From: Mike Kravetz Message-ID: Date: Wed, 9 Oct 2019 17:45:57 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.1.0 MIME-Version: 1.0 In-Reply-To: <20191009122740.70517-1-yuehaibing@huawei.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-Proofpoint-Virus-Version: vendor=nai engine=6000 definitions=9405 signatures=668684 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 suspectscore=0 malwarescore=0 phishscore=0 bulkscore=0 spamscore=0 mlxscore=0 mlxlogscore=999 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1908290000 definitions=main-1910100003 X-Proofpoint-Virus-Version: vendor=nai engine=6000 definitions=9405 signatures=668684 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 priorityscore=1501 malwarescore=0 suspectscore=0 phishscore=0 bulkscore=0 spamscore=0 clxscore=1011 lowpriorityscore=0 mlxscore=0 impostorscore=0 mlxlogscore=999 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1908290000 definitions=main-1910100004 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 10/9/19 5:27 AM, YueHaibing wrote: > Fixes gcc '-Wunused-but-set-variable' warning: > > mm/userfaultfd.c: In function '__mcopy_atomic_hugetlb': > mm/userfaultfd.c:217:17: warning: > variable 'h' set but not used [-Wunused-but-set-variable] > > It is not used since commit 78911d0e18ac ("userfaultfd: use vma_pagesize > for all huge page size calculation") > Thanks! That should have been removed with the recent cleanups. > Signed-off-by: YueHaibing Reviewed-by: Mike Kravetz -- Mike Kravetz