Received: by 2002:a5b:505:0:0:0:0:0 with SMTP id o5csp1742325ybp; Wed, 9 Oct 2019 19:46:53 -0700 (PDT) X-Google-Smtp-Source: APXvYqwJBkRQFzLIyYoTKbNZewxYzu9mbkEoZHPQSU3wiWwsU9N0J1c+pD9AVQmVvCuSpFk+P8EU X-Received: by 2002:a17:906:2cd2:: with SMTP id r18mr5881094ejr.282.1570675613726; Wed, 09 Oct 2019 19:46:53 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1570675613; cv=none; d=google.com; s=arc-20160816; b=DE7mKYi73HzBIS7/P8jmrqZyNE4oC01Gv3UDZWGXNYEiPEzHUHdixjEKeltM1f1aVe FZawHGqLgd/3IsJIykB0vqqHZm+CbIbcBLgv/X1ekPfMUJAo7Xx0oatKyqYZNrDFS4V5 aYP8mHSRYrEyS95uU63psP/wL7CE+3+wzuVqR02tcGG2Ce1manfSYa9ZWg14RTl/BrPe 97zOc8sexBNxjhXM+LCjPgiJmc/ulI+J4HHIBpwEreGCkHXk1KTf7GkuMX87zfp3/pED S3vQUnzyB7pSpzc7YQEekgePmAa0bAiMia+ohN5Hu6xn6EwkafbP+C+IHnHXWTt7dQQt 46cw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :organization:references:in-reply-to:message-id:subject:cc:to:from :date:dkim-signature; bh=QWteHAhBVt9oVGOsOtKHsCiYKtX8kIzt6852sk1FamE=; b=ZfuA73NHUhxgvNQik0v/WtDLpT3rmk/CYjOD6Vvr+SwztoC7cS3NsJxm1Xg+JKlH/f ziyMQgOOv4jYVsN9HhPOuatFrq++9YKinEwe6dzO5CeTYBN7VdxRD12uFUOk+TpfPD+f 7LUlS3KJU86GvqkapIjhI2N/If4X6/tj1e5Hdh8PBqAMaqeogTcVNcQFntVD0/7uRHlj qiNy6wqf63ibg3FKvtGPbQUIlOQQBDNlHSWrHHx5JlB1XZIN10tZmXRGoEKtZSkpRSWd +KwUfpkNsPTbSIYlpUwE/P59vjURmCA6cadt+c+1UwMCxsvUT+iDz43trZF7r/6pQQ8O 9iuA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@netronome-com.20150623.gappssmtp.com header.s=20150623 header.b=iei9S1oj; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id x30si2667746edi.351.2019.10.09.19.46.30; Wed, 09 Oct 2019 19:46:53 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@netronome-com.20150623.gappssmtp.com header.s=20150623 header.b=iei9S1oj; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726197AbfJJCn0 (ORCPT + 99 others); Wed, 9 Oct 2019 22:43:26 -0400 Received: from mail-pf1-f196.google.com ([209.85.210.196]:40227 "EHLO mail-pf1-f196.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1732447AbfJJCnZ (ORCPT ); Wed, 9 Oct 2019 22:43:25 -0400 Received: by mail-pf1-f196.google.com with SMTP id x127so2896888pfb.7 for ; Wed, 09 Oct 2019 19:43:25 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=netronome-com.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:in-reply-to:references :organization:mime-version:content-transfer-encoding; bh=QWteHAhBVt9oVGOsOtKHsCiYKtX8kIzt6852sk1FamE=; b=iei9S1oj45k0ZQgMqH7H0heioINFqEVoK5QQNnLJC6ig340LF/7lvfzuHdeKQlFK9x 6Hkzh1+TJ0ShL8YMEXjqTIzqQykuK+7tNtk94vJ4PDCbixkpd/CwsT+tJo73VoTzALs/ 3YWHZQoNIZeLzmRb9W51aeEcULryqpcGxo8kCATCoMkcLHktP/FKv3Ju9PHc7WdcrGqO qhS24uqCCsyYuoV3mYvlcqYnea4e3PZbAMiwtrKuLXasFUvy0aiVsLwKeg0yUmpUQano OxYzAZwBbkwSmqpihYxzEX7I6XbxUNWZtxCAn7mGV3WyXxBTngz3tgAri5pGzUmpS68u GvEw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to :references:organization:mime-version:content-transfer-encoding; bh=QWteHAhBVt9oVGOsOtKHsCiYKtX8kIzt6852sk1FamE=; b=WANW40sd3R4yBZzgy5yxc+htll/pQOPUzGvly57Pyd8ueECxjiy0O5cmbeQVvo12Mg 2yRZJgAOIsvO1J4avNSqVWKfQpEyoJdfZyRz533Y8aEnW47/F6Ri6XsP4h8vHQuqEYhq 20Cj5U+5ADLccLRSebNpfdYPkdpVAXcd0otl3W2jFxdVdY3mtlKvuLXTVH6v2vRoNVsS 03itxRfeCe80T+ArTDNE12V995LvzACVdh91hmC8BGFpBfoMA421cNbT6wU57StW58Mj t+O31GcDQpJeoqohU1HIa6pedObibI3xrxjXeeeQxYfq7ltMfqk7MkkSsFq1fmusYpTi sTeA== X-Gm-Message-State: APjAAAUW79Ef7jTQaF2F+NhFIqeHZd2K902qULwse91GDmpddrwtfZrm aqLV7h3LMTLLSSSzlgpm/85DXw== X-Received: by 2002:aa7:9e8d:: with SMTP id p13mr7146028pfq.171.1570675405027; Wed, 09 Oct 2019 19:43:25 -0700 (PDT) Received: from cakuba.netronome.com (c-73-202-202-92.hsd1.ca.comcast.net. [73.202.202.92]) by smtp.gmail.com with ESMTPSA id a16sm4961578pfa.53.2019.10.09.19.43.24 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 09 Oct 2019 19:43:24 -0700 (PDT) Date: Wed, 9 Oct 2019 19:43:11 -0700 From: Jakub Kicinski To: Biao Huang Cc: , Jose Abreu , , Giuseppe Cavallaro , Alexandre Torgue , Maxime Coquelin , Matthias Brugger , , , , , , , , Subject: Re: [RESEND,PATCH] net: stmmac: dwmac-mediatek: fix wrong delay value issue when resume back Message-ID: <20191009194311.55c8cf6e@cakuba.netronome.com> In-Reply-To: <20191009073348.5503-1-biao.huang@mediatek.com> References: <20191009073348.5503-1-biao.huang@mediatek.com> Organization: Netronome Systems, Ltd. MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 9 Oct 2019 15:33:48 +0800, Biao Huang wrote: > mac_delay value will be divided by 550/170 in mt2712_delay_ps2stage(), > which is invoked at the beginning of mt2712_set_delay(), and the value > should be restored at the end of mt2712_set_delay(). > Or, mac_delay will be divided again when invoking mt2712_set_delay() > when resume back. > So, add mt2712_delay_stage2ps() to mt2712_set_delay() to recovery the > original mac_delay value. > > Signed-off-by: Biao Huang Applied, thanks.