Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
From:   Xin Ji <xji@analogixsemi.com>
To:     Laurent Pinchart <laurent.pinchart@ideasonboard.com>
CC:     "devel@driverdev.osuosl.org" <devel@driverdev.osuosl.org>,
        Dan Carpenter <dan.carpenter@oracle.com>,
        Andrzej Hajda <a.hajda@samsung.com>,
        Neil Armstrong <narmstrong@baylibre.com>,
        Jonas Karlman <jonas@kwiboo.se>,
        Jernej Skrabec <jernej.skrabec@siol.net>,
        David Airlie <airlied@linux.ie>,
        Daniel Vetter <daniel@ffwll.ch>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "dri-devel@lists.freedesktop.org" <dri-devel@lists.freedesktop.org>,
        Sheng Pan <span@analogixsemi.com>
Subject: Re: [PATCH v2 1/2] dt-bindings: drm/bridge: anx7625: MIPI to DP
 transmitter binding
Thread-Topic: [PATCH v2 1/2] dt-bindings: drm/bridge: anx7625: MIPI to DP
 transmitter binding
Thread-Index: AQHVfoO4ZRVMsEYORESrPx4IOG5NEadSN+6AgAEDXgA=
Date:   Thu, 10 Oct 2019 03:38:40 +0000
Message-ID: <20191010033822.GB10005@xin-VirtualBox>
References: <cover.1570588741.git.xji@analogixsemi.com>
 <82d9e3d505699da8f32069844b3cfe7c9fbfd0f1.1570588741.git.xji@analogixsemi.com>
 <20191009121003.GM22998@pendragon.ideasonboard.com>
In-Reply-To: <20191009121003.GM22998@pendragon.ideasonboard.com>
Accept-Language: zh-CN, en-US
Content-Language: en-US
x-ms-exchange-messagesentrepresentingtype: 1
x-originating-ip: [114.247.245.252]
x-ms-publictraffictype: Email
x-ms-office365-filtering-correlation-id: e19dadbc-6f2e-4284-d440-08d74d335643
x-ms-traffictypediagnostic: SN6PR04MB4013:
x-ms-exchange-purlcount: 2
x-ms-exchange-transport-forked: True
x-microsoft-antispam-prvs: <SN6PR04MB4013E36999DEBFC22C4E2FB6C7940@SN6PR04MB4013.namprd04.prod.outlook.com>
x-ms-oob-tlc-oobclassifiers: OLM:5516;
x-forefront-prvs: 018632C080
x-forefront-antispam-report: SFV:NSPM;SFS:(10019020)(7916004)(136003)(396003)(39850400004)(376002)(346002)(366004)(199004)(189003)(81166006)(386003)(6116002)(3846002)(7736002)(186003)(64756008)(86362001)(316002)(66476007)(66946007)(7416002)(26005)(8936002)(66446008)(66556008)(4326008)(102836004)(6506007)(8676002)(6916009)(99286004)(81156014)(476003)(11346002)(446003)(486006)(305945005)(52116002)(76176011)(107886003)(229853002)(6306002)(6512007)(9686003)(54906003)(6246003)(256004)(71190400001)(14454004)(33716001)(33656002)(6486002)(2906002)(6436002)(478600001)(66066001)(5660300002)(25786009)(1076003)(71200400001);DIR:OUT;SFP:1102;SCL:1;SRVR:SN6PR04MB4013;H:SN6PR04MB4543.namprd04.prod.outlook.com;FPR:;SPF:None;LANG:en;PTR:InfoNoRecords;A:1;MX:1;
received-spf: None (protection.outlook.com: analogixsemi.com does not
 designate permitted sender hosts)
x-ms-exchange-senderadcheck: 1
x-microsoft-antispam: BCL:0;
x-microsoft-antispam-message-info: Wi8fnq0cTwS8Stbe9WsLD0hRNevJ74A3sG2XqPmMG6D8ChYmBhkJ3RKACoUzRBom/LO3ePHkDRJcuwThqeckhJBheSPtPyYT3RxsfqfjZ75bBdQ1+/T3atqaJIxMmHf00Ihi9b4AYBtD/72UvWbh+cN4wmTcQecnNjoMUZTlk5wmK1c9z0mnrDY75Kd4KltHJitO6TvYkEiPy+IL2lBDmfdT9el7XYaVl7aNC27Rdsz1UKXLeI6JVCKilXIuZSdJL+Gewb792NcFkHZ5KqDXMyWr6mfPXpMhd1oKpITFoP0xn4ud32UZ2A/asD1WggV7FmlpCU9SMQubvoidl1fsJ4Aih4meR4OVpDdBFnZwuYQ6KqyZjynn6dFIp3IvuTyTKaPYjo/GmMufU0ctGULM3dmrdveVdmoq4Pq1Ak/MXGGXY1wKqn67JrdP3qSyoDvmoN7onKQutmvSu5YXoK1U8g==
Content-Type: text/plain; charset="us-ascii"
Content-ID: <277EF7BA861E9D4F924E8A7EF332BAE0@namprd04.prod.outlook.com>
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-OriginatorOrg: analogixsemi.com
X-MS-Exchange-CrossTenant-Network-Message-Id: e19dadbc-6f2e-4284-d440-08d74d335643
X-MS-Exchange-CrossTenant-originalarrivaltime: 10 Oct 2019 03:38:40.7186
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: b099b0b4-f26c-4cf5-9a0f-d5be9acab205
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: z96CJP5CSINPu43Cb1Y4YphPuuAagBpvpKgGqIs78Df8oJe/3f54iKkk8lnUdSDLEJVBITgo+VvzvSKUuicrbw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN6PR04MB4013
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Hi Laurent Pinchart, thanks for your comments.


On Wed, Oct 09, 2019 at 03:10:03PM +0300, Laurent Pinchart wrote:
> Hi Xin Ji,
>=20
> Thank you for the patch.
>=20
> On Wed, Oct 09, 2019 at 09:27:07AM +0000, Xin Ji wrote:
> > The ANX7625 is an ultra-low power 4K Mobile HD Transmitter designed
> > for portable device. It converts MIPI to DisplayPort 1.3 4K.
> >=20
> > You can add support to your board with binding.
> >=20
> > Example:
> > 	anx_bridge: anx7625@58 {
> > 		compatible =3D "analogix,anx7625";
> > 		reg =3D <0x58>;
> > 		enable-gpios =3D <&gpio0 45 GPIO_ACTIVE_LOW>;
> > 		reset-gpios =3D <&gpio0 73 GPIO_ACTIVE_LOW>;
> > 		status =3D "okay";
> > 		port@0 {
> > 			reg =3D <0>;
> > 			anx7625_1_in: endpoint {
> > 				remote-endpoint =3D <&mipi_dsi_bridge_1>;
> > 			};
> > 		};
> > 	};
> >=20
> > Signed-off-by: Xin Ji <xji@analogixsemi.com>
> > ---
> >  .../bindings/display/bridge/anx7625.yaml           | 79 ++++++++++++++=
++++++++
> >  1 file changed, 79 insertions(+)
> >  create mode 100644 Documentation/devicetree/bindings/display/bridge/an=
x7625.yaml
> >=20
> > diff --git a/Documentation/devicetree/bindings/display/bridge/anx7625.y=
aml b/Documentation/devicetree/bindings/display/bridge/anx7625.yaml
> > new file mode 100644
> > index 0000000..0ef6271
> > --- /dev/null
> > +++ b/Documentation/devicetree/bindings/display/bridge/anx7625.yaml
> > @@ -0,0 +1,79 @@
> > +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause)
> > +# Copyright 2019 Analogix Semiconductor, Inc.
> > +%YAML 1.2
> > +---
> > +$id: "http://devicetree.org/schemas/display/bridge/anx7625.yaml#"
> > +$schema: "http://devicetree.org/meta-schemas/core.yaml#"
> > +
> > +title: Analogix ANX7625 SlimPort (4K Mobile HD Transmitter)
> > +
> > +maintainers:
> > +  - Xin Ji <xji@analogixsemi.com>
> > +
> > +description: |
> > +  The ANX7625 is an ultra-low power 4K Mobile HD Transmitter
> > +  designed for portable devices.
> > +
> > +properties:
> > +  compatible:
> > +    items:
> > +      - const: analogix,anx7625
> > +
> > +  reg:
> > +    maxItems: 1
> > +
> > +  hpd-gpios:
> > +    description: used for HPD interrupt
> > +    maxItems: 1
>=20
> You explained in your reply to v1 review that this describes the
> interrupt generated by the ANX7625. It should be replaced by an
> interrupts property.
OK, I'll change it to interrupts property.
>=20
> > +
> > +  enable-gpios:
> > +    description: used for power on chip control
> > +    maxItems: 1
> > +
> > +  reset-gpios:
> > +    description: used for reset chip control
> > +    maxItems: 1
>=20
> Could you please mention the exact name of the corresponding pins on the
> chip for enable and reset ?
OK, I'll mention the exact name of the corresponding pins on the chip.
>=20
> > +
> > +  port@0:
> > +    type: object
> > +    description:
> > +      A port node pointing to MIPI DSI host port node.
> > +
> > +  port@1:
> > +    type: object
> > +    description:
> > +      A port node pointing to MIPI DPI host port node.
> > +
> > +  port@2:
> > +    type: object
> > +    description:
> > +      A port node pointing to external connector port node.
> > +
> > +  port@3:
> > +    type: object
> > +    description:
> > +      A port node pointing to internal panel port node.
> > +
> > +  port@4:
> > +    type: object
> > +    description:
> > +      A port node pointing to normal eDP port node.
>=20
> I don't think three output ports is correct. Ports 3 and 4 are really
> the same. I'm even unsure about port 2 and 3, someone with better
> knowledge of USB-C and DisplayPort would be in a better position to
> comment.
I used it to distinguish different output, port@2 used for USB Type-C
output, I need it to register external connector port notifier
interface, and I think it is OK to conbine port@3 and port@4.
>=20
> > +
>=20
> You're missing the #address-cells and #size-cells properties required
> for the ports. As the device is an I2C device we're lucky that the
> parent will specify compatible address and size cells numbers, but I'm
> not sure we should rely on that luck.
OK, I'll add it.
>=20
> Rob, how does yaml schema handle this ?
>=20
> > +required:
> > +  - compatible
> > +  - reg
> > +  - port@0 | port@1
> > +
> > +example:
> > +  - |
> > +    anx_bridge: anx7625@58 {
>=20
> The node name should describe the device's function. How about
> encoder@58 ?
OK, I'll change it.
>=20
> > +        compatible =3D "analogix,anx7625";
> > +        reg =3D <0x58>;
> > +        status =3D "okay";
> > +        port@0 {
> > +          reg =3D <0>;
> > +          anx7625_1_in: endpoint {
> > +            remote-endpoint =3D <&mipi_dsi_bridge_1>;
> > +          };
> > +        };
> > +    };
>=20
> --=20
> Regards,
>=20
> Laurent Pinchart