Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
IronPort-SDR: sH0t18O0OqK10eP2OGIbFWNf0uyPEXgQ19U+6Fzb7utDKEhm4+7Oiv/lCJhWX3PkHzDjcwV12s
 jfLywTkLu05qsf1uNSuA3hthTxrzHwrELxFrCRQ1oFyhZU+tCaZZmSQk2r4+68fsP9mJy3wBUG
 geHwnVVBw20ns+hHdXQ+lqlEMHeQjo8VN3W0byQoHnXWhL0EzcMJzmbO+EUGxsWLnwnu2QpHov
 g0dIGWNBVMFWEgQduaFLhwafHMAyTso8BHjXi7FDND65dh6VOzwC4Poe7khvEO29jOjOCIDZyy
 R24=
IronPort-PHdr: =?us-ascii?q?9a23=3AWW/WFRBA94xYO51nJO2LUyQJP3N1i/DPJgcQr6?=
 =?us-ascii?q?AfoPdwSPT6rsbcNUDSrc9gkEXOFd2Cra4d0KyI6euwByQp2tWoiDg6aptCVh?=
 =?us-ascii?q?sI2409vjcLJ4q7M3D9N+PgdCcgHc5PBxdP9nC/NlVJSo6lPwWB6nK94iQPFR?=
 =?us-ascii?q?rhKAF7Ovr6GpLIj8Swyuu+54Dfbx9HiTagb75+NhS7oRveusQVgIZpN7o8xA?=
 =?us-ascii?q?bOrnZUYepd2HlmJUiUnxby58ew+IBs/iFNsP8/9MBOTLv3cb0gQbNXEDopPW?=
 =?us-ascii?q?Y15Nb2tRbYVguA+mEcUmQNnRVWBQXO8Qz3UY3wsiv+sep9xTWaMMjrRr06RT?=
 =?us-ascii?q?iu86FmQwLzhSwZKzA27n3Yis1ojKJavh2hoQB/w5XJa42RLfZyY7/Rcc8fSW?=
 =?us-ascii?q?dHW8ZRVjdBApi9b4sJAOoKIPhWoZDgrFsArBuxGw2sC/7ywTNMiHL6wag23u?=
 =?us-ascii?q?ImHgza0gEsA88CvG3IoNnoKaweVf25wanNwTjFcvhY2yry6JLQfx4hv/+CQL?=
 =?us-ascii?q?x+f8nWx0Q0Cw/Jkk+dpZD/Mj+JyugAtXWQ4ep6VeKojm4qswN+ojmux8csl4?=
 =?us-ascii?q?nJgZ8ex1fE9CR4wIY6P9y4RFJnbdOqC5ZQqj2VN5FsTsw8Xm5opT83x7sbsp?=
 =?us-ascii?q?C4ZCgH0IorywLbZvCdcIWF4gjvWPiMLTp3nn5pZbayihWq/US9y+DxUtO43E?=
 =?us-ascii?q?hEoydFiNXAqHEA2wbR58WITPZ2412v1iyV1w/J7+FJOUU0la3GJJE/2rMwjZ?=
 =?us-ascii?q?8TsVjbHi/xhUX2kLeadkU69eis7OTqerDmqYWdN49wkw3+KqAultGmDeQ2Lw?=
 =?us-ascii?q?QDW2uW9f6z1L3k+k35T7FKgeMsnqbFt5DaINwXpq+/AwBLzoYu8wizAyui3d?=
 =?us-ascii?q?gCnnQKLEhJdAyag4XmIV3CPfT1APSnj1SpijhrxvTGPrP7ApXKK3jOiLfgfL?=
 =?us-ascii?q?d960FGyQo/0cxT6pxPB7EcPP3zQFX9u8LFAR8kKwC02froCM1h1oMCXmKCGq?=
 =?us-ascii?q?uZMKLUsV+V6eMjOuqMa5EPuDb7Nfcl4+XjjWE2mVADZ6mlx5gXZ26iHvRgPU?=
 =?us-ascii?q?qZZWDggtAbEWcF7UIQVuvv3WyDQz5OYD7mTrA87zBjUNmOEIzZAI2hnerSj2?=
 =?us-ascii?q?+AApRKazUeWRi3GnDyetDBBqoB?=
From:   Yizhuo <yzhai003@ucr.edu>
Cc:     Yizhuo <yzhai003@ucr.edu>,
        Sudip Mukherjee <sudipm.mukherjee@gmail.com>,
        Teddy Wang <teddy.wang@siliconmotion.com>,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        linux-fbdev@vger.kernel.org, devel@driverdev.osuosl.org,
        linux-kernel@vger.kernel.org
Subject: [PATCH] staging: sm750fb: Potential uninitialized field in "pll"
Date:   Wed,  9 Oct 2019 21:38:08 -0700
Message-Id: <20191010043809.27594-1-yzhai003@ucr.edu>
To:     unlisted-recipients:; (no To-header on input)
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

Inside function set_chip_clock(), struct pll is supposed to be
initialized in sm750_calc_pll_value(), if condition
"diff < mini_diff" in sm750_calc_pll_value() cannot be fulfilled,
then some field of pll will not be initialized but used in
function sm750_format_pll_reg(), which is potentially unsafe.

Signed-off-by: Yizhuo <yzhai003@ucr.edu>
---
 drivers/staging/sm750fb/ddk750_chip.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/staging/sm750fb/ddk750_chip.c b/drivers/staging/sm750fb/ddk750_chip.c
index 5a317cc98a4b..31b3cf9c2d8b 100644
--- a/drivers/staging/sm750fb/ddk750_chip.c
+++ b/drivers/staging/sm750fb/ddk750_chip.c
@@ -55,7 +55,7 @@ static unsigned int get_mxclk_freq(void)
  */
 static void set_chip_clock(unsigned int frequency)
 {
-	struct pll_value pll;
+	struct pll_value pll = {};
 	unsigned int actual_mx_clk;
 
 	/* Cheok_0509: For SM750LE, the chip clock is fixed. Nothing to set. */
-- 
2.17.1