Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
IronPort-SDR: tvyOjakpVFiZiDacPjztNdydUk+608RGytbBi0LM88Xg5GN0rWzJtn4mg6FgfC3JzdcnUu/GUW
 J4M9WG4K3RjoOlyenuAdkn+ZpJgodec398GJOjgPQw76SkfoAMdCdW4+Om0L94N672llMufS1p
 mbIWj7MBHVRuROSMmaoac4tvpihePs5MpCAdPHdmkvwZsbpOaJcKsA2Jvv3C8Q2/Q5+jGIJeJm
 hnfDTC9ewogTx5yXXJtwYj2rpXVd6vllhgkDTVXNQTe1JCHOwsIZ5+obfgStEEOAqc8b28ke17
 aW0=
IronPort-PHdr: =?us-ascii?q?9a23=3AOa0FmxH3JfDpAXjSt0LflZ1GYnF86YWxBRYc79?=
 =?us-ascii?q?8ds5kLTJ76psmzbnLW6fgltlLVR4KTs6sC17ON9f66Ej1Zqb+681k6OKRWUB?=
 =?us-ascii?q?EEjchE1ycBO+WiTXPBEfjxciYhF95DXlI2t1uyMExSBdqsLwaK+i764jEdAA?=
 =?us-ascii?q?jwOhRoLerpBIHSk9631+ev8JHPfglEnjWwba58IRmsrAjdqMYajI9/Jq0s1h?=
 =?us-ascii?q?bHv3xEdvhMy2h1P1yThRH85smx/J5n7Stdvu8q+tBDX6vnYak2VKRUAzs6PW?=
 =?us-ascii?q?874s3rrgTDQhCU5nQASGUWkwFHDBbD4RrnQ5r+qCr6tu562CmHIc37SK0/VD?=
 =?us-ascii?q?q+46t3ThLjlTwKPCAl/m7JlsNwjbpboBO/qBx5347Ue5yeOP5ncq/AYd8WWW?=
 =?us-ascii?q?9NU8BMXCJDH4y8dZMCAOUBM+hWrIfzukUAogelCAmwGO/i0CNEimPq0aA41e?=
 =?us-ascii?q?kqDAHI3BYnH9ILqHnbrtT1NaYSUeCoy6nD0DbMb/NM1jf89YPFdRAgoPCMXb?=
 =?us-ascii?q?1qcMrd1VUjGg3eg1WNtYPlJSmZ2foQvGiG9udtU/+khW0/qwxpvDSj2sMhhp?=
 =?us-ascii?q?PKi48V0FzI6CR0zYQvKdC6VEJ2Z8OvHoFKuCGALYR2R9svQ2RvuCkn1LILoY?=
 =?us-ascii?q?W7fC0WyJQ/wB7fduCHf5CI4h39UOaRJi91hHd/d7K+gxa+6EygyuPhWsWt3l?=
 =?us-ascii?q?ZHrDZJnsPDtnAK0BzT5cyHReVn8ki93jaP0hjf6uBCIU8qiarWM4AtzqI0m5?=
 =?us-ascii?q?YJsknOHjX6lFj3gaKUbEkp+PSk5/ziYrr8p5+cM4F0ihv5MqQrgsG+AeU5Mg?=
 =?us-ascii?q?gUUGia5eiwyLPu8FbkQLpWlP06iLfWv43HJcgDvK62HxdV0po/6xa4Fzqm1N?=
 =?us-ascii?q?UYnX8aLFNKYR6HjJbmO0vIIP/mCfeymEqskDh1yPDcJLHhAYvCLmLFkLj/eb?=
 =?us-ascii?q?Zx8UlcyBA8zYMX25UBKLYBKfT1V1S5ntHCAVdtMQu0yuDhBc473I4EVkqOBL?=
 =?us-ascii?q?OUNOXZtlreoqoCJuyFYpIYvH7SMeUg7ffljTdtlFoYdK+00J9RZ2qlG/5vKE?=
 =?us-ascii?q?WxYHzwj9NHGmAP6E52aPHhgRWpVjNXZ3H6C6Yh7TAyDoXgBoDOQoCqqL2HwC?=
 =?us-ascii?q?q/WJZRYzYCQnGKDXrsP6GFXeocIB2TOMJlnycfHeylSok8xQ6vug7Syrx7I+?=
 =?us-ascii?q?6S8Sod49ar99Fx4+Cbqxg28nQgDNqU12alRGZ4k2oVXTgs1eZ4u0Mrjh/J/a?=
 =?us-ascii?q?FmgvAQLpobwvJNVgogf9aIw+VkBtXaVgvfc9KNT1i6BNOrHWd1BvsvwtAHYk?=
 =?us-ascii?q?I1NM+jiAvf0iusS+scib2EDZ0wtK3G3n7qO8t8zV7H0rUsix8tRc4ZcSWGj6?=
 =?us-ascii?q?96vyTJCp/Hjl6C3/KqfKUZmiLX+XaN0HGVlEBeTAN0F67CWCZbLk/Xq8npo1?=
 =?us-ascii?q?zDVbKqBK88GhVOxNTEKaZQbNDty1JcS7OrPtnCb2+vs3m/CAzOxb6WaofuPW?=
 =?us-ascii?q?IH02GVDEkCjhBW/nucMwU6LjmurniYDzF0E1/rJUT2/rpQsnS+G3413QGXaA?=
 =?us-ascii?q?VT17O0skoEl/yVSqtLhZoZsz1npjlpSgXul+nKAsaN8lIyNJ5XZskwtRIejT?=
 =?us-ascii?q?rU?=
MIME-Version: 1.0
From:   Yizhuo Zhai <yzhai003@ucr.edu>
Date:   Wed, 9 Oct 2019 22:02:43 -0700
Message-ID: <CABvMjLThWpQYir0soRDE3W4S6q0S28RTxen8Y-2YAxbRczMCiA@mail.gmail.com>
Subject: Potential NULL pointer deference in iwlwifi: mvm
To:     Johannes Berg <johannes.berg@intel.com>,
        Emmanuel Grumbach <emmanuel.grumbach@intel.com>,
        Luca Coelho <luciano.coelho@intel.com>,
        Intel Linux Wireless <linuxwifi@intel.com>,
        Kalle Valo <kvalo@codeaurora.org>,
        "David S. Miller" <davem@davemloft.net>,
        Avigail Grinstein <avigail.grinstein@intel.com>,
        Haim Dreyfuss <haim.dreyfuss@intel.com>,
        linux-wireless@vger.kernel.org, netdev@vger.kernel.org,
        linux-kernel@vger.kernel.org
Content-Type: text/plain; charset="UTF-8"
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

Hi All:

drivers/net/wireless/intel/iwlwifi/mvm/power.c:

The function iwl_mvm_vif_from_mac80211() could return NULL,
but some callers in this file does not check the return value while
directly dereference it, which seems potentially unsafe.
Such callers include iwl_mvm_update_d0i3_power_mode(),
iwl_mvm_power_configure_uapsd(),
iwl_mvm_power_allow_uapsd(), etc.


-- 
Kind Regards,

Yizhuo Zhai

Computer Science, Graduate Student
University of California, Riverside