Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
From:   Andy Duan <fugang.duan@nxp.com>
To:     Anson Huang <anson.huang@nxp.com>,
        "davem@davemloft.net" <davem@davemloft.net>,
        "gregkh@linuxfoundation.org" <gregkh@linuxfoundation.org>,
        "andy.shevchenko@gmail.com" <andy.shevchenko@gmail.com>,
        "rafael.j.wysocki@intel.com" <rafael.j.wysocki@intel.com>,
        "swboyd@chromium.org" <swboyd@chromium.org>,
        "netdev@vger.kernel.org" <netdev@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
CC:     dl-linux-imx <linux-imx@nxp.com>
Subject: RE: [PATCH 2/2] net: fec_ptp: Use platform_get_irq_xxx_optional() to
 avoid error message
Thread-Topic: [PATCH 2/2] net: fec_ptp: Use platform_get_irq_xxx_optional() to
 avoid error message
Thread-Index: AQHVforamvMhoeXRzUmo7L8WJtBhgadTcjyA
Date:   Thu, 10 Oct 2019 06:55:32 +0000
Message-ID: <VI1PR0402MB3600BABFA79F76C65FA511ADFF940@VI1PR0402MB3600.eurprd04.prod.outlook.com>
References: <1570616148-11571-1-git-send-email-Anson.Huang@nxp.com>
 <1570616148-11571-2-git-send-email-Anson.Huang@nxp.com>
In-Reply-To: <1570616148-11571-2-git-send-email-Anson.Huang@nxp.com>
Accept-Language: zh-CN, en-US
Content-Language: en-US
received-spf: None (protection.outlook.com: nxp.com does not designate
 permitted sender hosts)
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-Network-Message-Id: 5dff17fc-8b28-4401-11f7-08d74d4ed85c
X-MS-Exchange-CrossTenant-originalarrivaltime: 10 Oct 2019 06:55:32.7655
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: i29pEoMnH+CJqJR21Jyc2nC9iA3sfUwtHSERO+UPY/t3+m1sTVynKQ2E6Qsxuk5ggshc9DsU2kbjQqs8VriiAA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR0402MB2925
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

From: Anson Huang <Anson.Huang@nxp.com> Sent: Wednesday, October 9, 2019 6:=
16 PM
> Use platform_get_irq_byname_optional() and platform_get_irq_optional()
> instead of platform_get_irq_byname() and platform_get_irq() for optional
> IRQs to avoid below error message during probe:
>=20
> [    0.795803] fec 30be0000.ethernet: IRQ pps not found
> [    0.800787] fec 30be0000.ethernet: IRQ index 3 not found
>=20
> Fixes: 7723f4c5ecdb ("driver core: platform: Add an error message to
> platform_get_irq*()")
> Signed-off-by: Anson Huang <Anson.Huang@nxp.com>

Acked-by: Fugang Duan <fugang.duan@nxp.com>
> ---
>  drivers/net/ethernet/freescale/fec_ptp.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>=20
> diff --git a/drivers/net/ethernet/freescale/fec_ptp.c
> b/drivers/net/ethernet/freescale/fec_ptp.c
> index 19e2365..945643c 100644
> --- a/drivers/net/ethernet/freescale/fec_ptp.c
> +++ b/drivers/net/ethernet/freescale/fec_ptp.c
> @@ -600,9 +600,9 @@ void fec_ptp_init(struct platform_device *pdev, int
> irq_idx)
>=20
>  	INIT_DELAYED_WORK(&fep->time_keep, fec_time_keep);
>=20
> -	irq =3D platform_get_irq_byname(pdev, "pps");
> +	irq =3D platform_get_irq_byname_optional(pdev, "pps");
>  	if (irq < 0)
> -		irq =3D platform_get_irq(pdev, irq_idx);
> +		irq =3D platform_get_irq_optional(pdev, irq_idx);
>  	/* Failure to get an irq is not fatal,
>  	 * only the PTP_CLOCK_PPS clock events should stop
>  	 */
> --
> 2.7.4