Received: by 2002:a5b:505:0:0:0:0:0 with SMTP id o5csp2018915ybp; Thu, 10 Oct 2019 00:41:53 -0700 (PDT) X-Google-Smtp-Source: APXvYqwILV8n7US/hIjadJGkluv9v5c/yfVI6R0PmgjRtguiIhdG9VJBzeODZF1+Zfz+ChaXTDz2 X-Received: by 2002:a17:906:7094:: with SMTP id b20mr6945236ejk.134.1570693313071; Thu, 10 Oct 2019 00:41:53 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1570693313; cv=none; d=google.com; s=arc-20160816; b=LI+volPRzpqzSDQTTZUzCPU1BGAxHUyyidlGyOMQmYdWBCG+Lw/5pyD/v4tfYIJTMK bhqF7GYP29crjkx8tlWDSOt61nWdU+nFA+kEB2v1d9HhvQ7F+FEwL11CbVlXi0AEVOsa 6n6VmyL/Sno82v7W6hTfdMmC15+58GfPHtY2xWxW6/qma/9O+TJDnySCOM4xTuTexbb4 hx9QBwd39yZ0mIYcMNTr7qFyHtG4pHJtNrbzFIUpzNxqMjOCCTGf6jHeRSeC0xnurKxV ZbYbf3d/d5AoMId8F0qwrN0SNyvTiuNMoqCp3DA1kUj7iBwnIo6Aj2jaX2Z6B+a3FE47 +btg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding :content-language:in-reply-to:mime-version:user-agent:date :message-id:from:references:cc:to:subject; bh=/ZBcBbqLvUcXbPT/JfyFX0qjl/Pgeq74p4fm4aGVuuM=; b=YSxfv5ACga7WxDwCctlsB5V2ry9kCvVk4BxN2H3fiO4kS2QZAv9eAwG5ix0TADXkeZ fjnjpCmTCYHkyYBzVjrAFAiQg3I0B/yKgI+yvXV9mRPf3GHFmpO4FXg6zFBnM8glLySV O3DtwsnGyKRmvzPmrgI929Cm8nRDVXEtaRfjCqArrll7SYUyrBh0HTUvk+AIYRvFk3aR HR6WTwzSP01sqs03otoJpAGvXRHXw2UG3xI0dmLfkxdxKXNZY4NcgRXuk5hQpEUAGXS2 vb9hlRDfr5QMvCMndWCc6IBbqffzE7oA8CtZGFF9eyoh+01uqW1wUJa/QeHXaIchatPv MQYw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id b56si2838412edb.418.2019.10.10.00.41.29; Thu, 10 Oct 2019 00:41:53 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2387477AbfJJHkC (ORCPT + 99 others); Thu, 10 Oct 2019 03:40:02 -0400 Received: from szxga04-in.huawei.com ([45.249.212.190]:3683 "EHLO huawei.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S2387469AbfJJHkB (ORCPT ); Thu, 10 Oct 2019 03:40:01 -0400 Received: from DGGEMS404-HUB.china.huawei.com (unknown [172.30.72.60]) by Forcepoint Email with ESMTP id 051659DB5E3A0C01908C; Thu, 10 Oct 2019 15:39:58 +0800 (CST) Received: from [10.134.22.195] (10.134.22.195) by smtp.huawei.com (10.3.19.204) with Microsoft SMTP Server (TLS) id 14.3.439.0; Thu, 10 Oct 2019 15:39:51 +0800 Subject: Re: [PATCH for-next 1/5] erofs: clean up collection handling routines To: Gao Xiang , CC: LKML , Miao Xie , "Li Guifu" References: <20191008125616.183715-1-gaoxiang25@huawei.com> From: Chao Yu Message-ID: <94a79a77-6875-d60e-2a51-48460ba3ae7f@huawei.com> Date: Thu, 10 Oct 2019 15:40:08 +0800 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: <20191008125616.183715-1-gaoxiang25@huawei.com> Content-Type: text/plain; charset="windows-1252" Content-Language: en-US Content-Transfer-Encoding: 7bit X-Originating-IP: [10.134.22.195] X-CFilter-Loop: Reflected Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2019/10/8 20:56, Gao Xiang wrote: > - change return value to int since collection is > already returned within the collector. > - better function naming. > > Signed-off-by: Gao Xiang Reviewed-by: Chao Yu Thanks,