Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
From:   Chengguang Xu <cgxu519@mykernel.net>
To:     ocfs2-devel@oss.oracle.com, linux-kernel@vger.kernel.org
Cc:     akpm@linux-foundation.org, mark@fasheh.com, jlbec@evilplan.org,
        joseph.qi@linux.alibaba.com, Chengguang Xu <cgxu519@mykernel.net>
Message-ID: <20191010082349.1134-1-cgxu519@mykernel.net>
Subject: (RESEND) [PATCH] ocfs2: Fix error handling in ocfs2_setattr()
Date:   Thu, 10 Oct 2019 16:23:49 +0800
MIME-Version: 1.0
Content-Transfer-Encoding: quoted-printable
Content-Type: text/plain; charset=utf8
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

Should set transfer_to[USRQUOTA/GRPQUOTA] to NULL
on error case before jump to do dqput().

Signed-off-by: Chengguang Xu <cgxu519@mykernel.net>
---
 fs/ocfs2/file.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/fs/ocfs2/file.c b/fs/ocfs2/file.c
index 2e982db3e1ae..53939bf9d7d2 100644
--- a/fs/ocfs2/file.c
+++ b/fs/ocfs2/file.c
@@ -1230,6 +1230,7 @@ int ocfs2_setattr(struct dentry *dentry, struct iattr=
 *attr)
 =09=09=09transfer_to[USRQUOTA] =3D dqget(sb, make_kqid_uid(attr->ia_uid));
 =09=09=09if (IS_ERR(transfer_to[USRQUOTA])) {
 =09=09=09=09status =3D PTR_ERR(transfer_to[USRQUOTA]);
+=09=09=09=09transfer_to[USRQUOTA] =3D NULL;
 =09=09=09=09goto bail_unlock;
 =09=09=09}
 =09=09}
@@ -1239,6 +1240,7 @@ int ocfs2_setattr(struct dentry *dentry, struct iattr=
 *attr)
 =09=09=09transfer_to[GRPQUOTA] =3D dqget(sb, make_kqid_gid(attr->ia_gid));
 =09=09=09if (IS_ERR(transfer_to[GRPQUOTA])) {
 =09=09=09=09status =3D PTR_ERR(transfer_to[GRPQUOTA]);
+=09=09=09=09transfer_to[GRPQUOTA] =3D NULL;
 =09=09=09=09goto bail_unlock;
 =09=09=09}
 =09=09}
--=20
2.20.1