Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Thu, 10 Oct 2019 10:26:06 +0200
From:   Miquel Raynal <miquel.raynal@bootlin.com>
To:     Fuqian Huang <huangfq.daxian@gmail.com>
Cc:     David Woodhouse <dwmw2@infradead.org>,
        Brian Norris <computersforpeace@gmail.com>,
        Marek Vasut <marek.vasut@gmail.com>,
        Richard Weinberger <richard@nod.at>,
        Vignesh Raghavendra <vigneshr@ti.com>,
        linux-mtd@lists.infradead.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] mtd: maps: l440gx: Avoid print address to dmesg
Message-ID: <20191010102606.253ff6b9@xps13>
In-Reply-To: <20191010080130.25402-1-huangfq.daxian@gmail.com>
References: <20191010080130.25402-1-huangfq.daxian@gmail.com>
Organization: Bootlin
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8BIT
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

Hi Fuqian,

Fuqian Huang <huangfq.daxian@gmail.com> wrote on Thu, 10 Oct 2019
16:01:30 +0800:

> Avoid print the address of l440gx_map.virt every time l440gx init.
> 
> Signed-off-by: Fuqian Huang <huangfq.daxian@gmail.com>
> ---
>  drivers/mtd/maps/l440gx.c | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/drivers/mtd/maps/l440gx.c b/drivers/mtd/maps/l440gx.c
> index 876f12f40018..e7e40bca82d1 100644
> --- a/drivers/mtd/maps/l440gx.c
> +++ b/drivers/mtd/maps/l440gx.c
> @@ -86,7 +86,6 @@ static int __init init_l440gx(void)
>  		return -ENOMEM;
>  	}
>  	simple_map_init(&l440gx_map);
> -	printk(KERN_NOTICE "window_addr = 0x%08lx\n", (unsigned long)l440gx_map.virt);
>  
>  	/* Setup the pm iobase resource
>  	 * This code should move into some kind of generic bridge


It looks more like a debug message, maybe turn it into a KERN_DEBUG?
Usually people do not run their kernels with such a low trace limit.

Thanks,
Miquèl