Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Subject: Re: (RESEND) [PATCH] ocfs2: Fix error handling in ocfs2_setattr()
To:     Chengguang Xu <cgxu519@mykernel.net>, ocfs2-devel@oss.oracle.com,
        linux-kernel@vger.kernel.org
Cc:     akpm@linux-foundation.org, mark@fasheh.com, jlbec@evilplan.org,
        joseph.qi@linux.alibaba.com
References: <20191010082349.1134-1-cgxu519@mykernel.net>
From:   Joseph Qi <jiangqi903@gmail.com>
Message-ID: <6c6a49dd-f1e6-da3e-8481-071071c91b06@gmail.com>
Date:   Thu, 10 Oct 2019 16:49:46 +0800
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.11; rv:60.0)
 Gecko/20100101 Thunderbird/60.9.0
MIME-Version: 1.0
In-Reply-To: <20191010082349.1134-1-cgxu519@mykernel.net>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk


On 19/10/10 16:23, Chengguang Xu wrote:
> Should set transfer_to[USRQUOTA/GRPQUOTA] to NULL
> on error case before jump to do dqput().
> 
> Signed-off-by: Chengguang Xu <cgxu519@mykernel.net>

Looks good.

Reviewed-by: Joseph Qi <joseph.qi@linux.alibaba.com>
> ---
>  fs/ocfs2/file.c | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/fs/ocfs2/file.c b/fs/ocfs2/file.c
> index 2e982db3e1ae..53939bf9d7d2 100644
> --- a/fs/ocfs2/file.c
> +++ b/fs/ocfs2/file.c
> @@ -1230,6 +1230,7 @@ int ocfs2_setattr(struct dentry *dentry, struct iattr *attr)
>  			transfer_to[USRQUOTA] = dqget(sb, make_kqid_uid(attr->ia_uid));
>  			if (IS_ERR(transfer_to[USRQUOTA])) {
>  				status = PTR_ERR(transfer_to[USRQUOTA]);
> +				transfer_to[USRQUOTA] = NULL;
>  				goto bail_unlock;
>  			}
>  		}
> @@ -1239,6 +1240,7 @@ int ocfs2_setattr(struct dentry *dentry, struct iattr *attr)
>  			transfer_to[GRPQUOTA] = dqget(sb, make_kqid_gid(attr->ia_gid));
>  			if (IS_ERR(transfer_to[GRPQUOTA])) {
>  				status = PTR_ERR(transfer_to[GRPQUOTA]);
> +				transfer_to[GRPQUOTA] = NULL;
>  				goto bail_unlock;
>  			}
>  		}
>