Received: by 2002:a5b:505:0:0:0:0:0 with SMTP id o5csp2087465ybp; Thu, 10 Oct 2019 01:59:05 -0700 (PDT) X-Google-Smtp-Source: APXvYqz8IhcGSzLScvcWGPojRuPUmozi0H6hskjXQWHT56wHWsmHADVySqZEJJGcD0LZN/3p7g9L X-Received: by 2002:a17:906:35c7:: with SMTP id p7mr7022348ejb.310.1570697945455; Thu, 10 Oct 2019 01:59:05 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1570697945; cv=none; d=google.com; s=arc-20160816; b=iJKWTNSYrC0NQVeybNRf2+zou/utt/XHfIV1l45Xlk37t3JRCPPXPXR/HHy8pcxoL4 ZkJfg1rcpcYoSG7W/DgkTA+Z1yOMjIGZ+jjCjWpkVjlf5lNywBsDapOp17cphq+2pztM NtEV60Xp1qv3EkdQcIxJmmv0L/BBIc/TpDOyhwYnCV6emwJwJUh8GffaM18zzyFlGAqj YjocTRl1fRqjiY+ORJ8L/gg+183syURsqUSbqkb/62xulisWqvxJmWP536OUvWMCPchT lwm5pP8saXhsyYZi3xn9YYWI+JQZPhoXG0aOJBV06badC9Jk2cYQtJnP1+649fD4DUKE V5Zw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=rwsD0APeidFA/JiY3PvbemO8mIt59JFLvVk3Fhvvq2c=; b=Aogm35kRGnXtuUFRzW7kxrgrgFqbGGsbgC12nAETFEkPn8N4mIzbxTgTDAdTchrcRH 5PwZzBtzq+UVMRProrpBIYcpRGhynm+MP1qS97XCE8WgPRIMkwbRoqqIkqabPJ1nh2iS PllzjBvMuHw/MSbaUGvGPQlmnngm+7WGIuUdH8DuDVD2E87udypVcs7dkeHvWn1x+31x U+8ie9glpsjMH/xSZ3JyptnWmZuKuwWBZHeWjrh04fuCktZe8PctmW7P7e2/vHh4mDYq 6OrJYrYzddee1JnOMFUBeo1WNrrLE42vKThl+ZddaBB1pvh3KO5z2LLeshfDWvX9j09t Zxyg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=KogfDiq6; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id e4si2754835edy.295.2019.10.10.01.58.42; Thu, 10 Oct 2019 01:59:05 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=KogfDiq6; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2387494AbfJJIph (ORCPT + 99 others); Thu, 10 Oct 2019 04:45:37 -0400 Received: from mail.kernel.org ([198.145.29.99]:51150 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2389158AbfJJIpd (ORCPT ); Thu, 10 Oct 2019 04:45:33 -0400 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 711A02054F; Thu, 10 Oct 2019 08:45:32 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1570697133; bh=kHF1T18V0B85FjA/sMNpJQV9yXiVVxa+g33YQBJI1fE=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=KogfDiq6aV4rdKwhnKawa6nJRfVjgn6fV02Y2v+bfVE2OWU3N/PoAR/VWDBSPj3k1 CdXTnZwPcW55E65HeJWRyVerMT3qb5eOS2dDdmhJGtXNj9F3nMB5eOMdh4cy3qfnoF kYduZUhIjKxdQTUsW64l4ubE/wUm5sZm/3rznveM= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Heiko Carstens , Vasily Gorbik Subject: [PATCH 4.19 003/114] s390/topology: avoid firing events before kobjs are created Date: Thu, 10 Oct 2019 10:35:10 +0200 Message-Id: <20191010083545.766494656@linuxfoundation.org> X-Mailer: git-send-email 2.23.0 In-Reply-To: <20191010083544.711104709@linuxfoundation.org> References: <20191010083544.711104709@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Vasily Gorbik commit f3122a79a1b0a113d3aea748e0ec26f2cb2889de upstream. arch_update_cpu_topology is first called from: kernel_init_freeable->sched_init_smp->sched_init_domains even before cpus has been registered in: kernel_init_freeable->do_one_initcall->s390_smp_init Do not trigger kobject_uevent change events until cpu devices are actually created. Fixes the following kasan findings: BUG: KASAN: global-out-of-bounds in kobject_uevent_env+0xb40/0xee0 Read of size 8 at addr 0000000000000020 by task swapper/0/1 BUG: KASAN: global-out-of-bounds in kobject_uevent_env+0xb36/0xee0 Read of size 8 at addr 0000000000000018 by task swapper/0/1 CPU: 0 PID: 1 Comm: swapper/0 Tainted: G B Hardware name: IBM 3906 M04 704 (LPAR) Call Trace: ([<0000000143c6db7e>] show_stack+0x14e/0x1a8) [<0000000145956498>] dump_stack+0x1d0/0x218 [<000000014429fb4c>] print_address_description+0x64/0x380 [<000000014429f630>] __kasan_report+0x138/0x168 [<0000000145960b96>] kobject_uevent_env+0xb36/0xee0 [<0000000143c7c47c>] arch_update_cpu_topology+0x104/0x108 [<0000000143df9e22>] sched_init_domains+0x62/0xe8 [<000000014644c94a>] sched_init_smp+0x3a/0xc0 [<0000000146433a20>] kernel_init_freeable+0x558/0x958 [<000000014599002a>] kernel_init+0x22/0x160 [<00000001459a71d4>] ret_from_fork+0x28/0x30 [<00000001459a71dc>] kernel_thread_starter+0x0/0x10 Cc: stable@vger.kernel.org Reviewed-by: Heiko Carstens Signed-off-by: Vasily Gorbik Signed-off-by: Greg Kroah-Hartman --- arch/s390/kernel/topology.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) --- a/arch/s390/kernel/topology.c +++ b/arch/s390/kernel/topology.c @@ -311,7 +311,8 @@ int arch_update_cpu_topology(void) on_each_cpu(__arch_update_dedicated_flag, NULL, 0); for_each_online_cpu(cpu) { dev = get_cpu_device(cpu); - kobject_uevent(&dev->kobj, KOBJ_CHANGE); + if (dev) + kobject_uevent(&dev->kobj, KOBJ_CHANGE); } return rc; }