Received: by 2002:a5b:505:0:0:0:0:0 with SMTP id o5csp2089559ybp; Thu, 10 Oct 2019 02:01:05 -0700 (PDT) X-Google-Smtp-Source: APXvYqyMwaTCWDgpnWbggfics+pqXj/w+U4A/miKJiw/8sKmqaEsLBscvQy7rDpr4EJk1SVwwpum X-Received: by 2002:a17:906:5051:: with SMTP id e17mr6896624ejk.139.1570698064987; Thu, 10 Oct 2019 02:01:04 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1570698064; cv=none; d=google.com; s=arc-20160816; b=v6LLLtYH6gfilMUiAQlYz3/Faw1KtO8fyo2ZRHVN768fu8zK7wd8EItl6TA/29zYaJ JoVBJmzeOP0QqTZ4PEBzmHhIDuO149l3gNxYsCsLjtXZKuI3XrByFomky8cLs6pQIzZC W2TVmQjhhmjcrn9zl4XKrdh8emfbFUSaeTROxegZugyACwW55Nxbnk3uLBpiWsQXJT6Z ndMMPHmd8G21XjRZ/v+VdrmZ6Gc1iFVtbXiDz9HyhVL8tqpUbYp4v40E3JxbLMLuh3ZU 1SF78s/KqEFpJFtZPKxysUiiKcxosU96R8CqaqyUleoKD7oZSlo3b/foMjoNkg/90Mm8 QKNg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=m0hryR8HsFRXQXbSwEUi/6CZocggdNtoiWleAnoqFI4=; b=RRYahjEqNTpmBBqV6I8z/tit+pZh5GqnWhcLnjH62wQlsGL9PjqKmpjvyoL09IOVy7 9/LTC24JMa5jTWzPuuXbhp6E4Ur1vp81OMW+ePlhWZfcCoKqYjvV0aSYMUBogoIiqIsV O6JVwP8VQe9Q8KMt1MbrouYXch9uJ8C4FYx334BHmmG74XUCUD6fV+vGmzKUCVCCHjVv w6UB1PTWg7BU7VA2BaXzTu3cvCuWWaZd7u9P5+xklIOj3Yln7L3kynx2ibg9kAeCTCsf XxiX7XIlsw2bI4J+16fFyvxf5E688WIEHmBA6TAhSNCcMvQ29Z8yFidwiz/dXB8qiW21 Qkhw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=GziLrO9Q; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id d26si3285150eda.190.2019.10.10.02.00.41; Thu, 10 Oct 2019 02:01:04 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=GziLrO9Q; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2388371AbfJJIpK (ORCPT + 99 others); Thu, 10 Oct 2019 04:45:10 -0400 Received: from mail.kernel.org ([198.145.29.99]:50646 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2389055AbfJJIpG (ORCPT ); Thu, 10 Oct 2019 04:45:06 -0400 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 13A3321929; Thu, 10 Oct 2019 08:45:05 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1570697105; bh=2zuuBILVBCcqXDaiw/iKTe4cR80FAkibiEk1vK9tmdE=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=GziLrO9QLhIvYzJjYElnqW/xDDCojTYL1ZWSYrzqIapcRuE54XtyZmi3/Ipf6dvuV TbUmP8Dw+IOqpOmrpisWxr+lvA3E5pymuWSolpPweV5eRZyQ79BkYexetXhQYP7V+P o52qU2C7tl3CR4NEmWlrDM3qH60xURcgGdXcwGRg= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Tzvetomir Stoyanov , "Steven Rostedt (VMware)" , Alexander Shishkin , David Carrillo-Cisneros , He Kuang , Jiri Olsa , Michal rarek , Paul Turner , Peter Zijlstra , Stephane Eranian , =?UTF-8?q?Uwe=20Kleine-K=C3=B6nig?= , Wang Nan , Arnaldo Carvalho de Melo Subject: [PATCH 4.19 020/114] tools lib traceevent: Fix "robust" test of do_generate_dynamic_list_file Date: Thu, 10 Oct 2019 10:35:27 +0200 Message-Id: <20191010083553.429261317@linuxfoundation.org> X-Mailer: git-send-email 2.23.0 In-Reply-To: <20191010083544.711104709@linuxfoundation.org> References: <20191010083544.711104709@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Steven Rostedt (VMware) commit 82a2f88458d70704be843961e10b5cef9a6e95d3 upstream. The tools/lib/traceevent/Makefile had a test added to it to detect a failure of the "nm" when making the dynamic list file (whatever that is). The problem is that the test sorts the values "U W w" and some versions of sort will place "w" ahead of "W" (even though it has a higher ASCII value, and break the test. Add 'tr "w" "W"' to merge the two and not worry about the ordering. Reported-by: Tzvetomir Stoyanov Signed-off-by: Steven Rostedt (VMware) Cc: Alexander Shishkin Cc: David Carrillo-Cisneros Cc: He Kuang Cc: Jiri Olsa Cc: Michal rarek Cc: Paul Turner Cc: Peter Zijlstra Cc: Stephane Eranian Cc: Uwe Kleine-König Cc: Wang Nan Cc: stable@vger.kernel.org Fixes: 6467753d61399 ("tools lib traceevent: Robustify do_generate_dynamic_list_file") Link: http://lkml.kernel.org/r/20190805130150.25acfeb1@gandalf.local.home Signed-off-by: Arnaldo Carvalho de Melo Signed-off-by: Greg Kroah-Hartman --- tools/lib/traceevent/Makefile | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) --- a/tools/lib/traceevent/Makefile +++ b/tools/lib/traceevent/Makefile @@ -259,8 +259,8 @@ endef define do_generate_dynamic_list_file symbol_type=`$(NM) -u -D $1 | awk 'NF>1 {print $$1}' | \ - xargs echo "U W w" | tr ' ' '\n' | sort -u | xargs echo`;\ - if [ "$$symbol_type" = "U W w" ];then \ + xargs echo "U w W" | tr 'w ' 'W\n' | sort -u | xargs echo`;\ + if [ "$$symbol_type" = "U W" ];then \ (echo '{'; \ $(NM) -u -D $1 | awk 'NF>1 {print "\t"$$2";"}' | sort -u;\ echo '};'; \