Received: by 2002:a5b:505:0:0:0:0:0 with SMTP id o5csp2334126ybp; Thu, 10 Oct 2019 06:02:50 -0700 (PDT) X-Google-Smtp-Source: APXvYqwIzXn54O/C/ceVR0tJ2zwhqGHdFF4WWX1MAVGrKi2AqtrRPu1+l9zh0+mPUUaChetLxfWz X-Received: by 2002:a1c:7219:: with SMTP id n25mr7904951wmc.101.1570712570485; Thu, 10 Oct 2019 06:02:50 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1570712570; cv=none; d=google.com; s=arc-20160816; b=Z2OKSmE8LVdXFcgdaDcz2JS+g2WZrIbsi7G9O7+/DuZD2hE6nmE5hNWCdoGTRhKyL8 tdxTh2swpJlHXdvgDk6OCwiHABBC9J4zX8Sbk2SpEgL5CSaw6uY2p8oFrq8tcE9gKpSJ RoI2m1um8l1zrEPOc3lBQY62gYR/6Zjsu//yXE2N7rxeE6i0rYtVLIjnhO+tRjSGM7wI bk4/poUqPAA7Ege2kAXm/bp7AGy+Xz50ZftRsh2GRQvLr98AMDgMHG4Rs7yHcnKA6NAr tSCmvNGDChDq7aIYqav8ow1z4bEmt61loREfeVsLaiM1Qz7R8vHxHTrXJ2j8CHmag2Yd tkFQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:message-id:subject:cc:to:from:date; bh=EKEZO7NXq92FRDm8GeOa8ponr2UgFY2pk7EPxHVgXu4=; b=NHzpvRsBDtDd77cdqpyz0BGPWroK/U66XqIRTygWYRBO1DmbulxSBkyXS9tWsdOhU6 m5f0VCj/Zb9xm67+SS10LLMO0qIliJFxd+yf1sDAnsnc2Plmr7UV3Mrvh1Xwn3DrYaCr VZFU/nXO+QNMy1II8XW4brpm9UJ/CD2Dojekqf1zLp4uMcbxnox9M2RDvhFgKTsM2wuN pwyqm5rVOCgLFPmF9BvVQvPrrkcGVJRXDeL2ImXKhU/tQACC0HL5AOBbS0HpKe7NMCz+ Xk3VBIvv8YTduG5q45E5ZeRwfQsiOCkias/BwNCoe4/+eLtEJbpEcZTCNxS/67aBvXnR voYw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id a54si3278895edc.333.2019.10.10.06.02.18; Thu, 10 Oct 2019 06:02:50 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2387651AbfJJNBi convert rfc822-to-8bit (ORCPT + 99 others); Thu, 10 Oct 2019 09:01:38 -0400 Received: from mx2.suse.de ([195.135.220.15]:57892 "EHLO mx1.suse.de" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1728274AbfJJNBi (ORCPT ); Thu, 10 Oct 2019 09:01:38 -0400 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.220.254]) by mx1.suse.de (Postfix) with ESMTP id 8B7CEAED6; Thu, 10 Oct 2019 13:01:36 +0000 (UTC) Date: Thu, 10 Oct 2019 15:01:36 +0200 From: Thomas Bogendoerfer To: Christoph Hellwig Cc: Ralf Baechle , Paul Burton , James Hogan , linux-mips@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] MIPS: add support for SGI Octane (IP30) Message-Id: <20191010150136.a30e47b37f8c8aed9e863a5e@suse.de> In-Reply-To: <20191009184311.GA20261@infradead.org> References: <20191009155928.3047-1-tbogendoerfer@suse.de> <20191009184311.GA20261@infradead.org> X-Mailer: Sylpheed 3.5.1 (GTK+ 2.24.32; x86_64-suse-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 8BIT Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 9 Oct 2019 11:43:11 -0700 Christoph Hellwig wrote: > > +++ b/arch/mips/sgi-ip30/ip30-pci.c > > @@ -0,0 +1,19 @@ > > +// SPDX-License-Identifier: GPL-2.0 > > +/* > > + * ip30-pci.c: misc PCI related helper code for IP30 architecture > > + */ > > + > > +#include > > + > > +dma_addr_t __phys_to_dma(struct device *dev, phys_addr_t paddr) > > +{ > > + struct pci_dev *pdev = to_pci_dev(dev); > > + struct bridge_controller *bc = BRIDGE_CONTROLLER(pdev->bus); > > + > > + return bc->baddr + paddr; > > +} > > + > > +phys_addr_t __dma_to_phys(struct device *dev, dma_addr_t dma_addr) > > +{ > > + return dma_addr & ~(0xffUL << 56); > > +} > > This file is duplicated from ip27. I think we should aim to share > it given the common hardware even if it is mostly trivial. ok, as far as I can anticipate IP35 verion of this functions will be the same as well. So I'll move both into pci-xtalk-bridge.c in the next version of the patch. Thomas. -- SUSE Software Solutions Germany GmbH HRB 247165 (AG M?nchen) Gesch?ftsf?hrer: Felix Imend?rffer