Received: by 2002:a5b:505:0:0:0:0:0 with SMTP id o5csp2392899ybp; Thu, 10 Oct 2019 06:49:27 -0700 (PDT) X-Google-Smtp-Source: APXvYqwpA9M3D6WUo5hqWz+YsqoDQb+H97xR683KKg6LFCkzunP9TA2OjQ1JCjEJwy+YwRiwkibW X-Received: by 2002:a17:906:3010:: with SMTP id 16mr8403683ejz.74.1570715367589; Thu, 10 Oct 2019 06:49:27 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1570715367; cv=none; d=google.com; s=arc-20160816; b=GvFUqfeiU9AjKTUgHWt2bPG0TUmEENxbUPuRe4KqHiWM4Hv6NwKuu8Gg0XjHFa1L2L cDGiqPQbjj7P43IxAgleqJeviefkl/d9ast/JXPPD05bAOuXa3QXFitMN3hvTFOLwaMz PHUOBo5IE7eyh4gD6ymkPhfUcuVBKOyvA6z5iORs1bvZROtSM25jLjDVyW3A9jOeZB3k KN1hQdmmXnAgRe5c0EAavlkHskIn53pdtOvJzq7VgLtLA+HuJSbevQySfUbZfy1YbPMT iCqjNWQ/+93zscyL6hWKT+HI2UKclFeFvjbf0OXuOYWft4Ky4UPIlUi6rfKlFrh1wlSC KrRg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:dkim-signature; bh=BFnPJ9CbG5m+x0gh6lci0Tzu5Dr4+uLZpxV5Yx2Lp/I=; b=HneUJdPctfiWUKITpzMNQvw4a8EjIEBZPn6OaC100ExFix6VyD/lamZHWnQJj1f3eO UULXErlt6+fPy5K1hPTkzu85cypRPHSTlaZ2x8kQbJgvvJ+3Zj8mTS/5EcQcZKpMyJMa zWVYs9vhXTBFblTElZOxFsS1CAKtT7fcjMcJD67sPLdUX7wDHZxfUdGwVnOxdOYJ0pBQ zQlyaWFeCT8Z3sYS92JUnK18Kf5lfwXx/mohbntWBR41kd2c5+Q+YSolSD+rJZWgqGoR 8O1x49RYbeqJ/IaJ2AlCYbAr5z7c2S9+tL6b8L0z/FT1JQw48DSGaCvPNbYif0AGlcn+ gHWA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@resnulli-us.20150623.gappssmtp.com header.s=20150623 header.b=2D1Tqf6U; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id d17si4145857eda.213.2019.10.10.06.49.02; Thu, 10 Oct 2019 06:49:27 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@resnulli-us.20150623.gappssmtp.com header.s=20150623 header.b=2D1Tqf6U; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2388356AbfJJNmI (ORCPT + 99 others); Thu, 10 Oct 2019 09:42:08 -0400 Received: from mail-wm1-f68.google.com ([209.85.128.68]:38565 "EHLO mail-wm1-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2387791AbfJJNmH (ORCPT ); Thu, 10 Oct 2019 09:42:07 -0400 Received: by mail-wm1-f68.google.com with SMTP id 3so6854566wmi.3 for ; Thu, 10 Oct 2019 06:42:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=resnulli-us.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=BFnPJ9CbG5m+x0gh6lci0Tzu5Dr4+uLZpxV5Yx2Lp/I=; b=2D1Tqf6UFvfY0GQ9zEYDEh2Aun4e/M6ytMMzlnE2j/5GfOvQb2EdFXTY8hL3tUFiK4 IKvpLWImL7VIt4bWNW6tdtZjUjstnN9Sw4k+8qSkxy1hm7hP3wzyM9tXrNoehAr2pBfI /pph7Ltzs7VJpXiH5PgtBZQg6RphycW5hmd6eemxlXSu9/bL+7iUvP0l/8E2smERE16U c5a5JCC+dn3i1Kuzymw+jIQ/dEaazHKRi+sULEFpIKz+2f2qySvzK8MEQTuoEX/m8FmZ zndroZ+Qn1ckVlUP4Av//2uOc97O8bKY+D/nzac0m21tJ0UcjUJJbsX0H8QvCCFL0QQv 4HKg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=BFnPJ9CbG5m+x0gh6lci0Tzu5Dr4+uLZpxV5Yx2Lp/I=; b=HPn8ZEt1nij63b/Wm+mc+ZhI18Uv1n8EvaumVwBN2wXOAc6B8M5Jno/T7X1ODTy+7F Dzwcw8ECNZg1cXsJRUP0eHvAatORH3ha1qT4d2eBYWS3kBD1/gEfVPaRzcCh2aCY1t48 UfHDp0lhX9dm7Wpi27Ouen84dflzv0T9ulwfHi+y4FQTn/JzayGE37U+jc+9RefhKVka 1NXt9oqt4XlYtzs+dxz6qgztcLzFp0BmEb5PlZgm9VFD1B4EgNVjtYUCN3tyUSDnoDH+ MbcX0aKM7o6m2UZZCkUl8wGmTrptPU2xJ5BBIWkkRbjapOCbr1KaxCU+qq1eF5hJ6cos YEoQ== X-Gm-Message-State: APjAAAUcqz4j2xp0uJqZYjzRtJ2u+PU6KmV6ehhWjbGCjdBBTkCjRK9b z6yfCEunELA15eO7DT4xFGUubg== X-Received: by 2002:a05:600c:2185:: with SMTP id e5mr7960137wme.78.1570714924491; Thu, 10 Oct 2019 06:42:04 -0700 (PDT) Received: from localhost ([85.163.43.78]) by smtp.gmail.com with ESMTPSA id u1sm4930948wmc.38.2019.10.10.06.42.03 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 10 Oct 2019 06:42:03 -0700 (PDT) Date: Thu, 10 Oct 2019 15:42:03 +0200 From: Jiri Pirko To: Michal Kubecek Cc: David Miller , netdev@vger.kernel.org, Jakub Kicinski , Andrew Lunn , Florian Fainelli , John Linville , Stephen Hemminger , Johannes Berg , linux-kernel@vger.kernel.org Subject: Re: [PATCH net-next v7 05/17] ethtool: helper functions for netlink interface Message-ID: <20191010134203.GA22798@nanopsycho> References: <061af34c9f34205ed18a126cef9ebe1534de8bc7.1570654310.git.mkubecek@suse.cz> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <061af34c9f34205ed18a126cef9ebe1534de8bc7.1570654310.git.mkubecek@suse.cz> User-Agent: Mutt/1.11.4 (2019-03-13) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Wed, Oct 09, 2019 at 10:59:15PM CEST, mkubecek@suse.cz wrote: [...] >+/** >+ * ethnl_parse_header() - parse request header >+ * @req_info: structure to put results into >+ * @header: nest attribute with request header >+ * @net: request netns >+ * @extack: netlink extack for error reporting >+ * @policy: netlink attribute policy to validate header; use >+ * @dflt_header_policy (all attributes allowed) if null >+ * @require_dev: fail if no device identiified in header s/identiified/identified/