Received: by 2002:a5b:505:0:0:0:0:0 with SMTP id o5csp2394936ybp; Thu, 10 Oct 2019 06:51:16 -0700 (PDT) X-Google-Smtp-Source: APXvYqztnBCNVSmZ6FXvk61VHESc60tihFkGNIO1H20I9QZbNrNzCdQVTYfXgSkBJFG5hYLE3TWl X-Received: by 2002:a17:906:2295:: with SMTP id p21mr8262101eja.8.1570715476129; Thu, 10 Oct 2019 06:51:16 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1570715476; cv=none; d=google.com; s=arc-20160816; b=BX1uqCp7tnk65/rGSqp74xQhJp+VrT6mkeBAtGqo0g5azCk3b5yiHIy/2wNl9q+0zt cRshBJAtqRT6t0D3Ujl6mTb1mFimnc2wgbcO/E/tFB7k9jcbrwDTqq1n9wyYSnjbL4GK 8cAvWK5WIUd2fZHIP1kQeGr1z6EfGRzaZiXB/IbIPMQWNGZh8uYc5cKsAOyoVUSCfHIL uJnr8TvGh2xoiJIsVfoRQN5zjIxTiDTVT3cMXQR9b7M3pG0mSHk/WlePbd8kT1+z/s9r EhkipyJfrszn/jr3fL3sJ7f5/zaOXjEhHDI446h4ryF3LktUhUFjesj5ZKjAJN8o1eOY Sw5g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:mail-followup-to :message-id:subject:cc:to:from:date:dkim-signature; bh=o898Z3trs0jH/OlBQbiOm8e/1sEfrvM2Vk3WyyK56M4=; b=lzDdyu1Tz4KdFgo5FjlCwPZr8XnN1PoG1iHF4qP9ihDaopNDHlTcd2v1bWskv3Wkdd q38mg6TF2FTB5SPa2mdHNfExGRogTL5Yf7tTnc9sPWQZluujLdfxPyi+nVEHcLPVDX2D 68I5qDabow5QGgoVBy6yqzJkvBWUB0BbY9LodVFPYVrSfxeugkIoPkoVeOBm81oJ/nXd raaCAywqPiJMB9vIZp2xMp6MvaYXeMEG0Zrzzim0XtcYXAP/a/sY7ZOgwwzzQivLvYNY tfTAKJMgGSPmogLLoCdxbZvpUOdeA8EA90dOaGavCamabXygTdoBbs4dai/biiHrJjcc 6O5Q== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@ffwll.ch header.s=google header.b=TQZ07FMv; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id l9si2990405ejx.438.2019.10.10.06.50.51; Thu, 10 Oct 2019 06:51:16 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=fail header.i=@ffwll.ch header.s=google header.b=TQZ07FMv; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726034AbfJJNus (ORCPT + 99 others); Thu, 10 Oct 2019 09:50:48 -0400 Received: from mail-ed1-f65.google.com ([209.85.208.65]:42916 "EHLO mail-ed1-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725932AbfJJNus (ORCPT ); Thu, 10 Oct 2019 09:50:48 -0400 Received: by mail-ed1-f65.google.com with SMTP id y91so5519251ede.9 for ; Thu, 10 Oct 2019 06:50:47 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ffwll.ch; s=google; h=sender:date:from:to:cc:subject:message-id:mail-followup-to :references:mime-version:content-disposition:in-reply-to:user-agent; bh=o898Z3trs0jH/OlBQbiOm8e/1sEfrvM2Vk3WyyK56M4=; b=TQZ07FMvCXrWciJ7O9lR+yonpxUCVIcHnhmodCVsy5Dh/Y5im2arlnqViBllsFZMoz FX1zMJwHMqtbjlVh/VFK76TKJ5qMTJkhvErbbOvUl3k+Ss1ZPSUdmEOoFoKO4bV2Iigr iZ9kCTkHefQMk+aqix6L1jZn0EltF9d/5eWS4= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:date:from:to:cc:subject:message-id :mail-followup-to:references:mime-version:content-disposition :in-reply-to:user-agent; bh=o898Z3trs0jH/OlBQbiOm8e/1sEfrvM2Vk3WyyK56M4=; b=jXXN8erfClgIss90vCLxhZvqT1FO7wZv4UOy/S0AwCSRrKNGTPbIyWpjsRG8875C5r nhoN0B6IzXwfwTP3RUw4q+IvPLFm9gDDkRqkZfeWx/8qN+ahaeBWfY1oate6mpVm6ZBz 82q7iEZjecYhxO0f4YY9HHXCpPcnjfPdOY+Lw48SuBwyBtrXbt8xWkOaep35RFoWBmnI wNM0dDpT4xJsV59DVUOz85jNxanXRucnhm9PKucUnHA5f2lW7vByfLffF+QPFVxfzIR2 rJD/dwMN360uEB6nTYTwT2cTnnWTTSI3XGwnTH9FeMkBQycS8ONNxvowTCEE3sAJyT0W PHuQ== X-Gm-Message-State: APjAAAXvjYexhVr8b/5F25NNgv8+cF33mMUcLlN1ERsjQBTK3bxfUr1i ZbGWWawxmMlYn9FiqitQaWhwMg== X-Received: by 2002:a17:906:7e17:: with SMTP id e23mr374597ejr.205.1570715446752; Thu, 10 Oct 2019 06:50:46 -0700 (PDT) Received: from phenom.ffwll.local (212-51-149-96.fiber7.init7.net. [212.51.149.96]) by smtp.gmail.com with ESMTPSA id 36sm988776edz.92.2019.10.10.06.50.45 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 10 Oct 2019 06:50:45 -0700 (PDT) Date: Thu, 10 Oct 2019 15:50:43 +0200 From: Daniel Vetter To: Johan Hovold Cc: Rob Clark , Sean Paul , Fabien Dessenne , Mauro Carvalho Chehab , Harald Freudenberger , David Airlie , Daniel Vetter , Heiko Carstens , Vasily Gorbik , Christian Borntraeger , linux-arm-msm@vger.kernel.org, dri-devel@lists.freedesktop.org, freedreno@lists.freedesktop.org, linux-kernel@vger.kernel.org, linux-media@vger.kernel.org, linux-s390@vger.kernel.org, Greg Kroah-Hartman Subject: Re: [PATCH 0/4] treewide: fix interrupted release Message-ID: <20191010135043.GA16989@phenom.ffwll.local> Mail-Followup-To: Johan Hovold , Rob Clark , Sean Paul , Fabien Dessenne , Mauro Carvalho Chehab , Harald Freudenberger , David Airlie , Heiko Carstens , Vasily Gorbik , Christian Borntraeger , linux-arm-msm@vger.kernel.org, dri-devel@lists.freedesktop.org, freedreno@lists.freedesktop.org, linux-kernel@vger.kernel.org, linux-media@vger.kernel.org, linux-s390@vger.kernel.org, Greg Kroah-Hartman References: <20191010131333.23635-1-johan@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20191010131333.23635-1-johan@kernel.org> X-Operating-System: Linux phenom 5.2.0-2-amd64 User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Oct 10, 2019 at 03:13:29PM +0200, Johan Hovold wrote: > Two old USB drivers had a bug in them which could lead to memory leaks > if an interrupted process raced with a disconnect event. > > Turns out we had a few more driver in other subsystems with the same > kind of bug in them. > > Note that all but the s390 patch have only been compile tested, while > the s390 one has not even been built. Random funny idea: Could we do some debug annotations (akin to might_sleep) that splats when you might_sleep_interruptible somewhere where interruptible sleeps are generally a bad idea? Like in fops->release? Something like non_block_start/end that I've recently done, but for interruptible sleeps only? Would need might_sleep_interruptibly() annotations and non_interruptly_sleep_start/end annotations. -Daniel > > Johan > > > Johan Hovold (4): > drm/msm: fix memleak on release > media: bdisp: fix memleak on release > media: radio: wl1273: fix interrupt masking on release > s390/zcrypt: fix memleak at release > > drivers/gpu/drm/msm/msm_debugfs.c | 6 +----- > drivers/media/platform/sti/bdisp/bdisp-v4l2.c | 3 +-- > drivers/media/radio/radio-wl1273.c | 3 +-- > drivers/s390/crypto/zcrypt_api.c | 3 +-- > 4 files changed, 4 insertions(+), 11 deletions(-) > > -- > 2.23.0 > -- Daniel Vetter Software Engineer, Intel Corporation http://blog.ffwll.ch