Received: by 2002:a5b:505:0:0:0:0:0 with SMTP id o5csp2403964ybp; Thu, 10 Oct 2019 07:00:03 -0700 (PDT) X-Google-Smtp-Source: APXvYqwgIUZAwafb1RdcsUipub+CZHMdEHjYmP7PqJE5QIaB7B6/RwKaULP0N6KNPZ+OUf1Ph2HM X-Received: by 2002:a17:906:184e:: with SMTP id w14mr8198466eje.10.1570716003668; Thu, 10 Oct 2019 07:00:03 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1570716003; cv=none; d=google.com; s=arc-20160816; b=rqy35ZxVaRPfuPhEdW4evuUz1esrrRQiiOyrZkorleVQ0SaB7E2GEp2jszkHibXyh5 FfjlYx5pLT+LaCxUQ0WVbSbnsGy4iGiiWBwL9sjBGPs9FvlzVztYkwaVGKHmYSPKh2sX bYJvlJgjx1hLuSb/xNyyHWgoVSg7rNKiD56cN7genJbS7wR/PEw5Ha4lWjVzBR78zTgO MxfthT4CMv5+CCkY4KQbyOw8VIgfddK6wLF5q8twXpGjdVWYV/dRzCzeHk0+2GAlF8wh 430ohw9+dtHuXsxOLqc2WzE3Wqp5qRQo2al+7yF+cTWEzwEBXzDb1186XIqudWKXE4Xs Pk5Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:dkim-signature; bh=2WQZBYa815qI+SGRD60IQB0uLSUfBk1gmVJVi+Ixn+I=; b=E7fAzLEtlJ3Y6P736drqrLwt4bikFYaBHafmuiOu//iRAmACzyodkdDx5iTvQvpuGI z141+nwDOd1NE0mPDYhcfHBFq2f3ojBHSUCwKnv+qFOX16VT7EbZPRW10ThXIsZH9ErY 2FmYqPjQp1oKDRCy5M1Hc9aM8iEwE0LohQcYmXLcC0cFoI3tlzQ0QkhvnmvUvPJNKR1/ WuO2dVvPexdOSufi0cK/+CJzv/IP89c2Rq8syIG3XS+vupbORyRSgXmEXvhLnTH9EmPB KnK6KCdVLdmnteJapyV/UsPQCdTuPPZMCdxbQ4CZWlfqgD21mZu4FFxK6LIO7E7FdjCt AH+Q== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@resnulli-us.20150623.gappssmtp.com header.s=20150623 header.b=dW1SUYjq; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id gh16si3112100ejb.150.2019.10.10.06.59.39; Thu, 10 Oct 2019 07:00:03 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@resnulli-us.20150623.gappssmtp.com header.s=20150623 header.b=dW1SUYjq; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726279AbfJJN71 (ORCPT + 99 others); Thu, 10 Oct 2019 09:59:27 -0400 Received: from mail-wr1-f67.google.com ([209.85.221.67]:46510 "EHLO mail-wr1-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726009AbfJJN7V (ORCPT ); Thu, 10 Oct 2019 09:59:21 -0400 Received: by mail-wr1-f67.google.com with SMTP id o18so7993801wrv.13 for ; Thu, 10 Oct 2019 06:59:19 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=resnulli-us.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=2WQZBYa815qI+SGRD60IQB0uLSUfBk1gmVJVi+Ixn+I=; b=dW1SUYjqNQUkj1Kq9vEEnarMawZv45GBhVCsNi/ARDDgLoeFUmWmw6464Ny+DZItty T9tVLIdRgKQ7SUzXloE2D1cuhE+OpynyXYveyB1GJ2MUNMkXSSp71XT+BSv9tOPHjRiH SLZIFItbrMx/GAwBkbKuzWyQwIqCb99SX/cjFGIDgs1BjMW1PxjNiiwxa/teDmBFC0uo PfxuXU3aXCWlOsbmuO7E0UTInelYaNh4BF6Wuw7DgQrggI7Lyyyf1if/cyOhWiWKaRil 0BhGNTvWl7vSv1CB/1vrz3eEjU7PNit1756qrm1EGl83NG/E4FOY90uSQs4YXEoXt4he OMEg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=2WQZBYa815qI+SGRD60IQB0uLSUfBk1gmVJVi+Ixn+I=; b=hGM5UKRbwo5LPqdJoQPG2NYBzVBqcz0LKBOr0X+VajO/vuj56zEZcZniOMucJb0cP4 4TPr3Iqp2FRaS9Xchf8Cy+VaAo7qTfYMakNK3Xlc6C1e+GTtyoyMlCgeed/1GGVzREgG 9IqJCydhBN/MmQsZAN8o8YPjQ775A9vOIq9jt1Mf0HZBEaYCkKlg+G+c0UlLhaBSs8JP J9Nr3bvROggwSMgjZR5AJBwxcYhGBKGyjTBuUmZMQ+DRQ0FG6AGWYj+NaNL7pfhz5Hsj O9UJnSfROoM3fZw5QN7Q0K0G8930hwecrE1MIVI6CzUOGsIEBaEIANFHXngu9MXuesK0 0r2A== X-Gm-Message-State: APjAAAUfydiCRWrBCkJJFHGWPCtTW9n6yyaDu3u1l1rSaRtCIUdReZ4E MkghrTBKqX11Kl9+pgrYoM1dPA== X-Received: by 2002:adf:f4c2:: with SMTP id h2mr8884694wrp.69.1570715958919; Thu, 10 Oct 2019 06:59:18 -0700 (PDT) Received: from localhost ([85.163.43.78]) by smtp.gmail.com with ESMTPSA id w3sm7889355wru.5.2019.10.10.06.59.17 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 10 Oct 2019 06:59:18 -0700 (PDT) Date: Thu, 10 Oct 2019 15:59:17 +0200 From: Jiri Pirko To: Michal Kubecek Cc: David Miller , netdev@vger.kernel.org, Jakub Kicinski , Andrew Lunn , Florian Fainelli , John Linville , Stephen Hemminger , Johannes Berg , linux-kernel@vger.kernel.org Subject: Re: [PATCH net-next v7 10/17] ethtool: provide string sets with STRSET_GET request Message-ID: <20191010135917.GK2223@nanopsycho> References: <62cb4c137ea6cf675671920de901847d1d083db1.1570654310.git.mkubecek@suse.cz> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <62cb4c137ea6cf675671920de901847d1d083db1.1570654310.git.mkubecek@suse.cz> User-Agent: Mutt/1.11.4 (2019-03-13) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Wed, Oct 09, 2019 at 10:59:30PM CEST, mkubecek@suse.cz wrote: [...] >+const struct get_request_ops strset_request_ops = { I think when var is leaving context of single file, it should have prefix: ethnl_strset_request_ops [...]