Received: by 2002:a5b:505:0:0:0:0:0 with SMTP id o5csp2435137ybp; Thu, 10 Oct 2019 07:22:53 -0700 (PDT) X-Google-Smtp-Source: APXvYqy8jKlGyIodDXrYBUXpifgONs58tzN+ztwRl0aaXkdbgzMnd8a2ZDwBPlEWFf1o8M+1CU76 X-Received: by 2002:a17:906:134a:: with SMTP id x10mr8459768ejb.204.1570717373014; Thu, 10 Oct 2019 07:22:53 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1570717373; cv=none; d=google.com; s=arc-20160816; b=eV82a/CPVN0mNU6dm9VTXVU05cOjzacEes+8evjCqfRKEzsv/6ZJ57gkFbrN4giy5q YS3emHN/sYvRV/l9eKDphrjUB73ykFHtq0HZWicAZ2v7hnIfo+Fpm2Bemi4nGlee/tjX ErhhTA6RM6YxAUfwPpnh5iBYHF3iR2DjNEWCTmoLodnlXJIsO7ZsG9tZ+yqqYGm4BG9s R+BHrHITfjiE6oIX3kcwECQT+HLeZbb002PeySjD+DQfn01H2an81fP5yZuW49cqS5yg dYz7Iijx0h27JH0rlmzVWhqIo/t1dGj2fvsBFtm0uZhnEVID5V5OegKL+3Q7j1sam4a+ 63Zw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:mime-version:user-agent:message-id :in-reply-to:date:references:subject:cc:to:from; bh=FF6T/BXxPY+bcAva4h6X+Nxmrol1B29znaltu2pU7H4=; b=Xlw+qrfKfJ6SvCqogUEWqOwEIrE9kq0wLSZ8wxamJXjFrFHKpmJSzUCeNwSE5E/E0l zSq/xXkUVL5QpeVonWMNhEuhnU2AvL53K96Xj7xX+paRgZu8chMptmc5xePxOFDCbUWY NJg5dzCfqwJtigetc64yR4GIZ4SwQ7o+it/2kZCwr2oRMjlOIM1sSOyrvC/aVy2R35Pk p3dKSjze87h7NoE1lxICLiodHuP4BCj1N3hvzkacD9SeQKcbqFvANVMkGhgkyerF47la TP+TYzqr11crduUpQs/yUsAEwSMp+ckdBLG9B/P9mb6bBxRnXSc7Oo5wkfY94Ui4wTqT 5Cqg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=redhat.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id m12si3230346eja.9.2019.10.10.07.22.29; Thu, 10 Oct 2019 07:22:53 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726333AbfJJOUA (ORCPT + 99 others); Thu, 10 Oct 2019 10:20:00 -0400 Received: from mx1.redhat.com ([209.132.183.28]:5413 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726182AbfJJOT7 (ORCPT ); Thu, 10 Oct 2019 10:19:59 -0400 Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.14]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 471F33CA00; Thu, 10 Oct 2019 14:19:59 +0000 (UTC) Received: from oldenburg2.str.redhat.com (dhcp-192-200.str.redhat.com [10.33.192.200]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 3D6D75DC18; Thu, 10 Oct 2019 14:19:46 +0000 (UTC) From: Florian Weimer To: Christian Brauner Cc: linux-kernel@vger.kernel.org, Oleg Nesterov , libc-alpha@sourceware.org, Ingo Molnar , Peter Zijlstra , Juri Lelli , Vincent Guittot , Dietmar Eggemann , Steven Rostedt , Ben Segall , Mel Gorman , Shuah Khan , Andrew Morton , Michal Hocko , Elena Reshetova , Thomas Gleixner , Roman Gushchin , Andrea Arcangeli , Al Viro , Aleksa Sarai , "Dmitry V. Levin" , linux-kselftest@vger.kernel.org Subject: Re: [PATCH 1/2] clone3: add CLONE3_CLEAR_SIGHAND References: <20191010133518.5420-1-christian.brauner@ubuntu.com> Date: Thu, 10 Oct 2019 16:19:44 +0200 In-Reply-To: <20191010133518.5420-1-christian.brauner@ubuntu.com> (Christian Brauner's message of "Thu, 10 Oct 2019 15:35:17 +0200") Message-ID: <87d0f4of7j.fsf@oldenburg2.str.redhat.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Scanned-By: MIMEDefang 2.79 on 10.5.11.14 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.39]); Thu, 10 Oct 2019 14:19:59 +0000 (UTC) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org * Christian Brauner: > @@ -2567,7 +2572,7 @@ static bool clone3_args_valid(const struct kernel_clone_args *kargs) > * All lower bits of the flag word are taken. > * Verify that no other unknown flags are passed along. > */ > - if (kargs->flags & ~CLONE_LEGACY_FLAGS) > + if (kargs->flags & ~(CLONE_LEGACY_FLAGS | CLONE3_CLEAR_SIGHAND)) > return false; Does the comment need updating? I feel it's a bit misleading now. Thanks, Florian