Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
From:   Florian Weimer <fweimer@redhat.com>
To:     Christian Brauner <christian.brauner@ubuntu.com>
Cc:     linux-kernel@vger.kernel.org, Oleg Nesterov <oleg@redhat.com>,
        libc-alpha@sourceware.org, Ingo Molnar <mingo@redhat.com>,
        Peter Zijlstra <peterz@infradead.org>,
        Juri Lelli <juri.lelli@redhat.com>,
        Vincent Guittot <vincent.guittot@linaro.org>,
        Dietmar Eggemann <dietmar.eggemann@arm.com>,
        Steven Rostedt <rostedt@goodmis.org>,
        Ben Segall <bsegall@google.com>, Mel Gorman <mgorman@suse.de>,
        Shuah Khan <shuah@kernel.org>,
        Andrew Morton <akpm@linux-foundation.org>,
        Michal Hocko <mhocko@suse.com>,
        Elena Reshetova <elena.reshetova@intel.com>,
        Thomas Gleixner <tglx@linutronix.de>,
        Roman Gushchin <guro@fb.com>,
        Andrea Arcangeli <aarcange@redhat.com>,
        Al Viro <viro@zeniv.linux.org.uk>,
        Aleksa Sarai <cyphar@cyphar.com>,
        "Dmitry V. Levin" <ldv@altlinux.org>,
        linux-kselftest@vger.kernel.org
Subject: Re: [PATCH 1/2] clone3: add CLONE3_CLEAR_SIGHAND
References: <20191010133518.5420-1-christian.brauner@ubuntu.com>
        <87d0f4of7j.fsf@oldenburg2.str.redhat.com>
        <20191010152148.gdea35mi7s6ivev6@wittgenstein>
Date:   Thu, 10 Oct 2019 17:22:30 +0200
In-Reply-To: <20191010152148.gdea35mi7s6ivev6@wittgenstein> (Christian
        Brauner's message of "Thu, 10 Oct 2019 17:21:49 +0200")
Message-ID: <87tv8gmxqh.fsf@oldenburg2.str.redhat.com>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.2 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

* Christian Brauner:

> On Thu, Oct 10, 2019 at 04:19:44PM +0200, Florian Weimer wrote:
>> * Christian Brauner:
>> 
>> > @@ -2567,7 +2572,7 @@ static bool clone3_args_valid(const struct kernel_clone_args *kargs)
>> >  	 * All lower bits of the flag word are taken.
>> >  	 * Verify that no other unknown flags are passed along.
>> >  	 */
>> > -	if (kargs->flags & ~CLONE_LEGACY_FLAGS)
>> > +	if (kargs->flags & ~(CLONE_LEGACY_FLAGS | CLONE3_CLEAR_SIGHAND))
>> >  		return false;
>> 
>> Does the comment need updating?  I feel it's a bit misleading now.
>
> Yeah, maybe just:
>
> /* Verify that no unknown flags are passed along. */
>
> ?

Sure, looks fine to me.

Thanks,
Florian