Received: by 2002:a5b:505:0:0:0:0:0 with SMTP id o5csp2512787ybp; Thu, 10 Oct 2019 08:26:36 -0700 (PDT) X-Google-Smtp-Source: APXvYqziL9jn4s0/Q3L+OY9mC78ssFVfKR17M6sA14hPpJQo3tK4+HfN5eI2t6xSQ3BkwTneoM8V X-Received: by 2002:aa7:c2d7:: with SMTP id m23mr8782016edp.206.1570721196209; Thu, 10 Oct 2019 08:26:36 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1570721196; cv=none; d=google.com; s=arc-20160816; b=UpVFT7Da0iuc77NTGHjhuOAdqlHL7FOryaqr3jr3QKj2B6fpKzCuiEyv47CAvn9mCd YpzqsNEa8SH+XuDUgqn1fj0xgzcyTGW6m2BlMUmQTAsvQc7MNOJ3EM5z6leyOcIEJTsy T8U+qs/u/UPlygvMjfnE3ioYRtDWY55jKSCsnA+ALlmC1VQofBFdfuAVry8jWPCrbm8R p7TIi/8BM2LFa4HUZ4cqh0av1JbGssy9/0OBSnUKEH8qtFc9G7SAVqx6imgOQoMNPEQP JKUlG9X5LYz8wI2HIrSexD6qJtjs+X+bnOue1ksEEY3ev1OAcgfTXx8oj8rZaEW35TE3 k/3Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:dkim-signature; bh=qDz+r4rM94VL3+Pl5xzdTOjfOO1RdD3vAbbm0BQ2hHI=; b=FTlbIiUyT5He/GSuZqeJjzKI7BRl69MzUQFHR1khG+dNOEKimNAS0Yojyqzd0hkbgC qAr8Bt5IaCNq/u55yW8wze9qcfpWgtvITNmF7Re7RWPlLWoIPLW4oP3uAkYpGxlTZ2uz FQf0z/nZrb0pNah4g3563vRuqUGKjqKGnPUPnxewykgRkMp4sENXbjnEMMDe48gwkon9 evAO6tLarvY0aXDe9QQxQUWjwvLF471aWfJlc3oRGWZYUEVxczqfWC+onMRZPHsEK2Si vpUAF4+Kq5drBKBBGZ+FsbwEUZ/VA0iMNMMR2AzBvsIZddH71ItICMZ8uaIzHsDrjSin /vFw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@resnulli-us.20150623.gappssmtp.com header.s=20150623 header.b="AvvoG/Bs"; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id y26si3353216edv.134.2019.10.10.08.26.12; Thu, 10 Oct 2019 08:26:36 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@resnulli-us.20150623.gappssmtp.com header.s=20150623 header.b="AvvoG/Bs"; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726628AbfJJPXL (ORCPT + 99 others); Thu, 10 Oct 2019 11:23:11 -0400 Received: from mail-wm1-f68.google.com ([209.85.128.68]:38030 "EHLO mail-wm1-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726017AbfJJPXL (ORCPT ); Thu, 10 Oct 2019 11:23:11 -0400 Received: by mail-wm1-f68.google.com with SMTP id 3so7236878wmi.3 for ; Thu, 10 Oct 2019 08:23:09 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=resnulli-us.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=qDz+r4rM94VL3+Pl5xzdTOjfOO1RdD3vAbbm0BQ2hHI=; b=AvvoG/BsjH8RyUfVf8qxu9E8+6nBME5ejysBka+LWWdHaophcj951/cLzlbdzoGi7m gncEsje2qdJsbuQDMyUKEsHahQF45XYIBaw/JxHTfMEu7RnUNGZHjp11WFF+ABFIyULU 47f1KrwwzO2d27shcf6fYNMlzt3ATuNEAyRNkBfXmzoth6dN6Kl8MuQJi516+Hwpzq29 7QpTfWmNKyUuVDHQM7fYIg9NQGqLhdIT987WN61jimmIrPHdPndhd669qkd1EdgJQaL6 LpIkZQahdfVwCXWu+TH40v1xgFtVFmdPPgY0EnQvUamqDrwFnkN8xExmOSk4EmoInsme jeuw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=qDz+r4rM94VL3+Pl5xzdTOjfOO1RdD3vAbbm0BQ2hHI=; b=BzVhG7VF+b3eZfL+YvAKhLqKRQWhvKER6pGiA/xsPEfonR/uIg3saoWMRFhyyGHqdP BLR8hulKg/aj995/8M5t+MHQI4wwXdGjKsJNEphg9b6NJxrEbBIffu7Ux6tx4Tv3Gg6v kiP3Y7jpglKY1XBhdeIp+Msf2P+mtGrJ4dSLZrq5n5Db4B8OMtpgDca4pxqbjK4vA0kK UXZKGyzkvcBvg/NIEe6KJDKoNvHZkNnfKoGxFoWG4QPiybKFEGbwa2Gtq1YP7vT1Y5LV 4i5koDLYbZC0PLtv/cKfUwqjV+ctgO2wBKxfaO+gP+fg2MTNZn/uTVfOqGY1LM1tG3n4 YAUw== X-Gm-Message-State: APjAAAUsgsoGIw90JRFwElO8GDZyCTaisQci3ZIgFnPWl5JOPwDuuu71 Lu+fQOJNOEqcwxToSIX1TCRxHw== X-Received: by 2002:a1c:2d85:: with SMTP id t127mr7765333wmt.109.1570720988703; Thu, 10 Oct 2019 08:23:08 -0700 (PDT) Received: from localhost (jirka.pirko.cz. [84.16.102.26]) by smtp.gmail.com with ESMTPSA id e3sm6028321wme.39.2019.10.10.08.23.08 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 10 Oct 2019 08:23:08 -0700 (PDT) Date: Thu, 10 Oct 2019 17:23:07 +0200 From: Jiri Pirko To: Michal Kubecek Cc: David Miller , netdev@vger.kernel.org, Jakub Kicinski , Andrew Lunn , Florian Fainelli , John Linville , Stephen Hemminger , Johannes Berg , linux-kernel@vger.kernel.org Subject: Re: [PATCH net-next v7 09/17] ethtool: generic handlers for GET requests Message-ID: <20191010152307.GA4429@nanopsycho> References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.11.4 (2019-03-13) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Wed, Oct 09, 2019 at 10:59:27PM CEST, mkubecek@suse.cz wrote: [...] >+static const struct get_request_ops *get_requests[__ETHTOOL_MSG_USER_CNT] = { I think that prefix would be good here as well: +static const struct ethnl_get_request_ops * ethnl_get_requests[__ETHTOOL_MSG_USER_CNT] = { [...]