Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
From:   Arnaldo Carvalho de Melo <arnaldo.melo@gmail.com>
Date:   Thu, 10 Oct 2019 13:07:18 -0300
To:     Jiri Olsa <jolsa@redhat.com>
Cc:     Jiri Olsa <jolsa@kernel.org>,
        Alexander Shishkin <alexander.shishkin@linux.intel.com>,
        Michael Petlan <mpetlan@redhat.com>,
        Namhyung Kim <namhyung@kernel.org>,
        Peter Zijlstra <a.p.zijlstra@chello.nl>,
        lkml <linux-kernel@vger.kernel.org>,
        Ingo Molnar <mingo@kernel.org>
Subject: Re: [PATCH 12/36] libperf: Add perf_mmap__read_event() function
Message-ID: <20191010160718.GD11638@kernel.org>
References: <20191007125344.14268-1-jolsa@kernel.org>
 <20191007125344.14268-13-jolsa@kernel.org>
 <20191010144700.GB11638@kernel.org>
 <20191010153232.GA24818@krava>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20191010153232.GA24818@krava>
User-Agent: Mutt/1.12.1 (2019-06-15)
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

Em Thu, Oct 10, 2019 at 05:32:32PM +0200, Jiri Olsa escreveu:
> On Thu, Oct 10, 2019 at 11:47:00AM -0300, Arnaldo Carvalho de Melo wrote:
> 
> SNIP
> 
> > > diff --git a/tools/perf/lib/include/internal/mmap.h b/tools/perf/lib/include/internal/mmap.h
> > > index ee536c4441bb..b328332b6ccf 100644
> > > --- a/tools/perf/lib/include/internal/mmap.h
> > > +++ b/tools/perf/lib/include/internal/mmap.h
> > > @@ -11,6 +11,7 @@
> > >  #define PERF_SAMPLE_MAX_SIZE (1 << 16)
> > >  
> > >  struct perf_mmap;
> > > +union perf_event;
> > 
> > Why are you adding this here?
> 
> oops, it should be in lib/include/perf/mmap.h ;-)
> plz let me know if you want me to repost

I fixed it already, its in acme/tmp.perf/core, will continue later,
possibly will push to Ingo  what I have there if it passes all the
tests, its getting too big a perf/core. :-)

- Arnaldo