Received: by 2002:a5b:505:0:0:0:0:0 with SMTP id o5csp2579140ybp; Thu, 10 Oct 2019 09:23:15 -0700 (PDT) X-Google-Smtp-Source: APXvYqyY8FBk5ZRpUm+qX4EN5ymH1r/PT+CHxM3ti/i6ZNwWCvyr4fyVwSIWJ4jx1avVRo0Zjg1k X-Received: by 2002:a17:906:cc85:: with SMTP id oq5mr8714546ejb.81.1570724595359; Thu, 10 Oct 2019 09:23:15 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1570724595; cv=none; d=google.com; s=arc-20160816; b=esMsQTX03VXwnJc+2G8d/mkcKQMqwAxwwbuFxh0rwtZu1uHvae5goKbVAbcKx5+Pnp GRi1DUw9GgItPwWjOgIUvVVROJ7hdH33YwY5pHnDPysqa0FtLdD3E/JoiV2PY6ss+gf/ CXqUCjsCqvvkhUKkUeXk8I27gXWTKTca51BGEd1d1/R6f6zwTqy6Yb9FDJT3N1I1iQBn FVmwCdwQs4/TinBQhe7hc/mQH6nNqox9I3bH4/61+qlujV1ET4GPXHLTmI+Z8uF9Sgwg TDT88imKkk3QI4G3Yj3b/lWq1YydjftL2tG8o0+uTDPGNzWdl7GDASacI4oMzIj4kU1c 8N/g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date; bh=7C/soh9KWa7q3G/oPCr1eTh0yYWrC4MySKvOHyOtzqc=; b=KN+PbtiOFBsMBP7pWp9Gr9o3hatykkwQ8EaDc+Nym4ACJP3xsHVtDyggsSHN9zvXZM fDlXeyjOHQLWlU6CCIQnOtwlXE+YGJlWRL8PDfXg5uXqLBlIgyl9HT4+OsCJbZhUzfV1 88Nyte08+Ykp2CCOSqAv0cnizPBLFrLyauli6NR2cwPGuodVwKNWiRTFGNTOeooZnnXF bfiJdtA539/c/nTr/DAOC7UjY+YhIaFqbk7H1K2X3ih8dQPlUA1xVDyRtHiFndCc5P0I Y6tYDWCyhmICqvB6oUWCFGUrawrI3+VBB48ufMhu/cG1ttN03hDPsYkqlHUEtXHvtlMm 497w== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=redhat.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id z7si3305205ejr.99.2019.10.10.09.22.49; Thu, 10 Oct 2019 09:23:15 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726453AbfJJQUM (ORCPT + 99 others); Thu, 10 Oct 2019 12:20:12 -0400 Received: from mx1.redhat.com ([209.132.183.28]:60084 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726184AbfJJQUM (ORCPT ); Thu, 10 Oct 2019 12:20:12 -0400 Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 39DF618CB8EB; Thu, 10 Oct 2019 16:20:12 +0000 (UTC) Received: from krava (unknown [10.40.205.67]) by smtp.corp.redhat.com (Postfix) with SMTP id 7B0F26061E; Thu, 10 Oct 2019 16:20:07 +0000 (UTC) Date: Thu, 10 Oct 2019 18:20:06 +0200 From: Jiri Olsa To: Arnaldo Carvalho de Melo Cc: Jiri Olsa , lkml , Ingo Molnar , Namhyung Kim , Alexander Shishkin , Peter Zijlstra , Michael Petlan Subject: Re: [PATCH 27/36] libperf: Add perf_evlist__for_each_mmap function Message-ID: <20191010162006.GA6795@krava> References: <20191007125344.14268-1-jolsa@kernel.org> <20191007125344.14268-28-jolsa@kernel.org> <20191010160622.GC11638@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20191010160622.GC11638@kernel.org> User-Agent: Mutt/1.12.1 (2019-06-15) X-Scanned-By: MIMEDefang 2.79 on 10.5.11.13 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.6.2 (mx1.redhat.com [10.5.110.63]); Thu, 10 Oct 2019 16:20:12 +0000 (UTC) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Oct 10, 2019 at 01:06:22PM -0300, Arnaldo Carvalho de Melo wrote: SNIP > > diff --git a/tools/perf/lib/include/internal/evlist.h b/tools/perf/lib/include/internal/evlist.h > > index be0b25a70730..513a85cb7bfe 100644 > > --- a/tools/perf/lib/include/internal/evlist.h > > +++ b/tools/perf/lib/include/internal/evlist.h > > @@ -25,6 +25,8 @@ struct perf_evlist { > > struct hlist_head heads[PERF_EVLIST__HLIST_SIZE]; > > struct perf_mmap *mmap; > > struct perf_mmap *mmap_ovw; > > + struct perf_mmap *mmap0; > > + struct perf_mmap *mmap_ovw0; > > Why do you use this funny name? Using this "0" suffix? Please pick > something more informative and add a comment on the struct perf_evlist > definiton. it's the first mmap.. I can spell it ;-) > > I've processed up to the previous patch, pushed to acme/tmp.perf/core. great, I'll rebase and continue from there thanks, jirka