Received: by 2002:a5b:505:0:0:0:0:0 with SMTP id o5csp2637543ybp; Thu, 10 Oct 2019 10:14:19 -0700 (PDT) X-Google-Smtp-Source: APXvYqziKKXIlKp0tszmlAxhqhdk6MyMHVWaRxTVzbc64bNd8gaJ8nhvZhBNJ9M76xC/zWOndL+e X-Received: by 2002:aa7:ca52:: with SMTP id j18mr9148453edt.299.1570727659177; Thu, 10 Oct 2019 10:14:19 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1570727659; cv=none; d=google.com; s=arc-20160816; b=gxD8M3zkXj9UVql3nqSwnuzb9eyXK0iagUgvWfaCydJCLn/G/BpbUWhPZsYCllMG1z 7JF27sq0Ac+oGleQ2EmGg+fV4BnpG0i6tdzuIbtm971oimwn6KPnUEAVB677Cl7JbSRq yooAY3NXyeEH71LDnjXe9bbXqXsh1V98NoCplwyejiteMaGyANNmI2yBxjkNWfr16yh2 IBSVVRd7xppYu480V/Qxs72pVifhnPS/A5asWq2NGy5wlU+Uu8VmUAozW54EXYPCW7UN U11yk1V5ThCdMCLVvm+tvTKa4hFzjJ90oXRxZxZydTVRT2xAwI4ZnLqIcJDZ6kY4CgdA FJag== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date; bh=lQQGRLnDmCEI8ravAUIeeJO539fDIWNcI2qfDfS8jKY=; b=YEm49KB8XAVFI9vNRsGsQ0iIOYRXiWqNAo6T5L80d4n61wAWFqyuPLVT06vEkb6gr4 un1mAqBEpfBnU6XFOG9QCea1tAaTto9KJQv0wXUHlLpLJSpYwqcYBgmbwMfxKf/0PUDU 940VPznfNgEIL3YEPYclKvbXlKafPomFVXl8n25dXLdTW4O15KnpshsG8FZU14QkDs2D n7Z5q5ZrNzwfD/E2oCvznyqvESXNoMV8EQfVpjb0uCoQ2uNMUv+5yeQNPfbLsiG+qQUh zH4fAUpDSJBkviN0Urz13aEQWiWTzUAq5kjbZKtrpxayv/jzNJoqiRuUeD9wFthDvABM 9VkQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id b47si3901114edc.45.2019.10.10.10.13.55; Thu, 10 Oct 2019 10:14:19 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726726AbfJJRNM (ORCPT + 99 others); Thu, 10 Oct 2019 13:13:12 -0400 Received: from mx2.suse.de ([195.135.220.15]:47952 "EHLO mx1.suse.de" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1726131AbfJJRNL (ORCPT ); Thu, 10 Oct 2019 13:13:11 -0400 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.220.254]) by mx1.suse.de (Postfix) with ESMTP id C7B03B061; Thu, 10 Oct 2019 17:13:09 +0000 (UTC) Received: by unicorn.suse.cz (Postfix, from userid 1000) id 14DB1E378C; Thu, 10 Oct 2019 19:13:07 +0200 (CEST) Date: Thu, 10 Oct 2019 19:13:07 +0200 From: Michal Kubecek To: netdev@vger.kernel.org Cc: Jiri Pirko , David Miller , Jakub Kicinski , Andrew Lunn , Florian Fainelli , John Linville , Stephen Hemminger , Johannes Berg , linux-kernel@vger.kernel.org Subject: Re: [PATCH net-next v7 05/17] ethtool: helper functions for netlink interface Message-ID: <20191010171307.GC22163@unicorn.suse.cz> References: <061af34c9f34205ed18a126cef9ebe1534de8bc7.1570654310.git.mkubecek@suse.cz> <20191010134203.GA22798@nanopsycho> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20191010134203.GA22798@nanopsycho> User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Oct 10, 2019 at 03:42:03PM +0200, Jiri Pirko wrote: > Wed, Oct 09, 2019 at 10:59:15PM CEST, mkubecek@suse.cz wrote: > > [...] > > > >+/** > >+ * ethnl_parse_header() - parse request header > >+ * @req_info: structure to put results into > >+ * @header: nest attribute with request header > >+ * @net: request netns > >+ * @extack: netlink extack for error reporting > >+ * @policy: netlink attribute policy to validate header; use > >+ * @dflt_header_policy (all attributes allowed) if null > >+ * @require_dev: fail if no device identiified in header > > s/identiified/identified/ Will fix. Michal