Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Thu, 10 Oct 2019 20:05:01 +0200
From:   Michal Kubecek <mkubecek@suse.cz>
To:     netdev@vger.kernel.org
Cc:     Jiri Pirko <jiri@resnulli.us>, David Miller <davem@davemloft.net>,
        Jakub Kicinski <jakub.kicinski@netronome.com>,
        Andrew Lunn <andrew@lunn.ch>,
        Florian Fainelli <f.fainelli@gmail.com>,
        John Linville <linville@tuxdriver.com>,
        Stephen Hemminger <stephen@networkplumber.org>,
        Johannes Berg <johannes@sipsolutions.net>,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH net-next v7 10/17] ethtool: provide string sets with
 STRSET_GET request
Message-ID: <20191010180501.GE22163@unicorn.suse.cz>
References: <cover.1570654310.git.mkubecek@suse.cz>
 <62cb4c137ea6cf675671920de901847d1d083db1.1570654310.git.mkubecek@suse.cz>
 <20191010135917.GK2223@nanopsycho>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20191010135917.GK2223@nanopsycho>
User-Agent: Mutt/1.10.1 (2018-07-13)
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Thu, Oct 10, 2019 at 03:59:17PM +0200, Jiri Pirko wrote:
> Wed, Oct 09, 2019 at 10:59:30PM CEST, mkubecek@suse.cz wrote:
> 
> [...]
> 
> >+const struct get_request_ops strset_request_ops = {
> 
> I think when var is leaving context of single file, it should have
> prefix:
> ethnl_strset_request_ops

OK

Michal