Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Thu, 10 Oct 2019 16:08:11 -0700
From:   Jakub Kicinski <jakub.kicinski@netronome.com>
To:     Anson Huang <Anson.Huang@nxp.com>
Cc:     fugang.duan@nxp.com, davem@davemloft.net,
        gregkh@linuxfoundation.org, andy.shevchenko@gmail.com,
        rafael.j.wysocki@intel.com, swboyd@chromium.org,
        netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
        Linux-imx@nxp.com
Subject: Re: [PATCH 1/2] net: fec_main: Use
 platform_get_irq_byname_optional() to avoid error message
Message-ID: <20191010160811.7775c819@cakuba.netronome.com>
In-Reply-To: <1570616148-11571-1-git-send-email-Anson.Huang@nxp.com>
References: <1570616148-11571-1-git-send-email-Anson.Huang@nxp.com>
Organization: Netronome Systems, Ltd.
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Wed,  9 Oct 2019 18:15:47 +0800, Anson Huang wrote:
> Failed to get irq using name is NOT fatal as driver will use index
> to get irq instead, use platform_get_irq_byname_optional() instead
> of platform_get_irq_byname() to avoid below error message during
> probe:
>=20
> [    0.819312] fec 30be0000.ethernet: IRQ int0 not found
> [    0.824433] fec 30be0000.ethernet: IRQ int1 not found
> [    0.829539] fec 30be0000.ethernet: IRQ int2 not found
>=20
> Fixes: 7723f4c5ecdb ("driver core: platform: Add an error message to plat=
form_get_irq*()")
> Signed-off-by: Anson Huang <Anson.Huang@nxp.com>

Hi Anson,

looks like there may be some dependency which haven't landed in the
networking tree yet?  Because this doesn't build:

drivers/net/ethernet/freescale/fec_main.c: In function =E2=80=98fec_probe=
=E2=80=99:
drivers/net/ethernet/freescale/fec_main.c:3561:9: error: implicit declarati=
on of function =E2=80=98platform_get_irq_byname_optional=E2=80=99; did you =
mean =E2=80=98platform_get_irq_optional=E2=80=99? [-Werror=3Dimplicit-funct=
ion-declaration]
 3561 |   irq =3D platform_get_irq_byname_optional(pdev, irq_name);
      |         ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
      |         platform_get_irq_optional
cc1: some warnings being treated as errors

Could you please repost once that's resolved?  Please add Andy's and
Stephen's acks when reposting.

Thank you!