Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Thu, 10 Oct 2019 17:32:46 -0700
From:   Jakub Kicinski <jakub.kicinski@netronome.com>
To:     Anson Huang <anson.huang@nxp.com>
Cc:     Andy Duan <fugang.duan@nxp.com>,
        "davem@davemloft.net" <davem@davemloft.net>,
        "gregkh@linuxfoundation.org" <gregkh@linuxfoundation.org>,
        "andy.shevchenko@gmail.com" <andy.shevchenko@gmail.com>,
        "rafael.j.wysocki@intel.com" <rafael.j.wysocki@intel.com>,
        "swboyd@chromium.org" <swboyd@chromium.org>,
        "netdev@vger.kernel.org" <netdev@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        dl-linux-imx <linux-imx@nxp.com>
Subject: Re: [PATCH 1/2] net: fec_main: Use
 platform_get_irq_byname_optional() to avoid error message
Message-ID: <20191010173246.2cd02164@cakuba.netronome.com>
In-Reply-To: <DB3PR0402MB3916FF4583577B182D9BF60CF5970@DB3PR0402MB3916.eurprd04.prod.outlook.com>
References: <1570616148-11571-1-git-send-email-Anson.Huang@nxp.com>
        <20191010160811.7775c819@cakuba.netronome.com>
        <DB3PR0402MB3916FF4583577B182D9BF60CF5970@DB3PR0402MB3916.eurprd04.prod.outlook.com>
Organization: Netronome Systems, Ltd.
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Fri, 11 Oct 2019 00:03:22 +0000, Anson Huang wrote:
> > On Wed,  9 Oct 2019 18:15:47 +0800, Anson Huang wrote: =20
> > > Failed to get irq using name is NOT fatal as driver will use index to
> > > get irq instead, use platform_get_irq_byname_optional() instead of
> > > platform_get_irq_byname() to avoid below error message during
> > > probe:
> > >
> > > [    0.819312] fec 30be0000.ethernet: IRQ int0 not found
> > > [    0.824433] fec 30be0000.ethernet: IRQ int1 not found
> > > [    0.829539] fec 30be0000.ethernet: IRQ int2 not found
> > >
> > > Fixes: 7723f4c5ecdb ("driver core: platform: Add an error message to
> > > platform_get_irq*()")
> > > Signed-off-by: Anson Huang <Anson.Huang@nxp.com> =20
> >=20
> > Hi Anson,
> >=20
> > looks like there may be some dependency which haven't landed in the
> > networking tree yet?  Because this doesn't build:
> >=20
> > drivers/net/ethernet/freescale/fec_main.c: In function =E2=80=98fec_pro=
be=E2=80=99:
> > drivers/net/ethernet/freescale/fec_main.c:3561:9: error: implicit decla=
ration
> > of function =E2=80=98platform_get_irq_byname_optional=E2=80=99; did you=
 mean
> > =E2=80=98platform_get_irq_optional=E2=80=99? [-Werror=3Dimplicit-functi=
on-declaration]
> >  3561 |   irq =3D platform_get_irq_byname_optional(pdev, irq_name);
> >       |         ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> >       |         platform_get_irq_optional
> > cc1: some warnings being treated as errors
> >=20
> > Could you please repost once that's resolved?  Please add Andy's and
> > Stephen's acks when reposting.
> >=20
> > Thank you! =20
>=20
> Sorry, I did this patch set based on linux-next tree, the below patch is =
landing
> on Linux-next tree on Oct 5th, so maybe network tree is NOT sync with Lin=
ux-next tree?

linux-next is an integration tree, which merges all development trees
together to help with conflict resolution. Subsystem maintainers never
pull from it.

> I saw many other similar patches are already landing on Linux-next tree a=
lso, so what
> do you suggest I should do? Or can you sync the network tree with Linux-n=
ext tree first? I do
> NOT know the rule/schedule of network tree update to Linux-next.
>=20
> commit f1da567f1dc1b55d178b8f2d0cfe8353858aac19
> Author: Hans de Goede <hdegoede@redhat.com>
> Date:   Sat Oct 5 23:04:47 2019 +0200
>=20
>     driver core: platform: Add platform_get_irq_byname_optional()

Hm. Looks like the commit you need is commit f1da567f1dc1 ("driver core:
platform: Add platform_get_irq_byname_optional()") and it's currently
in Greg's tree. You have to wait for that commit to make its way into
Linus'es main tree and then for Dave Miller to pull from Linus.

I'd suggest you check if your patches builds on the net tree:

  git://git.kernel.org/pub/scm/linux/kernel/git/netdev/net.git

once a week. My guess is it'll probably take two weeks or so for
Greg's patches to propagate to Dave.