Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
IronPort-SDR: OwS5XaTO7yTtJSLBnMg5ZS8QYmO1/lnrverrCWc2R8QlMcbC2GuJJ6XrH47Nor/FTxTdjcINnU
 etoNAYKI2GMDsk5d+pR4i6snD16y/EbA1R3olTBM0yN8orD8xZphllrCgqCx29Yt0q1qv4LmfE
 HhwnLJw7vHYt4aYpA1Huk7gZ56daAiHz9zq8vzaMGB6gMlGYbVSy4a5iTqGMr8e4BoQvc23GCh
 0pUWt0qOygsUgWqh4UeRILaIhAc/p2cfB7iOyPEcz3h/pYZ9w/T7H4hNMu8axrLOpHXzMNuNvZ
 7OM=
IronPort-PHdr: =?us-ascii?q?9a23=3AbrCokhPB9/Tx2QCTb/cl6mtUPXoX/o7sNwtQ0K?=
 =?us-ascii?q?IMzox0LfT+rarrMEGX3/hxlliBBdydt6sfzbSK+Pu9EUU7or+5+EgYd5JNUx?=
 =?us-ascii?q?JXwe43pCcHRPC/NEvgMfTxZDY7FskRHHVs/nW8LFQHUJ2mPw6arXK99yMdFQ?=
 =?us-ascii?q?viPgRpOOv1BpTSj8Oq3Oyu5pHfeQpFiCezbL9oLRi7ogrdu8cWjIB/Nqs/1x?=
 =?us-ascii?q?zFr2dSde9L321oP1WTnxj95se04pFu9jlbtuwi+cBdT6j0Zrw0QrNEAjsoNW?=
 =?us-ascii?q?A1/9DrugLYTQST/HscU34ZnQRODgPY8Rz1RJbxsi/9tupgxCmXOND9QL4oVT?=
 =?us-ascii?q?i+6apgVQTlgzkbOTEn7G7Xi9RwjKNFrxKnuxx/2JPfbIWMOPZjYq/RYdYWSG?=
 =?us-ascii?q?xcVchTSiNBGJuxYIQBD+UDPehWoYrzqUYQoxSiHgSsGP/jxyVUinPqwaE30e?=
 =?us-ascii?q?IsGhzG0gw6GNIOtWzZo9f0NKYTUeC10a7IxijAYPNWwzj96ZXDfxchoPCNXb?=
 =?us-ascii?q?J/a8vRxVUzGw7LlViQtJDqPymP2usTrmeb8vNtWOSygGAkswF8uiajytsoh4?=
 =?us-ascii?q?XThY8YykrI+TtlzIs2P9G0VUp2bN2iHZBNrS+VLZF2TdknQ2xwvSY6zaAJto?=
 =?us-ascii?q?CjcSgRzZQn2wbfa/uac4iU+h7jVPieITN/hH99fbKwnRey8Uy5xu34VMm4zU?=
 =?us-ascii?q?9GriRYntTItX0BzRPT6s+ASvty+keuxyyD2BzU6uFBOUw0lKzbJIA9wrMoiJ?=
 =?us-ascii?q?YfrUDOEjX1lUj2lqOaaFko9+uy5+j6ZrjrpYeQN4puhQH/NqQulNa/AeM9Mg?=
 =?us-ascii?q?UWX2ma+OS826fi/UHlXLlHgOY7krTFv5DAP8gUuLO2AxJN3oY59xm/Fyum0M?=
 =?us-ascii?q?gfnXQfKFJFeRSHj5XmOl3XI/D3E+2/g1Kynzdv3P3GILLhDYvXLnTZk7fuY6?=
 =?us-ascii?q?x960hCxwo319xf4IhUCr5SaM70D2P4spTzBwUhPgqozvyvXNl00MUVUHiXD6?=
 =?us-ascii?q?mFPbn6tkWB7eYiZeKLYdlGliz6Lq0U5uzukHhxq18UfOH9zIkXYXHgRq9OPk?=
 =?us-ascii?q?6DJ3fgn4FSQi8xogMiQbmy2xW5WjlJaiP3Bvpk6w=3D=3D?=
MIME-Version: 1.0
References: <20191010043809.27594-1-yzhai003@ucr.edu> <20191010091834.GG20470@kadam>
In-Reply-To: <20191010091834.GG20470@kadam>
From:   Yizhuo Zhai <yzhai003@ucr.edu>
Date:   Thu, 10 Oct 2019 17:37:56 -0700
Message-ID: <CABvMjLQ+_rRJT_yeKE9AKJaxhSU5LbcZdenbOr8CdPoD+4Oprw@mail.gmail.com>
Subject: Re: [PATCH] staging: sm750fb: Potential uninitialized field in "pll"
To:     Dan Carpenter <dan.carpenter@oracle.com>
Cc:     devel@driverdev.osuosl.org, linux-fbdev@vger.kernel.org,
        Teddy Wang <teddy.wang@siliconmotion.com>,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        linux-kernel@vger.kernel.org,
        Sudip Mukherjee <sudipm.mukherjee@gmail.com>
Content-Type: text/plain; charset="UTF-8"
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

Sorry about that, let me resend it .

On Thu, Oct 10, 2019 at 2:53 AM Dan Carpenter <dan.carpenter@oracle.com> wrote:
>
> On Wed, Oct 09, 2019 at 09:38:08PM -0700, Yizhuo wrote:
> > Inside function set_chip_clock(), struct pll is supposed to be
> > initialized in sm750_calc_pll_value(), if condition
> > "diff < mini_diff" in sm750_calc_pll_value() cannot be fulfilled,
> > then some field of pll will not be initialized but used in
> > function sm750_format_pll_reg(), which is potentially unsafe.
> >
> > Signed-off-by: Yizhuo <yzhai003@ucr.edu>
>
> The patch is correct, but it doesn't apply to linux-next any more.  Can
> you re-write it on top of the most recent staging-next and resend?
>
> regards,
> dan carpenter
>


-- 
Kind Regards,

Yizhuo Zhai

Computer Science, Graduate Student
University of California, Riverside