Received: by 2002:a5b:505:0:0:0:0:0 with SMTP id o5csp429125ybp; Thu, 10 Oct 2019 21:30:27 -0700 (PDT) X-Google-Smtp-Source: APXvYqyDUZRMFRbxMx/R/0GJ5gqKSoHjLNjvl1RK7Ow8jw1KtJHNXsS+UAXBjHO8+Kp/kvKBLdyK X-Received: by 2002:a05:6402:88d:: with SMTP id e13mr11297966edy.246.1570768227303; Thu, 10 Oct 2019 21:30:27 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1570768227; cv=none; d=google.com; s=arc-20160816; b=yUdv/Zn6ZoGNB/kxHsg9zwTzXtNy0RmmDa6mNr51OYCyDMXam7TrcoR87aU/jPOXHl 9zkZ1huKM37X7ag32/ex2iKE34xzDG4JAyveqDVZ0CqzCmP1dT8Nrlu5hhILKqGuU8E7 XLxwxJO6c2NEkDYEx16ekQg9rBfE1dQwjZmB6j0t9fC3j/GLM/kJ2JWEqUlZXFJR1YgN 6pw9JCW0T4Qr4VuhknEZPrBsiNdrzh7POykS9N27wFdVNCZg2TktFmKK9tN2RDp2s4Ni qokXzpGfk5JMyEC9XwOBx4d2N29+YSn8n185BSsv4o+8XgmUUSXkT33WAZtt/4MbeHjf f1jw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:dkim-signature; bh=53WspmNtKvZNOCztT/ZGFypJIXV1cjttZlHwRD4VRVg=; b=OD3OfQPylT0aEMNx54bjw3TSegKu5ptAUAGxuV2iM6AaA4BGyiUEiy9KsCBTzpZuOC YKT40At/BVjy7E4HBfdxUUIuYYBh+mKNF5xJ3ZqguEYG0kF9WBOHnQIY3Jye4gLdFreJ M/bx8ag9y2VovxSdytbdDOItuKbMqeD1haef6nSvF02Apr0xwkxUzr+sgBZUtDF4K83Z qUNIIBGOHhO4hflalyzSakaoVBfP7lGQrzdBtKVNF20cWlSKpV2A4I9SSq2X8+R4bulG /Z789f8WChxwhJote5BA/pmDq+y4qxllGsdNB5aZHzr59/DeKVqbbgx3hjxVAdrFdFxH zdiQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=QQ6aVrxk; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id o22si4511075ejb.285.2019.10.10.21.29.58; Thu, 10 Oct 2019 21:30:27 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=QQ6aVrxk; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726331AbfJKE0M (ORCPT + 99 others); Fri, 11 Oct 2019 00:26:12 -0400 Received: from mail.kernel.org ([198.145.29.99]:51388 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726108AbfJKE0M (ORCPT ); Fri, 11 Oct 2019 00:26:12 -0400 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 07B412089F; Fri, 11 Oct 2019 04:26:10 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1570767971; bh=fLiBWE1AVc2vUnCDGC3rnCQZQF7qVTkQq7Q21C84Zlc=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=QQ6aVrxkEqC6BdoJ9p8nXAqQQzWCiL0yOUAQeFLNMMuz4r2WpwTy60CZDaQ3NraAl HLMSy4qCboDujx+wdD52j5aHnH1R3oVK+W2kqQ7QIfgKRox0cMPYLpf60CZ4efPkyj obpXc5i1c9XrEnDV4HIOjrNn5sH8Ji4ZLBXZX+vE= Date: Fri, 11 Oct 2019 06:26:09 +0200 From: Greg KH To: zhong jiang Cc: jerome.pouiller@silabs.com, linux-kernel@vger.kernel.org Subject: Re: [PATCH] staging: wfx: fix an undefined reference error when CONFIG_MMC=m Message-ID: <20191011042609.GB938845@kroah.com> References: <1570762939-8735-1-git-send-email-zhongjiang@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1570762939-8735-1-git-send-email-zhongjiang@huawei.com> User-Agent: Mutt/1.12.2 (2019-09-21) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Oct 11, 2019 at 11:02:19AM +0800, zhong jiang wrote: > I hit the following error when compile the kernel. > > drivers/staging/wfx/main.o: In function `wfx_core_init': > /home/z00352263/linux-next/linux-next/drivers/staging/wfx/main.c:488: undefined reference to `sdio_register_driver' > drivers/staging/wfx/main.o: In function `wfx_core_exit': > /home/z00352263/linux-next/linux-next/drivers/staging/wfx/main.c:496: undefined reference to `sdio_unregister_driver' > drivers/staging/wfx/main.o:(.debug_addr+0x1a8): undefined reference to `sdio_register_driver' > drivers/staging/wfx/main.o:(.debug_addr+0x6f0): undefined reference to `sdio_unregister_driver' > > Signed-off-by: zhong jiang > --- > drivers/staging/wfx/Kconfig | 3 ++- > drivers/staging/wfx/Makefile | 5 +++-- > 2 files changed, 5 insertions(+), 3 deletions(-) > > diff --git a/drivers/staging/wfx/Kconfig b/drivers/staging/wfx/Kconfig > index 9b8a1c7..4d045513 100644 > --- a/drivers/staging/wfx/Kconfig > +++ b/drivers/staging/wfx/Kconfig > @@ -1,7 +1,8 @@ > config WFX > tristate "Silicon Labs wireless chips WF200 and further" > depends on MAC80211 > - depends on (SPI || MMC) > + depends on SPI > + select MMC How about: depends on (SPI && MMC) instead? thanks, greg k-h