Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
IronPort-SDR: pRaU1Cw/GqJrhGsgYxNyaQfngDOMhmJQ8tAHAsxXzWq2CrkmW84W8YZZIbgVxOtzzAluTJRHf9
 wCrX4I9UB2YY+B6L2RIdnp08DpB9rFeANUG3Ee+9msH8WXLsYazgMijrhdAaz0+GgKjGm6h0sl
 kkB5s4zcTMj5IIfA7LMHZ/LRGsxQtuyxZgSdI0/XVY5sp72TlrnKRFLdap+8lasl9xuiusN4PU
 nPv4ESLX/S4exZie2xsXF00tDATLuu8qnjrrp+0wpjJW8a0VQbd++Hxp1FrRsj9FlaMzsjcDYd
 1XY=
IronPort-PHdr: =?us-ascii?q?9a23=3AAv4DhBVuUWP6HgERsjnwtOG1AM/V8LGtZVwlr6?=
 =?us-ascii?q?E/grcLSJyIuqrYYxyFt8tkgFKBZ4jH8fUM07OQ7/m7HzJcqsfc+Fk5M7V0Hy?=
 =?us-ascii?q?cfjssXmwFySOWkMmbcaMDQUiohAc5ZX0Vk9XzoeWJcGcL5ekGA6ibqtW1aFR?=
 =?us-ascii?q?rwLxd6KfroEYDOkcu3y/qy+5rOaAlUmTaxe7x/IAi4oAnLt8QbjoRuJ6Ixxx?=
 =?us-ascii?q?DUvnZGZuNayH9yK1mOhRj8/MCw/JBi8yRUpf0s8tNLXLv5caolU7FWFSwqPG?=
 =?us-ascii?q?8p6sLlsxnDVhaP6WAHUmoKiBpIAhPK4w/8U5zsryb1rOt92C2dPc3rUbA5XC?=
 =?us-ascii?q?mp4ql3RBP0jioMKiU0+3/LhMNukK1boQqhpx1hzI7SfIGVL+d1cqfEcd8HWW?=
 =?us-ascii?q?ZNQsNdWipcCY2+coQPFfIMMulWr4b/p1UAoxiwCxSyCuzz0TJImmP60Lcm3+?=
 =?us-ascii?q?g9DQ3L3gotFM8OvnTOq9X1Mb8fXuK0zKjJzTXDcvRW0ir+54jIaB8hoOyHUL?=
 =?us-ascii?q?VwcMvQyUkgDQLFgkmMpYHrJD6Vy/gCs3KB4+V+SO2vlncqpgdsqTas3schkp?=
 =?us-ascii?q?fFip4Rx1ze9ih0wJw5KcOkREN4e9KoDodcuz2cOoBrWM0tWXtotzw/yrAevJ?=
 =?us-ascii?q?67ezUFx4o/yh7EbvyHb5CI4hX+VOaNOTt4hGxqeLa4hxuq9Eiv0Oz8Vs2t3F?=
 =?us-ascii?q?ZOrCpJj8DAtn4T2xDP9sSLUPR9/kCm2TaA0wDc9PtILlwzlareM5Ihw7gwmY?=
 =?us-ascii?q?QPsUnbACP6hEH7gLWVe0gk4OSk9fjrb7b8qpOCK4N4lhnyMqE0lcy+BeQ4PB?=
 =?us-ascii?q?IOX2+e+emk1Lzi/E35T69LjvEqjqXUvovXJdkHqa6jGQNazJss6wunAze8zN?=
 =?us-ascii?q?sYhWUHLE5CeB+fi4jpOlfOIO33DPumgFSjji1rx/bYMb3lGZjNMHfDn6n7fb?=
 =?us-ascii?q?pn6E5T1hAzzdZB6JJQEL0BJ+jzWkCi/ODfWzIjMgf87/viAcdwystKVHiOCe?=
 =?us-ascii?q?mVLabbo1KUzu0qKuiIIoQSvWCuBeIi4qvfjG05hFhVT6mg3NNDeWK4F/U+ex?=
 =?us-ascii?q?6xfHH2xNoNDDFZ7UIFUOX2hQjaAnZobHGoUvd5v2ljBQ=3D=3D?=
MIME-Version: 1.0
References: <CABvMjLToYzmCue-TiDhR4Yu4v3+Z+-UV9WhixV7uvwoMh2m5Lw@mail.gmail.com>
 <f3ce1620-c421-b41f-440b-efe3ff6e91fe@gmail.com>
In-Reply-To: <f3ce1620-c421-b41f-440b-efe3ff6e91fe@gmail.com>
From:   Yizhuo Zhai <yzhai003@ucr.edu>
Date:   Thu, 10 Oct 2019 22:31:28 -0700
Message-ID: <CABvMjLTrGprdgFTP-+2XC_p+vE+tVWeYvyuLGkKj1dY7KR+JDg@mail.gmail.com>
Subject: Re: Potential NULL pointer deference in spi
To:     Eric Dumazet <eric.dumazet@gmail.com>
Cc:     Mark Brown <broonie@kernel.org>, linux-spi@vger.kernel.org,
        linux-kernel@vger.kernel.org, Zhiyun Qian <zhiyunq@cs.ucr.edu>,
        Chengyu Song <csong@cs.ucr.edu>
Content-Type: text/plain; charset="UTF-8"
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

Hi Eric:

My apologies for bothering, we got those report via static analysis
and haven't got a good method to verify the path to trigger them.
Therefore I sent those email to you maintainers first since you
know much better about the details. Sorry again for your time and
I take your suggestions.

On Wed, Oct 9, 2019 at 10:48 PM Eric Dumazet <eric.dumazet@gmail.com> wrote:
>
>
>
> On 10/9/19 10:37 PM, Yizhuo Zhai wrote:
> > Hi All:
> >
> > drivers/spi/spi.c:
> >
> > The function to_spi_device() could return NULL, but some callers
> > in this file does not check the return value while directly dereference
> > it, which seems potentially unsafe.
> >
> > Such callers include spidev_release(),  spi_dev_check(),
> > driver_override_store(), etc.
> >
> >
>
>
> Many of your reports are completely bogus.
>
> I suggest you spend more time before sending such emails to very large audience
> and risk being ignored at some point.
>
> Thanks.


-- 
Kind Regards,

Yizhuo Zhai

Computer Science, Graduate Student
University of California, Riverside