Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
From:   Peter Chen <peter.chen@nxp.com>
To:     Igor Opaniuk <igor.opaniuk@gmail.com>
CC:     "linux-usb@vger.kernel.org" <linux-usb@vger.kernel.org>,
        Marcel Ziswiler <marcel.ziswiler@toradex.com>,
        Philippe Schenker <philippe.schenker@toradex.com>,
        Stefan Agner <stefan.agner@toradex.com>,
        Max Krummenacher <max.krummenacher@toradex.com>,
        Oleksandr Suvorov <oleksandr.suvorov@toradex.com>,
        Jun Li <jun.li@nxp.com>,
        Igor Opaniuk <igor.opaniuk@toradex.com>,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v2 2/3] usb: chipidea: set mode for usb phy driver
Thread-Topic: [PATCH v2 2/3] usb: chipidea: set mode for usb phy driver
Thread-Index: AQHVf3Kguafv1B6mvkqZ25XYUmZVPKdU8I0A
Date:   Fri, 11 Oct 2019 05:50:35 +0000
Message-ID: <20191011055002.GD4774@b29397-desktop>
References: <20191010135656.3264-1-igor.opaniuk@gmail.com>
 <20191010135656.3264-2-igor.opaniuk@gmail.com>
In-Reply-To: <20191010135656.3264-2-igor.opaniuk@gmail.com>
Accept-Language: en-US
Content-Language: en-US
received-spf: None (protection.outlook.com: nxp.com does not designate
 permitted sender hosts)
Content-Type: text/plain; charset="us-ascii"
Content-ID: <FF9446BFCB88624A959B7FBB8156D189@eurprd04.prod.outlook.com>
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-Network-Message-Id: b77d2de3-4511-4b15-29bd-08d74e0eef8f
X-MS-Exchange-CrossTenant-originalarrivaltime: 11 Oct 2019 05:50:35.1020
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: y6CMRewsFhwesxC3a6gZ3MdSlKooC7mAeKcSQnCfxMSf9B5HZmlXV4HCtK8uLWuowcjiLpPThThqc6BU+jbYuw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM0PR04MB4754
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 19-10-10 16:56:55, Igor Opaniuk wrote:
> From: Li Jun <jun.li@nxp.com>
>=20
> After enters one specific role, notify usb phy driver.
>=20
> Signed-off-by: Li Jun <jun.li@nxp.com>
> Signed-off-by: Igor Opaniuk <igor.opaniuk@toradex.com>
> ---
>=20
> v2:
> - restored original commit author
> - fixed build for multi_v7
>=20
>  drivers/usb/chipidea/ci.h | 21 ++++++++++++++++++---
>  1 file changed, 18 insertions(+), 3 deletions(-)
>=20
> diff --git a/drivers/usb/chipidea/ci.h b/drivers/usb/chipidea/ci.h
> index 6911aef500e9..cf9cc9402826 100644
> --- a/drivers/usb/chipidea/ci.h
> +++ b/drivers/usb/chipidea/ci.h
> @@ -275,9 +275,21 @@ static inline int ci_role_start(struct ci_hdrc *ci, =
enum ci_role role)
>  		return -ENXIO;
> =20
>  	ret =3D ci->roles[role]->start(ci);
> -	if (!ret)
> -		ci->role =3D role;
> -	return ret;
> +	if (ret)
> +		return ret;
> +
> +	ci->role =3D role;
> +
> +	if (ci->usb_phy) {
> +		if (role =3D=3D CI_ROLE_HOST)
> +			usb_phy_set_mode(ci->usb_phy,
> +					USB_CURRENT_MODE_HOST);
> +		else
> +			usb_phy_set_mode(ci->usb_phy,
> +					USB_CURRENT_MODE_DEVICE);
> +	}
> +
> +	return 0;
>  }
> =20
>  static inline void ci_role_stop(struct ci_hdrc *ci)
> @@ -290,6 +302,9 @@ static inline void ci_role_stop(struct ci_hdrc *ci)
>  	ci->role =3D CI_ROLE_END;
> =20
>  	ci->roles[role]->stop(ci);
> +
> +	if (ci->usb_phy)
> +		usb_phy_set_mode(ci->usb_phy, USB_CURRENT_MODE_NONE);
>  }
> =20
>  static inline enum usb_role ci_role_to_usb_role(struct ci_hdrc *ci)
> --=20

For chipidea part:

Acked-by: Peter Chen <peter.chen@nxp.com>

--=20

Thanks,
Peter Chen=