Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Subject: Re: [PATCH v2] drm: bridge: adv7511: Enable SPDIF DAI
To:     Bogdan Togorean <bogdan.togorean@analog.com>,
        dri-devel@lists.freedesktop.org
Cc:     airlied@linux.ie, daniel@ffwll.ch, narmstrong@baylibre.com,
        Laurent.pinchart@ideasonboard.com, jonas@kwiboo.se,
        jernej.skrabec@siol.net, allison@lohutok.net, tglx@linutronix.de,
        rfontana@redhat.com, linux-kernel@vger.kernel.org
From:   Andrzej Hajda <a.hajda@samsung.com>
Message-ID: <b3ab3f90-6657-a58b-e022-c23d0e412d27@samsung.com>
Date:   Fri, 11 Oct 2019 09:33:54 +0200
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101
        Thunderbird/60.9.0
MIME-Version: 1.0
In-Reply-To: <20191007100641.25599-1-bogdan.togorean@analog.com>
Content-Transfer-Encoding: 8bit
Content-Language: en-US
Content-Type: text/plain; charset="utf-8"
CMS-TYPE: 201P
References: <CGME20191007100945epcas2p15319b2e323c67b9ed8a5a4f56f5f7e7a@epcas2p1.samsung.com>
        <20191007100641.25599-1-bogdan.togorean@analog.com>
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On 07.10.2019 12:06, Bogdan Togorean wrote:
> ADV7511 support I2S or SPDIF as audio input interfaces. This commit
> enable support for SPDIF.
>
> Signed-off-by: Bogdan Togorean <bogdan.togorean@analog.com>


Reviewed-by: Andrzej Hajda <a.hajda@samsung.com>


Let's wait few days with queuing, with hope somebody will test it.


 --
Regards
Andrzej


> ---
>
> Changes in v2:
> - add forgotten break statement
>
>  drivers/gpu/drm/bridge/adv7511/adv7511_audio.c | 14 ++++++++++++++
>  1 file changed, 14 insertions(+)
>
> diff --git a/drivers/gpu/drm/bridge/adv7511/adv7511_audio.c b/drivers/gpu/drm/bridge/adv7511/adv7511_audio.c
> index a428185be2c1..1e9b128d229b 100644
> --- a/drivers/gpu/drm/bridge/adv7511/adv7511_audio.c
> +++ b/drivers/gpu/drm/bridge/adv7511/adv7511_audio.c
> @@ -119,6 +119,9 @@ int adv7511_hdmi_hw_params(struct device *dev, void *data,
>  		audio_source = ADV7511_AUDIO_SOURCE_I2S;
>  		i2s_format = ADV7511_I2S_FORMAT_LEFT_J;
>  		break;
> +	case HDMI_SPDIF:
> +		audio_source = ADV7511_AUDIO_SOURCE_SPDIF;
> +		break;
>  	default:
>  		return -EINVAL;
>  	}
> @@ -175,11 +178,21 @@ static int audio_startup(struct device *dev, void *data)
>  	/* use Audio infoframe updated info */
>  	regmap_update_bits(adv7511->regmap, ADV7511_REG_GC(1),
>  				BIT(5), 0);
> +	/* enable SPDIF receiver */
> +	if (adv7511->audio_source == ADV7511_AUDIO_SOURCE_SPDIF)
> +		regmap_update_bits(adv7511->regmap, ADV7511_REG_AUDIO_CONFIG,
> +				   BIT(7), BIT(7));
> +
>  	return 0;
>  }
>  
>  static void audio_shutdown(struct device *dev, void *data)
>  {
> +	struct adv7511 *adv7511 = dev_get_drvdata(dev);
> +
> +	if (adv7511->audio_source == ADV7511_AUDIO_SOURCE_SPDIF)
> +		regmap_update_bits(adv7511->regmap, ADV7511_REG_AUDIO_CONFIG,
> +				   BIT(7), 0);
>  }
>  
>  static int adv7511_hdmi_i2s_get_dai_id(struct snd_soc_component *component,
> @@ -213,6 +226,7 @@ static const struct hdmi_codec_pdata codec_data = {
>  	.ops = &adv7511_codec_ops,
>  	.max_i2s_channels = 2,
>  	.i2s = 1,
> +	.spdif = 1,
>  };
>  
>  int adv7511_audio_init(struct device *dev, struct adv7511 *adv7511)