Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
From:   Jerome Pouiller <Jerome.Pouiller@silabs.com>
To:     Greg KH <gregkh@linuxfoundation.org>
CC:     zhong jiang <zhongjiang@huawei.com>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] staging: wfx: fix an undefined reference error when
 CONFIG_MMC=m
Thread-Topic: [PATCH] staging: wfx: fix an undefined reference error when
 CONFIG_MMC=m
Thread-Index: AQHVf+DaxlKENNqV0UK69LaFcVpmvadU2EGAgABG9AA=
Date:   Fri, 11 Oct 2019 08:40:08 +0000
Message-ID: <3864047.FfxYVOUlJ1@pc-42>
References: <1570762939-8735-1-git-send-email-zhongjiang@huawei.com>
 <20191011042609.GB938845@kroah.com>
In-Reply-To: <20191011042609.GB938845@kroah.com>
Accept-Language: en-US
Content-Language: en-US
received-spf: None (protection.outlook.com: silabs.com does not designate
 permitted sender hosts)
Content-Type: text/plain; charset="iso-8859-1"
Content-ID: <F73D7F8B23800F48BE574A21484DD401@namprd11.prod.outlook.com>
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-Network-Message-Id: 606cc717-78d8-4fa5-8f65-08d74e269f5a
X-MS-Exchange-CrossTenant-originalarrivaltime: 11 Oct 2019 08:40:08.3781
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 54dbd822-5231-4b20-944d-6f4abcd541fb
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: SZfmHcqjiuWxKSjwkA++topHRDUAkvyTb9bD4KtqR4gM7X6/NJ22uWhROcDsk0KZl276BU49IHGRi6migMpEpQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN2PR11MB4510
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Friday 11 October 2019 06:26:16 CEST Greg KH wrote:
> CAUTION: This email originated from outside of the organization. Do not=20
click links or open attachments unless you recognize the sender and know th=
e=20
content is safe.
>=20
>=20
> On Fri, Oct 11, 2019 at 11:02:19AM +0800, zhong jiang wrote:
> > I hit the following error when compile the kernel.
> >
> > drivers/staging/wfx/main.o: In function `wfx_core_init':
> > /home/z00352263/linux-next/linux-next/drivers/staging/wfx/main.c:488:=20
undefined reference to `sdio_register_driver'
> > drivers/staging/wfx/main.o: In function `wfx_core_exit':
> > /home/z00352263/linux-next/linux-next/drivers/staging/wfx/main.c:496:=20
undefined reference to `sdio_unregister_driver'
> > drivers/staging/wfx/main.o:(.debug_addr+0x1a8): undefined reference to=
=20
`sdio_register_driver'
> > drivers/staging/wfx/main.o:(.debug_addr+0x6f0): undefined reference to=
=20
`sdio_unregister_driver'
> >
> > Signed-off-by: zhong jiang <zhongjiang@huawei.com>
> > ---
> >  drivers/staging/wfx/Kconfig  | 3 ++-
> >  drivers/staging/wfx/Makefile | 5 +++--
> >  2 files changed, 5 insertions(+), 3 deletions(-)
> >
> > diff --git a/drivers/staging/wfx/Kconfig b/drivers/staging/wfx/Kconfig
> > index 9b8a1c7..4d045513 100644
> > --- a/drivers/staging/wfx/Kconfig
> > +++ b/drivers/staging/wfx/Kconfig
> > @@ -1,7 +1,8 @@
> >  config WFX
> >       tristate "Silicon Labs wireless chips WF200 and further"
> >       depends on MAC80211
> > -     depends on (SPI || MMC)
> > +     depends on SPI
> > +     select MMC
>=20
> How about:
>         depends on (SPI && MMC)

I dislike to force user to enable both buses while only one of them is=20
sufficient. I would prefer to keep current dependencies and to add
#ifdef around problematic functions.

(I though I had a test of compilation w/o MMC nor SPI, but I realize
that it did not work)


--=20
J=E9r=F4me Pouiller