Received: by 2002:a5b:505:0:0:0:0:0 with SMTP id o5csp639491ybp; Fri, 11 Oct 2019 01:50:22 -0700 (PDT) X-Google-Smtp-Source: APXvYqzgZzuH8zI/x1G8kV5csQQwBdjCbeZaUdHJUP2nsxgu8bwzQOAKJPC5rqyjwvT3wuZzUnc7 X-Received: by 2002:aa7:d045:: with SMTP id n5mr12365596edo.24.1570783822043; Fri, 11 Oct 2019 01:50:22 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1570783822; cv=none; d=google.com; s=arc-20160816; b=vralU9ZUl1ygxIuEyOenw2i1ea8AIS7iYfqwxuwsBITmNYM1S+DPCBnhkgCdv6dUnz ZEN7XzW9bcbzE37KrTqboQm5V+JWQu7hv2pdNB3yzPnvM8GeBltck59HY3KG8HOR1fDD gnXQXRstop7DHcBC/68qlOSbKrrig1JJrdWetAKQE9Ud8kkNfNJbVTvVMQqrkb0m7UJA C16wzkDlHnzZnqLss74jjNj+/7ixL4fULTfm0KWIy3MYpU8c7Li5b3h6ge61hfBObO3w +5M5Qr0Uc4DPwdEPx0bqijrNpv9JNM8sHpWvOjw6L+pJ4QvZswzlSy9r3Kz92y9Pr27v JtGg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:dkim-signature; bh=ZE64hLgDWtbp5oSPHrZjFkaTZsSqEnl+J/6l+xL0R68=; b=ozQ1yExOrc8oA3C1zcVl/9yzshlGxRu5wd9ajQ+V5o2A3pv2wyA8LyOCEAR62cnLrQ tIGESbI7crk8f3Q7OBcmH2smfvzhdPbBZHqKtUR7Llt83kWkzq55M/H8sIzDLsufM2fJ hb/JtTd+ZoqNf5iTpX7lw90UiayZiZueRrcXr+VL8jH98KD4H7mGYVHCmjR2BMUGZWcr 8cC9cgaL+qONEdQ48px+oCbw3j5v/S0RhAX6kN8JOUEO6GbqVDuW48dHRhLuh2INHUE5 IRu1Rs2ie+SuW2UFLkJdSepDvlGy3j8APKkvliiYNO62t1FfzADvRm40mcW9iHkAnRco QLFg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=ZzwLeD8A; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id p15si5121394eda.294.2019.10.11.01.49.58; Fri, 11 Oct 2019 01:50:22 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=ZzwLeD8A; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727460AbfJKIsx (ORCPT + 99 others); Fri, 11 Oct 2019 04:48:53 -0400 Received: from mail-pf1-f195.google.com ([209.85.210.195]:41058 "EHLO mail-pf1-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726310AbfJKIsw (ORCPT ); Fri, 11 Oct 2019 04:48:52 -0400 Received: by mail-pf1-f195.google.com with SMTP id q7so5669487pfh.8; Fri, 11 Oct 2019 01:48:52 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=ZE64hLgDWtbp5oSPHrZjFkaTZsSqEnl+J/6l+xL0R68=; b=ZzwLeD8APeW7v7gmHQ4brO/MpKDK5jv5GzZp6zGocmM93eqzhIhS5shfEp+tlUwmLd rDQF7RURyjqfi/ExjsSKGrkJ+209sPYbo1cajBUsWOZoDxOpCZC3uVi0iUtLcVo79ntG FPgUjHavDuw9h/AliOkJCDoVBRplw1WS0w/M3F2G0vJ1FipWWe41baGRMXpL0ODGzwrD CfemUW1YOmfmDLz9zM6PVQ9J0AKXpudfSrVxZ6G+XfpmzNnkzbzXPtbb0EnwiQM5lYgD 7lDb9PDx0OqUy+x6SeakcN+U17CS8xYpdK/sbHYVAzxhNYp5Q/KyeuyWRrnCki7Mdcyb Wzuw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=ZE64hLgDWtbp5oSPHrZjFkaTZsSqEnl+J/6l+xL0R68=; b=ESoCszE7wsxfRIqUTpfV16KiNmSFFPCl0YODGh4BK6+3ohfjW8X6JkR+HaxMy7IHb1 TJs5kz9MR0IFk3z7xk8hPFhdmC76k/g7aLiQlsJ+4O5ZwMVWAXJPWj8QF40uPRs+O/m7 IL8yAkaj8LVvVnOKH52QhF/uxkbHiVjVmSyNwWBUJLkFTtMaf3d+2TFCg3mUXf9l0K3G vEm5Es1blKc1VSJ6Pf78k2pwfF/myMb970Wpo/P3ZhjO4pWgsJL4MUX/cIcESy0nvPLF AVgALJ+F0J/pWpVute7w8X7RAxlaB3K64YW3M8qdekji4peBOHPTf0a7R5Apb+dwFD+B JyfA== X-Gm-Message-State: APjAAAXKMa7IewTCmIvrUumxIJwh3fWEjq4LeHytf403lzO4YhqPh84J 4F9OhawKIBUY1hju6qK2/rnBxdZGJtUKJmEg+jQ= X-Received: by 2002:a63:d0a:: with SMTP id c10mr13786067pgl.203.1570783731894; Fri, 11 Oct 2019 01:48:51 -0700 (PDT) MIME-Version: 1.0 References: <20191009200523.8436-1-stuart.w.hayes@gmail.com> <20191009200523.8436-3-stuart.w.hayes@gmail.com> In-Reply-To: From: Andy Shevchenko Date: Fri, 11 Oct 2019 11:48:41 +0300 Message-ID: Subject: Re: [PATCH 2/3] PCI: pciehp: Wait for PDS if in-band presence is disabled To: Stuart Hayes Cc: Bjorn Helgaas , Austin Bolen , Keith Busch , Alexandru Gagniuc , "Rafael J . Wysocki" , Mika Westerberg , "Gustavo A . R . Silva" , Sinan Kaya , Oza Pawandeep , linux-pci@vger.kernel.org, Linux Kernel Mailing List , Lukas Wunner Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Oct 11, 2019 at 9:49 AM Andy Shevchenko wrote: > > On Thu, Oct 10, 2019 at 11:37 PM Stuart Hayes wrote: > > > Thank you for the feedback! An infinite loop is used several other places in > > this driver--this keeps the style similar. I can change it as you suggest, > > though, if that would be preferable to consistency. > > Better to start the change now. I'll look into the file and see how we > can improve the rest. I found only one infinite loop there, the other timeout loop is done as do {} while. I'll send a patch to refactor the infinite one. -- With Best Regards, Andy Shevchenko