Received: by 2002:a5b:505:0:0:0:0:0 with SMTP id o5csp658772ybp; Fri, 11 Oct 2019 02:11:59 -0700 (PDT) X-Google-Smtp-Source: APXvYqzNk6/y40xnA3vCQB8yAhYIux/novHIypIZVdmQcSZFqOz4Mq4Q8NnR2nM4J72P/2q0E62/ X-Received: by 2002:a17:906:8308:: with SMTP id j8mr13011232ejx.29.1570785119260; Fri, 11 Oct 2019 02:11:59 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1570785119; cv=none; d=google.com; s=arc-20160816; b=Cn7/OSlyjBDVXAFsPiU1bjhwuNIds7bfN3H4SKg0HYSWY0X8G8mtTv0NkDk/OM388O oJ7WYpQO4/jtodspcnWAxAZs0nyuwW8GvNKHWzhMStgfz9tBAj3eDG1B3m4H4F2NDQwR yClB2mfTM3bPe8JUMGWqkQDTzZgTJo00UDCviIwC4oV9FruaPR/iRbctp3EiFh0cXXEJ vl19G5BG0emDDt9V9C7nx9G7oiPLCSr9V4fhbm/+R7HiqWRQnkDWUGWQF6/Hc6gUR5UA 1mET1zcKKIOlSVBH2bEHbRurtL4ZOcznVa2DeleEUUOk84k3r6/ba129byTgHyd7A9Fq yXYA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:dkim-signature; bh=r4YF9udaf4djnoDA2tUUBCYw+kOORB8VmtPPQM5vQL0=; b=nHPNVqas4l0Zzzu7t8wI8sLb9oreRKAXxQJzFLp4pdcLVpo5cHG2wdy3H5nUUYV8AO V1T3BGvrffkYT6wAYE3hw2jS0h7pI+WZCGjJL5kI5cERqN1jyaBQzatLq1OQnta3nihf LJFCfi3oQ2UdAhqcTTj9cOLjCiKeWXhYSg87YBPVFHUyjUWRD23331pJFjJhK84g23rM WQj6I3F7OgbmAJvYLBHlkhbQluL4qgHxqbOoTqPz+YVvqcZFaN5ioXq1vO+c6QlxNOJF ubHlswtuw1CsFgN+bcBoUeINL8lFvCfIXVZUwKM9fv6RELrZ9eu+ejsLcILVwI0jWM+b dCyQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b="ocPh3/IR"; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id jo18si5121643ejb.27.2019.10.11.02.11.34; Fri, 11 Oct 2019 02:11:59 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b="ocPh3/IR"; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727167AbfJKJLP (ORCPT + 99 others); Fri, 11 Oct 2019 05:11:15 -0400 Received: from mail.kernel.org ([198.145.29.99]:60098 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726585AbfJKJLP (ORCPT ); Fri, 11 Oct 2019 05:11:15 -0400 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 8AE5B21D6C; Fri, 11 Oct 2019 09:11:12 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1570785073; bh=0b+19Hn7UbHkSSxLN4MXTvyEt2kAc48uoFb/JWDbo/I=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=ocPh3/IRZQVb6NWWmgiy3Ewp0AlBTKWgVUlOD9k5lB1EdxY2kvluEZsmwGLFROwKo MK4ylNgMuOO+WVtdy0wLIimkuRJYbSy/adKfmNBJ3iilOZ2IXKLLU9JltHeihqpe1z QVufYp25TN4xae0NxTIaWAOUMesGXjxOu5+P9D94= Date: Fri, 11 Oct 2019 11:11:10 +0200 From: Greg KH To: Chandra Annamaneni Cc: devel@driverdev.osuosl.org, gneukum1@gmail.com, michael.scheiderer@fau.de, fabian.krueger@fau.de, linux-kernel@vger.kernel.org, Simon =?iso-8859-1?Q?Sandstr=F6m?= , Dan Carpenter Subject: Re: [PATCH 2/5] KPC2000: kpc2000_spi.c: Fix style issues (missing blank line) Message-ID: <20191011091110.GA1124173@kroah.com> References: <20191011055155.4985-1-chandra627@gmail.com> <20191011055155.4985-2-chandra627@gmail.com> <20191011063321.GB986093@kroah.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.12.2 (2019-09-21) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org A: Because it messes up the order in which people normally read text. Q: Why is top-posting such a bad thing? A: Top-posting. Q: What is the most annoying thing in e-mail? A: No. Q: Should I include quotations after my reply? http://daringfireball.net/2007/07/on_top On Fri, Oct 11, 2019 at 02:02:32AM -0700, Chandra Annamaneni wrote: > The first set of patches were in a single commit. I started from scratch > and built these patches from 5 different commits. Don't know if the first > set of patches are relevant anymore. They are not relevant to being applied, but this patch series has changed based on the comments you received from the previous patch(s). So it is relevant to how you got to this set of patches. This makes it easier for reviewers to understand what changed and what they need to focus on, or ignore, in your new set of patches. This isn't for you, it is for the people you are sending these patches to. thanks, greg k-h