Received: by 2002:a5b:505:0:0:0:0:0 with SMTP id o5csp669752ybp; Fri, 11 Oct 2019 02:23:53 -0700 (PDT) X-Google-Smtp-Source: APXvYqy51PBKEAOm7Lza0fPum+CH19KTqWAWK79toEI9WUeTj8mMRDG8ywUk0ed69x6tepiCkst2 X-Received: by 2002:a17:906:556:: with SMTP id k22mr12755383eja.66.1570785833690; Fri, 11 Oct 2019 02:23:53 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1570785833; cv=none; d=google.com; s=arc-20160816; b=PC0Cnc5ylOgMwaahKPaHYSXWNGXjYt/Xer+Ynr9ECqCKZP8FXJPp6gRga/PJK1TNGL 1x5RQSq6RZwGGaMEO23S6z/JNGhMf8IBQOTV4v0U1l1iR92RHhCfGYhDFfq4OWG1sYiP PmkXJfNQ+wQXiYU3JbxZOIwbYyGae0RXC1u/V+DkXksBLimGAfqfB8XhWAw+i+cyIYGI D6mSxOg1HJ9hN5NVn+6ZQouwq+8+ktJbyNR8em2byp25Ocm0bg2qLUng35kXrkQNL2+3 yZYRCbw3eJIHNgQtlGb8y7bLzjkSXoFRWePLtfl8nxHrMdMRCeXH83N9k06Xh5h8KlEL TDiQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-language :content-transfer-encoding:in-reply-to:mime-version:user-agent:date :message-id:from:references:cc:to:subject; bh=VIkEyCqGS1R/SNdiLqH3NrzI8XNovz2YVoXV9uUFRk8=; b=EjUjjBlLtsrJhyJLYTcvrzvVcOyEcxZlpzmh1clsbAyf1CnzRwSLJgY5zDmH8lMUUU W4hkrLDdv5s+pjhRweiGSJdWeGKPGhfqdVqRZrFpgAQElzezcRS/F7eCtFjNtB7AnzPT 4OgM6e1FlLh26GgS+NhPEFjbbJVgpMTEFl1EgOUH+E911pDJlQOzaB1gm/p3NExUEYUs M3uXZSk842961A11rYjEavO6kJmXncCdLDs7DhGwVlv9pgkdebC3O/T+y98lGrzoJXyN b65732qgiq3rahtt/0UIxkWJH2A+FIkZ52rN4kEbKJPnSXTXjiiBG8UmR+py37JkjA9M KLrw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id 20si5022567ejv.342.2019.10.11.02.23.30; Fri, 11 Oct 2019 02:23:53 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727700AbfJKJUP (ORCPT + 99 others); Fri, 11 Oct 2019 05:20:15 -0400 Received: from dispatch1-us1.ppe-hosted.com ([67.231.154.164]:60222 "EHLO dispatch1-us1.ppe-hosted.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726585AbfJKJUO (ORCPT ); Fri, 11 Oct 2019 05:20:14 -0400 X-Virus-Scanned: Proofpoint Essentials engine Received: from webmail.solarflare.com (webmail.solarflare.com [12.187.104.26]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-SHA384 (256/256 bits)) (No client certificate requested) by mx1-us1.ppe-hosted.com (PPE Hosted ESMTP Server) with ESMTPS id B9FD2400082; Fri, 11 Oct 2019 09:20:12 +0000 (UTC) Received: from [10.17.20.203] (10.17.20.203) by ocex03.SolarFlarecom.com (10.20.40.36) with Microsoft SMTP Server (TLS) id 15.0.1395.4; Fri, 11 Oct 2019 02:20:07 -0700 Subject: Re: [PATCH net-next1/2] net: core: use listified Rx for GRO_NORMAL in napi_gro_receive() To: Alexander Lobakin CC: "David S. Miller" , Jiri Pirko , Eric Dumazet , Ido Schimmel , "Paolo Abeni" , Petr Machata , Sabrina Dubroca , Florian Fainelli , Jassi Brar , Ilias Apalodimas , , References: <20191010144226.4115-1-alobakin@dlink.ru> <20191010144226.4115-2-alobakin@dlink.ru> From: Edward Cree Message-ID: Date: Fri, 11 Oct 2019 10:20:06 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.7.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Content-Language: en-GB X-Originating-IP: [10.17.20.203] X-TM-AS-Product-Ver: SMEX-12.5.0.1300-8.5.1010-24968.005 X-TM-AS-Result: No-1.301100-4.000000-10 X-TMASE-MatchedRID: 5+1rHnqhWUT4ECMHJTM/ufHkpkyUphL9+D+zbdY8EikZFDQxUvPcmL6Y VRYkPkYCSCF6HRRH3gIN25tj8sME0kHGTQqAQaePelGHXZKLL2tfz6dKxk6eNJsoi2XrUn/JyeM tMD9QOgADpAZ2/B/BlgJTU9F/2jaz3QfwsVk0UbuZ/dgf3Hl0lQdcXOftadZZanKxcCqKqviyuT 4uqwSyJobVjstzILx+/ULPDpIN9LRKW7e49HWSFTC7+o0dCT3gG5LP5SWKhyqq4UVeuXo1MKKAQ fLsnhLrKWSt4DmvbhpicKLmK2TeKmsPn5C6nWpTiTSgm8kJVKRDDKa3G4nrLQ== X-TM-AS-User-Approved-Sender: No X-TM-AS-User-Blocked-Sender: No X-TMASE-Result: 10-1.301100-4.000000 X-TMASE-Version: SMEX-12.5.0.1300-8.5.1010-24968.005 X-MDID: 1570785613-jXSkVprpQDO2 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org >> On 10/10/2019 15:42, Alexander Lobakin wrote: >>> Commit 323ebb61e32b4 ("net: use listified RX for handling GRO_NORMAL >>> skbs") made use of listified skb processing for the users of >>> napi_gro_frags(). >>> The same technique can be used in a way more common napi_gro_receive() >>> to speed up non-merged (GRO_NORMAL) skbs for a wide range of drivers, >>> including gro_cells and mac80211 users. >>> >>> Signed-off-by: Alexander Lobakin Acked-by: Edward Cree but I think this needs review from the socionext folks as well.