Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
From:   Robert Richter <rrichter@marvell.com>
To:     Mauro Carvalho Chehab <mchehab@kernel.org>
CC:     Borislav Petkov <bp@alien8.de>, Tony Luck <tony.luck@intel.com>,
        "James Morse" <james.morse@arm.com>,
        "linux-edac@vger.kernel.org" <linux-edac@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 02/19] EDAC: Remove EDAC_DIMM_OFF() macro
Thread-Topic: [PATCH 02/19] EDAC: Remove EDAC_DIMM_OFF() macro
Thread-Index: AQHVf6jOVfuHIna6UUqSRNg3t3vfNadVOH+AgAAYUYA=
Date:   Fri, 11 Oct 2019 11:36:13 +0000
Message-ID: <20191011113605.kthxq5g27qqsbsu4@rric.localdomain>
References: <20191010202418.25098-1-rrichter@marvell.com>
 <20191010202418.25098-3-rrichter@marvell.com>
 <20191011070903.546d865f@coco.lan>
In-Reply-To: <20191011070903.546d865f@coco.lan>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-messagesentrepresentingtype: 1
x-originating-ip: [31.208.96.227]
x-ms-publictraffictype: Email
x-ms-office365-filtering-correlation-id: 17936e3f-3ba0-48c6-5f11-08d74e3f3823
x-ms-traffictypediagnostic: MN2PR18MB3088:
x-microsoft-antispam-prvs: <MN2PR18MB3088EAE912833E8D04F9EC51D9970@MN2PR18MB3088.namprd18.prod.outlook.com>
x-ms-oob-tlc-oobclassifiers: OLM:6108;
x-forefront-prvs: 0187F3EA14
x-forefront-antispam-report: SFV:NSPM;SFS:(10009020)(4636009)(376002)(346002)(396003)(39860400002)(366004)(136003)(189003)(199004)(446003)(4744005)(386003)(71190400001)(26005)(81166006)(53546011)(186003)(5660300002)(52116002)(6916009)(81156014)(11346002)(478600001)(8676002)(6506007)(256004)(476003)(71200400001)(6246003)(1076003)(14454004)(25786009)(66476007)(486006)(64756008)(66556008)(66446008)(66946007)(102836004)(86362001)(76176011)(305945005)(6512007)(7736002)(9686003)(66066001)(229853002)(54906003)(4326008)(6436002)(3846002)(6116002)(99286004)(8936002)(2906002)(6486002)(316002);DIR:OUT;SFP:1101;SCL:1;SRVR:MN2PR18MB3088;H:MN2PR18MB3408.namprd18.prod.outlook.com;FPR:;SPF:None;LANG:en;PTR:InfoNoRecords;MX:1;A:1;
received-spf: None (protection.outlook.com: marvell.com does not designate
 permitted sender hosts)
x-ms-exchange-senderadcheck: 1
x-microsoft-antispam: BCL:0;
x-microsoft-antispam-message-info: U7ErKwgD6l6Xbw+GJsUNzYbntwXqLGwQBXtYUm3qFOFFgk2rdE5xYEUuqYfcCA/2KnhyAXkvx+6d+43SpC19sKxkGtzDSdsOLZereuLyICmvenE5sCvU9ByDU9PazVM1leEf6l7wiTaqICzt6FA1Cyy8YslpEQ46CJbIjEx/q/a2f9KozxsGJOi8ULoCRBmWAhRyJKBZm8JlrSk0P1rAqEbTtAcNKgCk7L4P7o+s1fnt/VNFw1pN38utTJm/bAU/L/+a0H3839qdcPfWAtMAqclaj2Xg/sX1Jz5Efqcoizc71bMDmizKfd5VCU0/jrVM3GgYb8JIJD5g0YGzZgYAfvh+8dCzz49uaMuL6zJEDQy7/CE5ampUbdamifds4KnplOOKX6oIOFykcs/rp30PC0DjPKxVa98Lxk8kyBxsIC4=
x-ms-exchange-transport-forked: True
Content-Type: text/plain; charset="us-ascii"
Content-ID: <6157D1F5F17F504CB525708C8D3DA382@namprd18.prod.outlook.com>
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-Network-Message-Id: 17936e3f-3ba0-48c6-5f11-08d74e3f3823
X-MS-Exchange-CrossTenant-originalarrivaltime: 11 Oct 2019 11:36:13.0811
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 70e1fb47-1155-421d-87fc-2e58f638b6e0
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: eH+QJcH5X+IHBLr/b3TwPA6MYj6Gg2v97DqtlAsRjlWu3UGmPg8j+vlmeZkUrhoB6RevuFhrp27rsNhAvBaeaw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN2PR18MB3088
X-OriginatorOrg: marvell.com
X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.95,1.0.8
 definitions=2019-10-11_07:2019-10-10,2019-10-11 signatures=0
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Thanks for review.

On 11.10.19 07:09:03, Mauro Carvalho Chehab wrote:
> Em Thu, 10 Oct 2019 20:25:07 +0000
> Robert Richter <rrichter@marvell.com> escreveu:
>=20
> > The EDAC_DIMM_OFF() macro takes 5 arguments to get the DIMM's index.
> > This can be much simplified now as the offset is already stored in
> > struct dimm_info. Use it directly and completely remove the
> > EDAC_DIMM_OFF() macro.
>=20
> Ah, now I understand why you added the dimm idx field. One more reason
> why to split it on a separate patch (or perhaps merge it here).

Right, it needs to be part of the this patch.

-Robert