Received: by 2002:a5b:505:0:0:0:0:0 with SMTP id o5csp1071851ybp; Fri, 11 Oct 2019 08:34:23 -0700 (PDT) X-Google-Smtp-Source: APXvYqwChMxm4wKO1e5ikvB5sZpSOgXi+tWa9DgXBZdubVtTeuWfpYg2QD1OFi3A4VLmfkrHxsos X-Received: by 2002:a17:906:6bd5:: with SMTP id t21mr14407018ejs.277.1570808063625; Fri, 11 Oct 2019 08:34:23 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1570808063; cv=none; d=google.com; s=arc-20160816; b=CWqisVxdEqEQvI8jvYsINRottj4OhOva+vitywrvMKtWrCB5QExYZa+95wArIzKB1l uxeejFxZs73Bx3AYDnJN+m4In97iMyP4YL0txxyWQB1LLK6x+yZO6XOgc/MYdXH78Q18 sDsGMBr0QlXC11vC1ZGRx1YBp3fh5n/4X5nhcjTlYdOpVSFeKF84Q82TfXf4PfeLlW6d LfiPp2y+XsG+gVyCiaIXv6JW38IsNl+QqlWZ80CAIl4v6yLiG76uVPxV4b3yLxpMEW3u wq4MegLWl9fYOVj/tIVW/X7wyOglQr2sqwsDpxy+BBenitIP9TDGas+6Je5bkt2pxA6R HFwQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:dkim-signature; bh=czOkyRi1rxeY6kcSOMSBxuYV0GbCFBC+CJLu8G76l/g=; b=yDF7esx2Nj9j7nNkBK+BsuZUZBLwfeoewqBs5sPC4Xs9AoexA42bWbQgSEmCcZDV2/ RI96hs5+6HI3ZmbCUhjITQuuqDJBTd5mMR0H7XKKJi2FKfNB/yxbQam1r8VHXgf3MX8P 1RdebuK8ftE8ofC95UpVQmy4WZ1tMTPnxxLEwaF7SphLDU45YOLeee8lbskIJMnlhfmH M8mqGBrnLCO2xviOphqWXJztxFGNeIfHIO0Iz9kNImXaAugpSYRu0Ra4Jg76HigFtPw8 Ga0eTXcJLfisI3Sy1bLI1BMt4ctoN/E8XAV+CPYt9hG/ROnYVpshVmHbcCvTWFgWqRbn vO5w== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=Tz03Fhij; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id g21si5507739edm.116.2019.10.11.08.34.00; Fri, 11 Oct 2019 08:34:23 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=Tz03Fhij; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728187AbfJKPdX (ORCPT + 99 others); Fri, 11 Oct 2019 11:33:23 -0400 Received: from mail.kernel.org ([198.145.29.99]:55882 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726705AbfJKPdW (ORCPT ); Fri, 11 Oct 2019 11:33:22 -0400 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id D4820206A1; Fri, 11 Oct 2019 15:33:21 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1570808002; bh=NQZN68RxCKcJkzW1s3gFdeTrbhdEj1wIh0TR9/+K+qM=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=Tz03FhijMzybaUjcRLnyARmWhnjL4zawrMNjqenOQ2brweq6ww9pf0P/lwIVNZFwK L4HMwQSvOgVfANpq/ZXodjDiuq6PgVAiOWONjFL9iFfBk0h1hNWvN7O0zVWT+xPV+O hRpkxIf65rIB2WhICnqeOGNjdDFUtpuehZ42Boqw= Date: Fri, 11 Oct 2019 17:33:19 +0200 From: Greg Kroah-Hartman To: Matthias Maennich Cc: linux-kernel@vger.kernel.org, kernel-team@android.com, Jessica Yu , Masahiro Yamada , Martijn Coenen , Lucas De Marchi , Shaun Ruffell , Will Deacon , linux-kbuild@vger.kernel.org, linux-modules@vger.kernel.org Subject: Re: [PATCH 2/4] modpost: make updating the symbol namespace explict Message-ID: <20191011153319.GC1283883@kroah.com> References: <20191010151443.7399-1-maennich@google.com> <20191010151443.7399-3-maennich@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20191010151443.7399-3-maennich@google.com> User-Agent: Mutt/1.12.2 (2019-09-21) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Oct 10, 2019 at 04:14:41PM +0100, Matthias Maennich wrote: > Setting the symbol namespace of a symbol within sym_add_exported feels > displaced and lead to issues in the current implementation of symbol > namespaces. This patch makes updating the namespace an explicit call to > decouple it from adding a symbol to the export list. > > Signed-off-by: Matthias Maennich Reviewed-by: Greg Kroah-Hartman