Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
From:   Jerome Pouiller <Jerome.Pouiller@silabs.com>
To:     zhong jiang <zhongjiang@huawei.com>
CC:     Greg KH <gregkh@linuxfoundation.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] staging: wfx: fix an undefined reference error when
 CONFIG_MMC=m
Thread-Topic: [PATCH] staging: wfx: fix an undefined reference error when
 CONFIG_MMC=m
Thread-Index: AQHVf+DaxlKENNqV0UK69LaFcVpmvadU2EGAgABG9ACAAAZhAIAAchYAgAABG4A=
Date:   Fri, 11 Oct 2019 15:55:14 +0000
Message-ID: <25343442.QKQdTnp5z4@pc-42>
References: <1570762939-8735-1-git-send-email-zhongjiang@huawei.com>
 <20191011090256.GC1076760@kroah.com> <5DA0A4F4.4050103@huawei.com>
In-Reply-To: <5DA0A4F4.4050103@huawei.com>
Accept-Language: en-US
Content-Language: en-US
received-spf: None (protection.outlook.com: silabs.com does not designate
 permitted sender hosts)
Content-Type: text/plain; charset="iso-8859-1"
Content-ID: <B3F9255740D2D846BF850F7099619AF3@namprd11.prod.outlook.com>
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-Network-Message-Id: 6beaf1bc-2f01-4055-42ae-08d74e6367a3
X-MS-Exchange-CrossTenant-originalarrivaltime: 11 Oct 2019 15:55:14.2017
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 54dbd822-5231-4b20-944d-6f4abcd541fb
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: ERmu3h7lXD6HoUMb0uyyfiq0M42H0lEPrH+MObL/DA7w4GlcCFS0se4hNf+Fr/I00gP3PHHrhtQsqG+I7DVD6g==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN2PR11MB3631
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Friday 11 October 2019 17:51:29 CEST zhong jiang wrote:
[...]
> How about the following patch ?
>=20
> diff --git a/drivers/staging/wfx/Makefile b/drivers/staging/wfx/Makefile
> index 0d9c1ed..77d68b7 100644
> --- a/drivers/staging/wfx/Makefile
> +++ b/drivers/staging/wfx/Makefile
> @@ -19,6 +19,6 @@ wfx-y :=3D \
>         sta.o \
>         debug.o
>  wfx-$(CONFIG_SPI) +=3D bus_spi.o
> -wfx-$(subst m,y,$(CONFIG_MMC)) +=3D bus_sdio.o
> +wfx-$(CONFIG_MMC) +=3D bus_sdio.o
>=20
>  obj-$(CONFIG_WFX) +=3D wfx.o
> diff --git a/drivers/staging/wfx/main.c b/drivers/staging/wfx/main.c
> index d2508bc..26720a4 100644
> --- a/drivers/staging/wfx/main.c
> +++ b/drivers/staging/wfx/main.c
> @@ -484,16 +484,19 @@ static int __init wfx_core_init(void)
>=20
>         if (IS_ENABLED(CONFIG_SPI))
>                 ret =3D spi_register_driver(&wfx_spi_driver);
> -       if (IS_ENABLED(CONFIG_MMC) && !ret)
> +#ifdef CONFIG_MMC
> +       if (!ret)
>                 ret =3D sdio_register_driver(&wfx_sdio_driver);
> +#endif
>         return ret;
>  }
>  module_init(wfx_core_init);
>=20
>  static void __exit wfx_core_exit(void)
>  {
> -       if (IS_ENABLED(CONFIG_MMC))
> -               sdio_unregister_driver(&wfx_sdio_driver);
> +#ifdef CONFIG_MMC
> +       sdio_unregister_driver(&wfx_sdio_driver);
> +#endif
>         if (IS_ENABLED(CONFIG_SPI))
>                 spi_unregister_driver(&wfx_spi_driver);
>  }
Hello zhong,

Can you also check the case where CONFIG_SPI is not set?

Thank you,

--=20
J=E9r=F4me Pouiller