Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
From:   "Keller, Jacob E" <jacob.e.keller@intel.com>
To:     Stephen Rothwell <sfr@canb.auug.org.au>,
        David Miller <davem@davemloft.net>,
        Networking <netdev@vger.kernel.org>
CC:     Linux Next Mailing List <linux-next@vger.kernel.org>,
        "Linux Kernel Mailing List" <linux-kernel@vger.kernel.org>,
        Jakub Kicinski <jakub.kicinski@netronome.com>
Subject: RE: linux-next: Fixes tag needs some work in the net tree
Thread-Topic: linux-next: Fixes tag needs some work in the net tree
Thread-Index: AQHVf+n3tASYqcvLsUKPslnmzJJ6DKdV3oNQ
Date:   Fri, 11 Oct 2019 20:06:38 +0000
Message-ID: <02874ECE860811409154E81DA85FBB5896925B2B@ORSMSX121.amr.corp.intel.com>
References: <20191011151117.46bc6981@canb.auug.org.au>
In-Reply-To: <20191011151117.46bc6981@canb.auug.org.au>
Accept-Language: en-US
Content-Language: en-US
dlp-product: dlpe-windows
dlp-version: 11.2.0.6
dlp-reaction: no-action
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 8BIT
MIME-Version: 1.0
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

> -----Original Message-----
> From: netdev-owner@vger.kernel.org <netdev-owner@vger.kernel.org> On
> Behalf Of Stephen Rothwell
> Sent: Thursday, October 10, 2019 9:11 PM
> To: David Miller <davem@davemloft.net>; Networking
> <netdev@vger.kernel.org>
> Cc: Linux Next Mailing List <linux-next@vger.kernel.org>; Linux Kernel Mailing List
> <linux-kernel@vger.kernel.org>; Keller, Jacob E <jacob.e.keller@intel.com>;
> Jakub Kicinski <jakub.kicinski@netronome.com>
> Subject: linux-next: Fixes tag needs some work in the net tree
> 
> Hi all,
> 
> In commit
> 
>   2168da459404 ("net: update net_dim documentation after rename")
> 
> Fixes tag
> 
>   Fixes: 8960b38932be ("linux/dim: Rename externally used net_dim members",
> 2019-06-25)
> 
> has these problem(s):
> 
>   - Subject does not match target commit subject
>     Just use
> 	git log -1 --format='Fixes: %h ("%s")'
> 
> Fixes tag
> 
>   Fixes: c002bd529d71 ("linux/dim: Rename externally exposed macros", 2019-06-
> 25)
> 
> has these problem(s):
> 
>   - Subject does not match target commit subject
>     Just use
> 	git log -1 --format='Fixes: %h ("%s")'

Right, that was my mistake. I have an alias for this that is what was used by other projects (which prefer adding the date), and it's supposed to be set to only this in my local tree for the kernel, but not sure what happened there.

> --
> Cheers,
> Stephen Rothwell